You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/09/17 22:02:42 UTC
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8224:
[sqllab] create query slightly earlier
codecov-io edited a comment on issue #8224: [sqllab] create query slightly earlier
URL: https://github.com/apache/incubator-superset/pull/8224#issuecomment-531398993
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8224?src=pr&el=h1) Report
> Merging [#8224](https://codecov.io/gh/apache/incubator-superset/pull/8224?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/bf7ce62166a753d2e05a0a7d3dcbaff486784dad?src=pr&el=desc) will **increase** coverage by `1.51%`.
> The diff coverage is `75%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/8224?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8224 +/- ##
==========================================
+ Coverage 65.97% 67.49% +1.51%
==========================================
Files 479 481 +2
Lines 23038 25371 +2333
Branches 2552 2655 +103
==========================================
+ Hits 15200 17124 +1924
- Misses 7702 8106 +404
- Partials 136 141 +5
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8224?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `76.6% <75%> (+5.46%)` | :arrow_up: |
| [superset/assets/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL1RhYmxlU2VsZWN0b3IuanN4) | `80.92% <0%> (-3.25%)` | :arrow_down: |
| [...rset/assets/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9UYWJsZUVsZW1lbnQuanN4) | `83.2% <0%> (-1.14%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `89.17% <0%> (-0.83%)` | :arrow_down: |
| [superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `94.35% <0%> (-0.48%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [...rset/assets/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | `0% <0%> (ø)` | :arrow_up: |
| [superset/assets/src/SqlLab/components/ShowSQL.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9TaG93U1FMLmpzeA==) | `55.55% <0%> (ø)` | |
| [.../src/SqlLab/components/EstimateQueryCostButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9Fc3RpbWF0ZVF1ZXJ5Q29zdEJ1dHRvbi5qc3g=) | `17.39% <0%> (ø)` | |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.33% <0%> (+0.38%)` | :arrow_up: |
| ... and [9 more](https://codecov.io/gh/apache/incubator-superset/pull/8224/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8224?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8224?src=pr&el=footer). Last update [bf7ce62...9384b9f](https://codecov.io/gh/apache/incubator-superset/pull/8224?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org