[GitHub] spark pull request #14051: [SPARK-16372][MLlib] Retag RDD to tallSkinnyQR of...

[srowen <gi...@git.apache.org>]

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14051#discussion_r69521248
  
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/RowMatrix.scala ---
    @@ -537,7 +537,7 @@ class RowMatrix @Since("1.0.0") (
       def tallSkinnyQR(computeQ: Boolean = false): QRDecomposition[RowMatrix, Matrix] = {
         val col = numCols().toInt
         // split rows horizontally into smaller matrices, and compute QR for each of them
    -    val blockQRs = rows.glom().map { partRows =>
    +    val blockQRs = rows.retag(classOf[Vector]).glom().map { partRows =>
    --- End diff --
    
    Where does the exception actually occur? I guess I'm surprised if this is the only place this is needed. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org