You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/27 22:00:11 UTC

[GitHub] srowen commented on a change in pull request #23838: [SPARK-26928][CORE] Add driver CPU Time to the metrics system

srowen commented on a change in pull request #23838: [SPARK-26928][CORE] Add driver CPU Time to the metrics system
URL: https://github.com/apache/spark/pull/23838#discussion_r260963609
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
 ##########
 @@ -499,6 +499,13 @@ package object config {
     .stringConf
     .createOptional
 
+  private[spark] val METRICS_CPU_TIME_DRIVER_ENABLED =
 
 Review comment:
   Does this need a flag -- is there a drawback to enabling it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org