You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/08 21:27:49 UTC

[GitHub] [beam] damccorm commented on a diff in pull request #21749: Update all links to in progress jiras to issues

damccorm commented on code in PR #21749:
URL: https://github.com/apache/beam/pull/21749#discussion_r892881946


##########
website/www/site/content/en/documentation/patterns/overview.md:
##########
@@ -56,7 +56,7 @@ Pipeline patterns demonstrate common Beam use cases. Pipeline patterns are based
 
 ## Contributing a pattern
 
-To contribute a new pipeline pattern, create an issue with the [`pipeline-patterns` label](https://issues.apache.org/jira/browse/BEAM-7449?jql=labels%20%3D%20pipeline-patterns) and add details to the issue description. See [Get started contributing](/contribute/) for more information.
+To contribute a new pipeline pattern, create [a feature request](https://github.com/apache/beam/issues/new?assignees=octocat&labels=new+feature%2Cawaiting+triage&template=feature.yml&title=%5BFeature+Request%5D%3A+) and add details to the issue description. See [Get started contributing](/contribute/) for more information.

Review Comment:
   This one was actually correct, though the octocat piece wasn't needed (it doesn't harm anything though)



##########
website/www/site/content/en/roadmap/euphoria.md:
##########
@@ -19,7 +19,7 @@ limitations under the License.
 
 Easy to use Java 8 DSL for the Beam Java SDK. Provides a high-level abstraction of Beam transformations, which is both easy to read and write. Can be used as a complement to existing Beam pipelines (convertible back and forth). You can have a glimpse of the API at [WordCount example](/documentation/sdks/java/euphoria/#wordcount-example).
 
-- JIRA: [dsl-euphoria](https://issues.apache.org/jira/browse/BEAM-4366?jql=project%20%3D%20BEAM%20AND%20component%20%3D%20dsl-euphoria) / [BEAM-3900](https://issues.apache.org/jira/browse/BEAM-3900)
+- JIRA: [dsl-euphoria](https://github.com/apache/beam/issues?q=is%3Aopen+is%3Aissue+label%3Adsl-euphoria) / [BEAM-3900](https://issues.apache.org/jira/browse/BEAM-3900)

Review Comment:
   It's actually correct



##########
website/www/site/content/en/documentation/dsls/dataframes/differences-from-pandas.md:
##########
@@ -63,7 +63,7 @@ Examples:
 Beam DataFrame operations are deferred, but the schemas of the resulting DataFrames are not, meaning that result columns must be computable without access to the data. Some DataFrame operations can’t support this usage, so they can’t be implemented. These operations raise a [WontImplementError](https://beam.apache.org/releases/pydoc/{{< param release_latest >}}/apache_beam.dataframe.frame_base.html#apache_beam.dataframe.frame_base.WontImplementError).
 
 <!-- TODO(BEAM-12169): Document the use of categorical columns as a workaround -->
-Currently there’s no workaround for this issue. But in the future, Beam Dataframe may support non-deferred column operations on categorical columns. This work is being tracked in [BEAM-12169](https://issues.apache.org/jira/browse/BEAM-12169).
+Currently there’s no workaround for this issue. But in the future, Beam Dataframe may support non-deferred column operations on categorical columns. This work is being tracked in [BEAM-12169](https://github.com/apache/beam/issues/20958).

Review Comment:
   Yeah, I'm not too worried about fixing these types of instances - it doesn't make much of a difference IMO



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org