You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Mark Chu-Carroll <mc...@twopensource.com> on 2014/06/04 16:56:44 UTC
Review Request 22233: Fix logging in the command-runner.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22233/
-----------------------------------------------------------
Review request for Aurora, David McLaughlin and Brian Wickman.
Bugs: aurora-503
https://issues.apache.org/jira/browse/aurora-503
Repository: aurora
Description
-------
Fix logging in the command-runner.
Diffs
-----
src/main/python/apache/aurora/client/api/__init__.py 1af0f8fa77e15444027c553404495d1ebeb5e540
src/main/python/apache/aurora/client/api/command_runner.py 8b29f35f85f4173158e0d46aba091915bf7200d0
src/main/python/apache/aurora/client/cli/client.py 1fb5364894d230646592942434eb1da6554d5c05
src/main/python/apache/aurora/client/cli/config.py 034c68e52ac8d2fbabb9dbf4f397f1a4920d0122
src/main/python/apache/aurora/client/cli/cron.py c30a0a605412229f3e4cddbe8c5ae746f256e30c
src/main/python/apache/aurora/client/cli/task.py fe11f38b902ae54a4048ba114055ba30e8abe6c5
src/test/python/apache/aurora/client/api/test_sla.py 9c3bb6d386abbdbbfa8746639798ddca01d54fe9
src/test/python/apache/aurora/client/cli/test_config_noun.py 7a9d733835e204bfd179e698bc335435b837d24b
src/test/python/apache/aurora/client/cli/test_cron.py 049405a4323fc73102d6ac1dae2230be4325c530
src/test/python/apache/aurora/client/cli/test_task_run.py 26633981d561eeed498acece03c025bec00e11bd
src/test/python/apache/aurora/client/test_config.py 4b3e1499c7447792288f4b480cbd756c8e19a831
src/test/sh/org/apache/aurora/e2e/http_example.py 04f7fa5c9bf36a36b395d870db02b97f8e5b6c66
Diff: https://reviews.apache.org/r/22233/diff/
Testing
-------
Added check to unit tests; all client tests pass.
Thanks,
Mark Chu-Carroll
Re: Review Request 22233: Fix logging in the command-runner.
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22233/#review44723
-----------------------------------------------------------
src/main/python/apache/aurora/client/api/command_runner.py
<https://reviews.apache.org/r/22233/#comment79197>
this should probably be logging.DEBUG
if you really want to make it an instancemethod, it should go along with the other instancemethods below __init__.
alternatively, it can stay a static/classmethod by passing a logger in 'args' (e.g. by tacking it onto the end of the list returned by self.process_arguments)
- Brian Wickman
On June 4, 2014, 2:56 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22233/
> -----------------------------------------------------------
>
> (Updated June 4, 2014, 2:56 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Brian Wickman.
>
>
> Bugs: aurora-503
> https://issues.apache.org/jira/browse/aurora-503
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix logging in the command-runner.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/__init__.py 1af0f8fa77e15444027c553404495d1ebeb5e540
> src/main/python/apache/aurora/client/api/command_runner.py 8b29f35f85f4173158e0d46aba091915bf7200d0
> src/main/python/apache/aurora/client/cli/client.py 1fb5364894d230646592942434eb1da6554d5c05
> src/main/python/apache/aurora/client/cli/config.py 034c68e52ac8d2fbabb9dbf4f397f1a4920d0122
> src/main/python/apache/aurora/client/cli/cron.py c30a0a605412229f3e4cddbe8c5ae746f256e30c
> src/main/python/apache/aurora/client/cli/task.py fe11f38b902ae54a4048ba114055ba30e8abe6c5
> src/test/python/apache/aurora/client/api/test_sla.py 9c3bb6d386abbdbbfa8746639798ddca01d54fe9
> src/test/python/apache/aurora/client/cli/test_config_noun.py 7a9d733835e204bfd179e698bc335435b837d24b
> src/test/python/apache/aurora/client/cli/test_cron.py 049405a4323fc73102d6ac1dae2230be4325c530
> src/test/python/apache/aurora/client/cli/test_task_run.py 26633981d561eeed498acece03c025bec00e11bd
> src/test/python/apache/aurora/client/test_config.py 4b3e1499c7447792288f4b480cbd756c8e19a831
> src/test/sh/org/apache/aurora/e2e/http_example.py 04f7fa5c9bf36a36b395d870db02b97f8e5b6c66
>
> Diff: https://reviews.apache.org/r/22233/diff/
>
>
> Testing
> -------
>
> Added check to unit tests; all client tests pass.
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 22233: Fix logging in the command-runner.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22233/#review45376
-----------------------------------------------------------
Ping? This has also been sitting here waiting for review for a week!
- Mark Chu-Carroll
On June 4, 2014, 1:09 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22233/
> -----------------------------------------------------------
>
> (Updated June 4, 2014, 1:09 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Brian Wickman.
>
>
> Bugs: aurora-503
> https://issues.apache.org/jira/browse/aurora-503
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix logging in the command-runner.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/__init__.py 1af0f8fa77e15444027c553404495d1ebeb5e540
> src/main/python/apache/aurora/client/api/command_runner.py 8b29f35f85f4173158e0d46aba091915bf7200d0
> src/main/python/apache/aurora/client/cli/client.py 1fb5364894d230646592942434eb1da6554d5c05
> src/main/python/apache/aurora/client/cli/config.py 034c68e52ac8d2fbabb9dbf4f397f1a4920d0122
> src/main/python/apache/aurora/client/cli/cron.py c30a0a605412229f3e4cddbe8c5ae746f256e30c
> src/main/python/apache/aurora/client/cli/task.py fe11f38b902ae54a4048ba114055ba30e8abe6c5
> src/test/python/apache/aurora/client/api/test_sla.py 9c3bb6d386abbdbbfa8746639798ddca01d54fe9
> src/test/python/apache/aurora/client/cli/test_config_noun.py 7a9d733835e204bfd179e698bc335435b837d24b
> src/test/python/apache/aurora/client/cli/test_cron.py 049405a4323fc73102d6ac1dae2230be4325c530
> src/test/python/apache/aurora/client/cli/test_task_run.py 26633981d561eeed498acece03c025bec00e11bd
> src/test/python/apache/aurora/client/test_config.py 4b3e1499c7447792288f4b480cbd756c8e19a831
> src/test/sh/org/apache/aurora/e2e/http_example.py 04f7fa5c9bf36a36b395d870db02b97f8e5b6c66
>
> Diff: https://reviews.apache.org/r/22233/diff/
>
>
> Testing
> -------
>
> Added check to unit tests; all client tests pass.
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 22233: Fix logging in the command-runner.
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22233/#review45452
-----------------------------------------------------------
Ship it!
Ship It!
- David McLaughlin
On June 4, 2014, 5:09 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22233/
> -----------------------------------------------------------
>
> (Updated June 4, 2014, 5:09 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Brian Wickman.
>
>
> Bugs: aurora-503
> https://issues.apache.org/jira/browse/aurora-503
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix logging in the command-runner.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/__init__.py 1af0f8fa77e15444027c553404495d1ebeb5e540
> src/main/python/apache/aurora/client/api/command_runner.py 8b29f35f85f4173158e0d46aba091915bf7200d0
> src/main/python/apache/aurora/client/cli/client.py 1fb5364894d230646592942434eb1da6554d5c05
> src/main/python/apache/aurora/client/cli/config.py 034c68e52ac8d2fbabb9dbf4f397f1a4920d0122
> src/main/python/apache/aurora/client/cli/cron.py c30a0a605412229f3e4cddbe8c5ae746f256e30c
> src/main/python/apache/aurora/client/cli/task.py fe11f38b902ae54a4048ba114055ba30e8abe6c5
> src/test/python/apache/aurora/client/api/test_sla.py 9c3bb6d386abbdbbfa8746639798ddca01d54fe9
> src/test/python/apache/aurora/client/cli/test_config_noun.py 7a9d733835e204bfd179e698bc335435b837d24b
> src/test/python/apache/aurora/client/cli/test_cron.py 049405a4323fc73102d6ac1dae2230be4325c530
> src/test/python/apache/aurora/client/cli/test_task_run.py 26633981d561eeed498acece03c025bec00e11bd
> src/test/python/apache/aurora/client/test_config.py 4b3e1499c7447792288f4b480cbd756c8e19a831
> src/test/sh/org/apache/aurora/e2e/http_example.py 04f7fa5c9bf36a36b395d870db02b97f8e5b6c66
>
> Diff: https://reviews.apache.org/r/22233/diff/
>
>
> Testing
> -------
>
> Added check to unit tests; all client tests pass.
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 22233: Fix logging in the command-runner.
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22233/#review44757
-----------------------------------------------------------
Ship it!
Ship It!
- Brian Wickman
On June 4, 2014, 5:09 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22233/
> -----------------------------------------------------------
>
> (Updated June 4, 2014, 5:09 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Brian Wickman.
>
>
> Bugs: aurora-503
> https://issues.apache.org/jira/browse/aurora-503
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix logging in the command-runner.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/__init__.py 1af0f8fa77e15444027c553404495d1ebeb5e540
> src/main/python/apache/aurora/client/api/command_runner.py 8b29f35f85f4173158e0d46aba091915bf7200d0
> src/main/python/apache/aurora/client/cli/client.py 1fb5364894d230646592942434eb1da6554d5c05
> src/main/python/apache/aurora/client/cli/config.py 034c68e52ac8d2fbabb9dbf4f397f1a4920d0122
> src/main/python/apache/aurora/client/cli/cron.py c30a0a605412229f3e4cddbe8c5ae746f256e30c
> src/main/python/apache/aurora/client/cli/task.py fe11f38b902ae54a4048ba114055ba30e8abe6c5
> src/test/python/apache/aurora/client/api/test_sla.py 9c3bb6d386abbdbbfa8746639798ddca01d54fe9
> src/test/python/apache/aurora/client/cli/test_config_noun.py 7a9d733835e204bfd179e698bc335435b837d24b
> src/test/python/apache/aurora/client/cli/test_cron.py 049405a4323fc73102d6ac1dae2230be4325c530
> src/test/python/apache/aurora/client/cli/test_task_run.py 26633981d561eeed498acece03c025bec00e11bd
> src/test/python/apache/aurora/client/test_config.py 4b3e1499c7447792288f4b480cbd756c8e19a831
> src/test/sh/org/apache/aurora/e2e/http_example.py 04f7fa5c9bf36a36b395d870db02b97f8e5b6c66
>
> Diff: https://reviews.apache.org/r/22233/diff/
>
>
> Testing
> -------
>
> Added check to unit tests; all client tests pass.
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 22233: Fix logging in the command-runner.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22233/
-----------------------------------------------------------
(Updated June 11, 2014, 9:15 p.m.)
Review request for Aurora, David McLaughlin and Brian Wickman.
Changes
-------
rebase.
Bugs: aurora-503
https://issues.apache.org/jira/browse/aurora-503
Repository: aurora
Description
-------
Fix logging in the command-runner.
Diffs (updated)
-----
src/main/python/apache/aurora/client/api/__init__.py 99444d6d73b4c1f604e615d29c8fb56156ac7f74
src/main/python/apache/aurora/client/api/command_runner.py a291fd9176b0b059cf9fca54e532893cdcaba964
src/main/python/apache/aurora/client/cli/client.py 0cb69448cd24372067ac845eca5862bc3d3a46a9
src/main/python/apache/aurora/client/cli/task.py c21159c4af3fa3b21b271d94a1b0edbed49a76c8
src/test/python/apache/aurora/client/cli/test_task_run.py 167f4906c2d752ca188b83bf0e775bf6ad527073
Diff: https://reviews.apache.org/r/22233/diff/
Testing
-------
Added check to unit tests; all client tests pass.
Thanks,
Mark Chu-Carroll
Re: Review Request 22233: Fix logging in the command-runner.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22233/
-----------------------------------------------------------
(Updated June 4, 2014, 1:09 p.m.)
Review request for Aurora, David McLaughlin and Brian Wickman.
Changes
-------
address Wickman's review.
Bugs: aurora-503
https://issues.apache.org/jira/browse/aurora-503
Repository: aurora
Description
-------
Fix logging in the command-runner.
Diffs (updated)
-----
src/main/python/apache/aurora/client/api/__init__.py 1af0f8fa77e15444027c553404495d1ebeb5e540
src/main/python/apache/aurora/client/api/command_runner.py 8b29f35f85f4173158e0d46aba091915bf7200d0
src/main/python/apache/aurora/client/cli/client.py 1fb5364894d230646592942434eb1da6554d5c05
src/main/python/apache/aurora/client/cli/config.py 034c68e52ac8d2fbabb9dbf4f397f1a4920d0122
src/main/python/apache/aurora/client/cli/cron.py c30a0a605412229f3e4cddbe8c5ae746f256e30c
src/main/python/apache/aurora/client/cli/task.py fe11f38b902ae54a4048ba114055ba30e8abe6c5
src/test/python/apache/aurora/client/api/test_sla.py 9c3bb6d386abbdbbfa8746639798ddca01d54fe9
src/test/python/apache/aurora/client/cli/test_config_noun.py 7a9d733835e204bfd179e698bc335435b837d24b
src/test/python/apache/aurora/client/cli/test_cron.py 049405a4323fc73102d6ac1dae2230be4325c530
src/test/python/apache/aurora/client/cli/test_task_run.py 26633981d561eeed498acece03c025bec00e11bd
src/test/python/apache/aurora/client/test_config.py 4b3e1499c7447792288f4b480cbd756c8e19a831
src/test/sh/org/apache/aurora/e2e/http_example.py 04f7fa5c9bf36a36b395d870db02b97f8e5b6c66
Diff: https://reviews.apache.org/r/22233/diff/
Testing
-------
Added check to unit tests; all client tests pass.
Thanks,
Mark Chu-Carroll