You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2014/08/13 02:43:05 UTC

Review Request 24623: Alerts: Update Oracle Alert DDL for CLOB

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24623/
-----------------------------------------------------------

Review request for Ambari and Nate Cole.


Bugs: AMBARI-6839
    https://issues.apache.org/jira/browse/AMBARI-6839


Repository: ambari


Description
-------

Noticed while doing the DAO work that the Oracle DDL scripts were using VARCHAR(4000) in some places where MySQL and PostgreSQL were using TEXT. Adjusted the 2 fields that will contain structured JSON data to be CLOB in these cases.

On upgrade, we're now using char[].class - The exact implementation of org.eclipse.persistence.platform.database.DatabasePlatform will determine the actual field type to use (CLOB on Oracle, TEXT on MySQL, etc).


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertDefinitionEntity.java 3aa0e62 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertTargetEntity.java 6f9ab89 
  ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java ab9d18b 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 6a8f35d 

Diff: https://reviews.apache.org/r/24623/diff/


Testing
-------

Manually ran the upgrade script and verified that the upgrade tests pass.


Thanks,

Jonathan Hurley

Re: Review Request 24623: Alerts: Update Oracle Alert DDL for CLOB

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24623/#review50394
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On Aug. 12, 2014, 8:43 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24623/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2014, 8:43 p.m.)
> 
> 
> Review request for Ambari and Nate Cole.
> 
> 
> Bugs: AMBARI-6839
>     https://issues.apache.org/jira/browse/AMBARI-6839
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Noticed while doing the DAO work that the Oracle DDL scripts were using VARCHAR(4000) in some places where MySQL and PostgreSQL were using TEXT. Adjusted the 2 fields that will contain structured JSON data to be CLOB in these cases.
> 
> On upgrade, we're now using char[].class - The exact implementation of org.eclipse.persistence.platform.database.DatabasePlatform will determine the actual field type to use (CLOB on Oracle, TEXT on MySQL, etc).
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertDefinitionEntity.java 3aa0e62 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertTargetEntity.java 6f9ab89 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java ab9d18b 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 6a8f35d 
> 
> Diff: https://reviews.apache.org/r/24623/diff/
> 
> 
> Testing
> -------
> 
> Manually ran the upgrade script and verified that the upgrade tests pass.
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>