You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "John Blum (Jira)" <ji...@apache.org> on 2020/03/18 02:29:00 UTC
[jira] [Updated] (GEODE-7890) @Deprecated ConfigurationProperties
should be applied consistently
[ https://issues.apache.org/jira/browse/GEODE-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Blum updated GEODE-7890:
-----------------------------
Description:
The {{@Deprecated}} annotation was *not* appropriately and consistently applied to ALL [org.apache.geode.distributed.ConfigurationProperties|http://example.com] constants representing Apache Geode properties!
For instance, all {{cluster-ssl-\*}} properties have been *deprecated* as indicated by the [CLUSTER_SSL_PREFIX|https://github.com/apache/geode/blob/rel/v1.11.0/geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java#L169-L170] as well as the _Javadoc_ comments for individual {{CLUST_SSL_*}} property constants, for [instance|https://github.com/apache/geode/blob/rel/v1.11.0/geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java#L210]. However, the actually [constant|https://github.com/apache/geode/blob/rel/v1.11.0/geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java#L212] is *NOT* properly annotated with {{@Deprecated}}.
This is unlike other property constants which have been properly *deprecated* using the {{@Deprecated}} annotation. For instance, the [Javadoc|https://github.com/apache/geode/blob/rel/v1.11.0/geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java#L559-L560] and the [annotation|https://github.com/apache/geode/blob/rel/v1.11.0/geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java#L562-L563].
was:
The {{@Deprecated}} annotation was *not* appropriately and consistently applied to ALL [org.apache.geode.distributed.ConfigurationProperties|http://example.com] constants representing Apache Geode properties!
For instance, all {{cluster-ssl-*}} properties have been *deprecated* as indicated by the [CLUSTER_SSL_PREFIX|https://github.com/apache/geode/blob/rel/v1.11.0/geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java#L169-L170] as well as the _Javadoc_ comments for individual {{CLUST_SSL_*}} property constants, for [instance|https://github.com/apache/geode/blob/rel/v1.11.0/geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java#L210]. However, the actually [constant|https://github.com/apache/geode/blob/rel/v1.11.0/geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java#L212] is *NOT* properly annotated with {{@Deprecated}}.
This is unlike other property constants which have been properly *deprecated* using the {{@Deprecated}} annotation. For instance, the [Javadoc|https://github.com/apache/geode/blob/rel/v1.11.0/geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java#L559-L560] and the [annotation|https://github.com/apache/geode/blob/rel/v1.11.0/geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java#L562-L563].
> @Deprecated ConfigurationProperties should be applied consistently
> ------------------------------------------------------------------
>
> Key: GEODE-7890
> URL: https://issues.apache.org/jira/browse/GEODE-7890
> Project: Geode
> Issue Type: Bug
> Components: configuration
> Reporter: John Blum
> Priority: Major
>
> The {{@Deprecated}} annotation was *not* appropriately and consistently applied to ALL [org.apache.geode.distributed.ConfigurationProperties|http://example.com] constants representing Apache Geode properties!
> For instance, all {{cluster-ssl-\*}} properties have been *deprecated* as indicated by the [CLUSTER_SSL_PREFIX|https://github.com/apache/geode/blob/rel/v1.11.0/geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java#L169-L170] as well as the _Javadoc_ comments for individual {{CLUST_SSL_*}} property constants, for [instance|https://github.com/apache/geode/blob/rel/v1.11.0/geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java#L210]. However, the actually [constant|https://github.com/apache/geode/blob/rel/v1.11.0/geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java#L212] is *NOT* properly annotated with {{@Deprecated}}.
> This is unlike other property constants which have been properly *deprecated* using the {{@Deprecated}} annotation. For instance, the [Javadoc|https://github.com/apache/geode/blob/rel/v1.11.0/geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java#L559-L560] and the [annotation|https://github.com/apache/geode/blob/rel/v1.11.0/geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java#L562-L563].
--
This message was sent by Atlassian Jira
(v8.3.4#803005)