You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/10/20 07:03:55 UTC

[GitHub] [kafka] dajac commented on pull request #9430: KAFKA-5235: GetOffsetShell: support for multiple topics and consumer configuration override

dajac commented on pull request #9430:
URL: https://github.com/apache/kafka/pull/9430#issuecomment-712640555


   @urbandan Thanks for the PR. I haven't looked at it yet but I have already noticed that there are no unit/integration tests. We need some. You can look at how other commands are tested. Having ducktape tests is very good but not enough to catch bugs and regressions.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org