[GitHub] [spark] maropu commented on a change in pull request #26906: [SPARK-30066][SQL][FOLLOWUP] Remove size field for interval column cache

[GitBox <gi...@apache.org>]

maropu commented on a change in pull request #26906: [SPARK-30066][SQL][FOLLOWUP] Remove size field for interval column cache
URL: https://github.com/apache/spark/pull/26906#discussion_r358532286
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/ColumnType.scala
 ##########
 @@ -705,31 +705,35 @@ private[columnar] case class MAP(dataType: MapType)
   override def clone(v: UnsafeMapData): UnsafeMapData = v.copy()
 }
 
-private[columnar] object CALENDAR_INTERVAL extends ColumnType[CalendarInterval]
-  with DirectCopyColumnType[CalendarInterval] {
+private[columnar] object CALENDAR_INTERVAL extends ColumnType[CalendarInterval] {
 
   override def dataType: DataType = CalendarIntervalType
 
   override def defaultSize: Int = 16
 
-  override def actualSize(row: InternalRow, ordinal: Int): Int = 20
-
   override def getField(row: InternalRow, ordinal: Int): CalendarInterval = row.getInterval(ordinal)
 
   override def setField(row: InternalRow, ordinal: Int, value: CalendarInterval): Unit = {
     row.setInterval(ordinal, value)
   }
 
   override def extract(buffer: ByteBuffer): CalendarInterval = {
-    ByteBufferHelper.getInt(buffer)
     val months = ByteBufferHelper.getInt(buffer)
     val days = ByteBufferHelper.getInt(buffer)
     val microseconds = ByteBufferHelper.getLong(buffer)
     new CalendarInterval(months, days, microseconds)
   }
 
+  // copy the bytes from ByteBuffer to UnsafeRow
+  override def extract(buffer: ByteBuffer, row: InternalRow, ordinal: Int): Unit = row match {
+    case r: MutableUnsafeRow =>
 
 Review comment:
   nit: How about just using `if` in the same way with decimal?: https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/ColumnType.scala#L478-L484

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org