You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Tom Beerbower <tb...@hortonworks.com> on 2014/03/07 01:47:26 UTC
Review Request 18881: Cannot stop selected services via API
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18881/
-----------------------------------------------------------
Review request for Ambari, Nate Cole and Sid Wagle.
Bugs: AMBARI-4981
https://issues.apache.org/jira/browse/AMBARI-4981
Repository: ambari
Description
-------
When trying to stop selected services via the API using the "in" clause, the API seems to stop the last service in the comma-delimited list.
For example
curl -i -uadmin:admin -H 'X-Requested-By: ambari' -X PUT -d '{"ServiceInfo/state":"INSTALLED"}' 'http://localhost:8080/api/v1/clusters/cl1/services?ServiceInfo/service_name.in(YARN,MAPREDUCE2,FALCON,OOZIE,GANGLIA,ZOOKEEPER)'
creates STOP tasks for ZOOKEEPER only.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractResourceProvider.java cec3d1d
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractResourceProviderTest.java 11adbee
Diff: https://reviews.apache.org/r/18881/diff/
Testing
-------
Added new unit test.
All tests pass :
Results :
Tests run: 1481, Failures: 0, Errors: 0, Skipped: 9
Thanks,
Tom Beerbower
Re: Review Request 18881: Cannot stop selected services via API
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18881/#review36512
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On March 6, 2014, 7:47 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18881/
> -----------------------------------------------------------
>
> (Updated March 6, 2014, 7:47 p.m.)
>
>
> Review request for Ambari, Nate Cole and Sid Wagle.
>
>
> Bugs: AMBARI-4981
> https://issues.apache.org/jira/browse/AMBARI-4981
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When trying to stop selected services via the API using the "in" clause, the API seems to stop the last service in the comma-delimited list.
> For example
>
> curl -i -uadmin:admin -H 'X-Requested-By: ambari' -X PUT -d '{"ServiceInfo/state":"INSTALLED"}' 'http://localhost:8080/api/v1/clusters/cl1/services?ServiceInfo/service_name.in(YARN,MAPREDUCE2,FALCON,OOZIE,GANGLIA,ZOOKEEPER)'
>
> creates STOP tasks for ZOOKEEPER only.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractResourceProvider.java cec3d1d
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractResourceProviderTest.java 11adbee
>
> Diff: https://reviews.apache.org/r/18881/diff/
>
>
> Testing
> -------
>
> Added new unit test.
>
> All tests pass :
>
> Results :
>
> Tests run: 1481, Failures: 0, Errors: 0, Skipped: 9
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 18881: Cannot stop selected services via API
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18881/#review36467
-----------------------------------------------------------
Ship it!
Ship It!
- Sid Wagle
On March 7, 2014, 12:47 a.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18881/
> -----------------------------------------------------------
>
> (Updated March 7, 2014, 12:47 a.m.)
>
>
> Review request for Ambari, Nate Cole and Sid Wagle.
>
>
> Bugs: AMBARI-4981
> https://issues.apache.org/jira/browse/AMBARI-4981
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When trying to stop selected services via the API using the "in" clause, the API seems to stop the last service in the comma-delimited list.
> For example
>
> curl -i -uadmin:admin -H 'X-Requested-By: ambari' -X PUT -d '{"ServiceInfo/state":"INSTALLED"}' 'http://localhost:8080/api/v1/clusters/cl1/services?ServiceInfo/service_name.in(YARN,MAPREDUCE2,FALCON,OOZIE,GANGLIA,ZOOKEEPER)'
>
> creates STOP tasks for ZOOKEEPER only.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractResourceProvider.java cec3d1d
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractResourceProviderTest.java 11adbee
>
> Diff: https://reviews.apache.org/r/18881/diff/
>
>
> Testing
> -------
>
> Added new unit test.
>
> All tests pass :
>
> Results :
>
> Tests run: 1481, Failures: 0, Errors: 0, Skipped: 9
>
>
> Thanks,
>
> Tom Beerbower
>
>