You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2021/04/02 10:17:17 UTC

[GitHub] [zeppelin] cuspymd commented on a change in pull request #4086: [ZEPPELIN-5243]. Get HIVE_CONF_DIR from enviroment in flink interpreter

cuspymd commented on a change in pull request #4086:
URL: https://github.com/apache/zeppelin/pull/4086#discussion_r606174794



##########
File path: flink/interpreter/src/main/scala/org/apache/zeppelin/flink/FlinkScalaInterpreter.scala
##########
@@ -450,9 +450,9 @@ class FlinkScalaInterpreter(val properties: Properties) {
   }
 
   private def registerHiveCatalog(): Unit = {
-    val hiveConfDir =
-      properties.getOrDefault("HIVE_CONF_DIR", System.getenv("HIVE_CONF_DIR")).toString
-    if (hiveConfDir == null) {
+    val hiveConfDir = sys.env.getOrElse("HIVE_CONF_DIR",
+      properties.getProperty("HIVE_CONF_DIR", "")).toString

Review comment:
       The priority seems be changed between environment variable and property, is it intentional?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org