You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Yifan Cai (Jira)" <ji...@apache.org> on 2020/08/28 23:01:00 UTC

[jira] [Updated] (CASSANDRA-15954) When compaction gets interrupted, the exception should include the compactionId

     [ https://issues.apache.org/jira/browse/CASSANDRA-15954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yifan Cai updated CASSANDRA-15954:
----------------------------------
    Test and Documentation Plan: unit test
                         Status: Patch Available  (was: Open)

PR: https://github.com/apache/cassandra/pull/729

[Test|https://app.circleci.com/pipelines/github/yifan-c/cassandra?branch=CASSANDRA-15954-compactionId-in-exception-trunk]

The patch simply add the taskID/compactionId to the {{toString}} method of {{CompactionInfo}}. So the taskId is displayed in the log. 

> When compaction gets interrupted, the exception should include the compactionId
> -------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-15954
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15954
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Local/Compaction
>            Reporter: David Capwell
>            Assignee: Yifan Cai
>            Priority: Normal
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> When we log in compaction we use the compactionId (or taskId), because of this we can figure out the start and end log lines for compaction.  The issue is, when you interrupt a compaction task, we don’t log the compactionId, we instead log the tableId; for this reason it is much harder to attribute the interrupt to a single compactionId
> Examples
> {code}
> INFO  2020-07-15T18:04:51,670 [CompactionExecutor:144057] org.apache.cassandra.db.compaction.CompactionTask:158 - Compacting (5a463760-c700-11ea-8982-13c71a558319) [data/ks/table/ma-27-Data.db:level=0, data/ks/table/
> ma-24-Data.db:level=0, ]
> INFO  2020-07-15T18:33:47,550 [CompactionExecutor:144057] org.apache.cassandra.concurrent.DebuggableThreadPoolExecutor:1942 - Compaction interrupted: Compaction@057aa994-c35b-39ec-b74d-33fba2d13bbc(ks, table, 3105436904/8658590553)bytes
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org