You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "cyb70289 (via GitHub)" <gi...@apache.org> on 2023/03/22 03:24:22 UTC
[GitHub] [arrow] cyb70289 commented on a diff in pull request #34671: GH-15233: [C++] Correct thread contention in s3fs
cyb70289 commented on code in PR #34671:
URL: https://github.com/apache/arrow/pull/34671#discussion_r1144191277
##########
cpp/src/arrow/filesystem/s3fs.cc:
##########
@@ -1244,12 +1244,12 @@ class ObjectOutputStream final : public io::OutputStream {
if (current_part_) {
// Upload last part
- RETURN_NOT_OK(CommitCurrentPart());
+ RETURN_NOT_OK(CommitCurrentPart(true));
Review Comment:
Add a comment to make it easier to reason the boolean argument at caller side?
`CommitCurrentPart(/*always_foreground_writes=*/true)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org