You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by er...@apache.org on 2019/10/24 15:09:21 UTC
[commons-rng] branch master updated: Badge.
This is an automated email from the ASF dual-hosted git repository.
erans pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-rng.git
The following commit(s) were added to refs/heads/master by this push:
new 5461d28 Badge.
5461d28 is described below
commit 5461d28594d006365b20a4748957656208c3a599
Author: Gilles Sadowski <gi...@harfang.homelinux.org>
AuthorDate: Thu Oct 24 17:08:08 2019 +0200
Badge.
---
README.md | 1 +
1 file changed, 1 insertion(+)
diff --git a/README.md b/README.md
index 54dee6e..66e67d7 100644
--- a/README.md
+++ b/README.md
@@ -48,6 +48,7 @@ Apache Commons RNG
[](https://sonarcloud.io/dashboard?id=commons-rng)
[](https://maven-badges.herokuapp.com/maven-central/org.apache.commons/commons-rng-simple/)
[](https://javadoc.io/doc/org.apache.commons/commons-rng-simple/1.2)
+[](https://lgtm.com/projects/g/apache/commons-rng/context:java)
The Apache Commons RNG project provides pure-Java implementation of pseudo-random generators.
Re: [RNG] LGTM analysis (Was: [...] branch master updated: Badge.)
Posted by sebb <se...@gmail.com>.
On Thu, 24 Oct 2019 at 16:36, Alex Herbert <al...@gmail.com> wrote:
>
>
>
> > On 24 Oct 2019, at 16:23, Gilles Sadowski <gi...@gmail.com> wrote:
> >
> > Hello.
> >
> > "Commons RNG" page on GitHub[1] now links to the LGTM report[2].
> >
> > Unfortunately, the one "alert" there[3] is a false positive.
> > Perhaps, we could make it go away by rewriting the "while" loop
> > as a "for" loop... (or changing the bound to "size - 1”).
>
> I saw that.
>
> The loop was written to avoid an if statement within the loop. I’ll see if a variant can pass the LGTM check.
If you do change the code, best to add a comment as to why the
particular syntax is being used.
> Alex
>
>
> >
> > Regards,
> > Gilles
> >
> > [1] https://github.com/apache/commons-rng
> > [2] https://lgtm.com/projects/g/apache/commons-rng/context:java
> > [3] https://lgtm.com/projects/g/apache/commons-rng/snapshot/8504c91b999959c38e97a69ed1d9f71f41e3bd40/files/commons-rng-simple/src/main/java/org/apache/commons/rng/simple/internal/Long2IntArray.java
> >
> >> [...]
> >>
> >> commit 5461d28594d006365b20a4748957656208c3a599
> >> Author: Gilles Sadowski <gi...@harfang.homelinux.org>
> >> AuthorDate: Thu Oct 24 17:08:08 2019 +0200
> >>
> >> Badge.
> >> [...]
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [RNG] LGTM analysis (Was: [...] branch master updated: Badge.)
Posted by Alex Herbert <al...@gmail.com>.
> On 24 Oct 2019, at 16:23, Gilles Sadowski <gi...@gmail.com> wrote:
>
> Hello.
>
> "Commons RNG" page on GitHub[1] now links to the LGTM report[2].
>
> Unfortunately, the one "alert" there[3] is a false positive.
> Perhaps, we could make it go away by rewriting the "while" loop
> as a "for" loop... (or changing the bound to "size - 1”).
I saw that.
The loop was written to avoid an if statement within the loop. I’ll see if a variant can pass the LGTM check.
Alex
>
> Regards,
> Gilles
>
> [1] https://github.com/apache/commons-rng
> [2] https://lgtm.com/projects/g/apache/commons-rng/context:java
> [3] https://lgtm.com/projects/g/apache/commons-rng/snapshot/8504c91b999959c38e97a69ed1d9f71f41e3bd40/files/commons-rng-simple/src/main/java/org/apache/commons/rng/simple/internal/Long2IntArray.java
>
>> [...]
>>
>> commit 5461d28594d006365b20a4748957656208c3a599
>> Author: Gilles Sadowski <gi...@harfang.homelinux.org>
>> AuthorDate: Thu Oct 24 17:08:08 2019 +0200
>>
>> Badge.
>> [...]
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[RNG] LGTM analysis (Was: [...] branch master updated: Badge.)
Posted by Gilles Sadowski <gi...@gmail.com>.
Hello.
"Commons RNG" page on GitHub[1] now links to the LGTM report[2].
Unfortunately, the one "alert" there[3] is a false positive.
Perhaps, we could make it go away by rewriting the "while" loop
as a "for" loop... (or changing the bound to "size - 1").
Regards,
Gilles
[1] https://github.com/apache/commons-rng
[2] https://lgtm.com/projects/g/apache/commons-rng/context:java
[3] https://lgtm.com/projects/g/apache/commons-rng/snapshot/8504c91b999959c38e97a69ed1d9f71f41e3bd40/files/commons-rng-simple/src/main/java/org/apache/commons/rng/simple/internal/Long2IntArray.java
> [...]
>
> commit 5461d28594d006365b20a4748957656208c3a599
> Author: Gilles Sadowski <gi...@harfang.homelinux.org>
> AuthorDate: Thu Oct 24 17:08:08 2019 +0200
>
> Badge.
> [...]
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org