You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/12 17:16:43 UTC
[GitHub] [flink] walterddr opened a new pull request #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
walterddr opened a new pull request #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836
## What is the purpose of the change
This PR refactors `SecurityUtils.class` in `flink-runtime` and replace with an extendable module based on the [service provider pattern](https://docs.oracle.com/javase/tutorial/sound/SPI-intro.html). With this extension, users can {create extendable security modules](https://docs.oracle.com/javase/tutorial/ext/basics/spi.html) with 3rd-party implementations.
## Brief change log
- Added SecurityFactoryService class for discovering installed SecurityFactory(s) in the classpath.
- Extended into SecurityModuleFactory and SecurityContextFactory.
- Replace SecurityUtils with SecurityEnvironment class that holds all installed security-related objects.
- Replace current security installation process with a 2-step installation - first install security module(s) per user-defined properties, then install security context based on security modules and properties
- Refactored current Hadoop/JaaS/Zookeeper modules into extendable class.
## Verifying this change
This change is already covered by existing tests in `flink-runtime` and ITCases in YARN and Kafka modules, also added to the tests:
- Modified YARN and Kafka test modules to install modules/context through service provider discovery
- Included test module factories and a default security context factory in test path.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - changes CLI options though
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: yes
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? yes
- If yes, how is the feature documented? CLI doc updated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] walterddr commented on issue #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
walterddr commented on issue #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#issuecomment-575229402
yes @aljoscha. Just to clarify, do you mean the renaming of the `SecurityUtils` to `SecurityEnvironment` part or does it also apply to the refactoring of the security `*Module`s `*Factory`s and `*Context`s ? I think the second part should go together with this PR.
Anyway I created 3 commits under: https://github.com/apache/flink/compare/master...walterddr:FLINK-11589-final. I will force push the first part once Travis show green.
Thanks
--
Rong
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#issuecomment-573438212
<!--
Meta data
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144062568 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:c5927b76a270ceaf3ae6442826e582d97487c52d Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4415 TriggerType:PUSH TriggerID:c5927b76a270ceaf3ae6442826e582d97487c52d
Hash:c5927b76a270ceaf3ae6442826e582d97487c52d Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144863310 TriggerType:PUSH TriggerID:c5927b76a270ceaf3ae6442826e582d97487c52d
Hash:4abd8a69ee904427937fb2a1df0c2c70743e7f86 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144966253 TriggerType:PUSH TriggerID:4abd8a69ee904427937fb2a1df0c2c70743e7f86
Hash:4abd8a69ee904427937fb2a1df0c2c70743e7f86 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4445 TriggerType:PUSH TriggerID:4abd8a69ee904427937fb2a1df0c2c70743e7f86
Hash:b7fc04de87f5a4ce4330eed335441cd0f05c4b80 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148241552 TriggerType:PUSH TriggerID:b7fc04de87f5a4ce4330eed335441cd0f05c4b80
Hash:b7fc04de87f5a4ce4330eed335441cd0f05c4b80 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5019 TriggerType:PUSH TriggerID:b7fc04de87f5a4ce4330eed335441cd0f05c4b80
Hash:e9b600c4247ed0e732ffdb22da29a4420968fe30 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149315280 TriggerType:PUSH TriggerID:e9b600c4247ed0e732ffdb22da29a4420968fe30
Hash:e9b600c4247ed0e732ffdb22da29a4420968fe30 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5257 TriggerType:PUSH TriggerID:e9b600c4247ed0e732ffdb22da29a4420968fe30
Hash:d89ec0b2ac3a2f1547369443af8262a2fa6b8173 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5303 TriggerType:PUSH TriggerID:d89ec0b2ac3a2f1547369443af8262a2fa6b8173
Hash:d89ec0b2ac3a2f1547369443af8262a2fa6b8173 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/149602081 TriggerType:PUSH TriggerID:d89ec0b2ac3a2f1547369443af8262a2fa6b8173
Hash:1ae00a0129b97a081ac2c4d392434bc5cd4d3357 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5314 TriggerType:PUSH TriggerID:1ae00a0129b97a081ac2c4d392434bc5cd4d3357
Hash:1ae00a0129b97a081ac2c4d392434bc5cd4d3357 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/149623142 TriggerType:PUSH TriggerID:1ae00a0129b97a081ac2c4d392434bc5cd4d3357
Hash:d692bd963ddcd14f75be19cce29033234ae6259f Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5329 TriggerType:PUSH TriggerID:d692bd963ddcd14f75be19cce29033234ae6259f
Hash:d692bd963ddcd14f75be19cce29033234ae6259f Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/149674994 TriggerType:PUSH TriggerID:d692bd963ddcd14f75be19cce29033234ae6259f
Hash:62e65bc4a716669146d2d48a5f414afe4beb9498 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5354 TriggerType:PUSH TriggerID:62e65bc4a716669146d2d48a5f414afe4beb9498
Hash:62e65bc4a716669146d2d48a5f414afe4beb9498 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/149795575 TriggerType:PUSH TriggerID:62e65bc4a716669146d2d48a5f414afe4beb9498
-->
## CI report:
* 0e53d682360fe30462917c820c9aa866caa957b5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144062568) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270)
* c5927b76a270ceaf3ae6442826e582d97487c52d Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144863310) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4415)
* 4abd8a69ee904427937fb2a1df0c2c70743e7f86 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144966253) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4445)
* b7fc04de87f5a4ce4330eed335441cd0f05c4b80 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/148241552) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5019)
* e9b600c4247ed0e732ffdb22da29a4420968fe30 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149315280) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5257)
* d89ec0b2ac3a2f1547369443af8262a2fa6b8173 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149602081) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5303)
* 1ae00a0129b97a081ac2c4d392434bc5cd4d3357 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149623142) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5314)
* d692bd963ddcd14f75be19cce29033234ae6259f Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149674994) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5329)
* 62e65bc4a716669146d2d48a5f414afe4beb9498 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/149795575) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5354)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#issuecomment-573438212
<!--
Meta data
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144062568 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:c5927b76a270ceaf3ae6442826e582d97487c52d Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4415 TriggerType:PUSH TriggerID:c5927b76a270ceaf3ae6442826e582d97487c52d
Hash:c5927b76a270ceaf3ae6442826e582d97487c52d Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144863310 TriggerType:PUSH TriggerID:c5927b76a270ceaf3ae6442826e582d97487c52d
-->
## CI report:
* 0e53d682360fe30462917c820c9aa866caa957b5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144062568) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270)
* c5927b76a270ceaf3ae6442826e582d97487c52d Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144863310) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4415)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] aljoscha commented on a change in pull request #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#discussion_r374727906
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/security/factories/SecurityFactory.java
##########
@@ -0,0 +1,25 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.security.factories;
+
+/**
+ * Base class for all security related security factory instantiable.
+ */
+public interface SecurityFactory {
Review comment:
Why do we need a base class here? If it's only for the loader code, we can add a generic parameter to that method. I don't see any code that is actually polymorphic, where we would pass in either a `SecurityContextFactory` or `SecurityModuleFactory`, i.e. where we would need a common base class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] aljoscha commented on a change in pull request #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#discussion_r374737069
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/entrypoint/YarnEntrypointUtils.java
##########
@@ -46,6 +49,17 @@
*/
public class YarnEntrypointUtils {
+ public static SecurityContext installSecurityContext(
Review comment:
This seems to not be used anywhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] aljoscha commented on issue #10836: [FLINK-11589][Security]
Support security module and context discovery via ServiceLoader
Posted by GitBox <gi...@apache.org>.
aljoscha commented on issue #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#issuecomment-575129888
Hi Rong, before I review, could you please put the renaming/moving into a separate commit, so that it's easier to review the actual changes? Feel free to force push to this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] walterddr edited a comment on issue #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
walterddr edited a comment on issue #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#issuecomment-575229402
yes @aljoscha. Just to clarify, do you mean the renaming of the `SecurityUtils` to `SecurityEnvironment` part or does it also apply to the refactoring of the security `*Module` `*Factory` and `*Context`? I think the second part should go together with this PR.
Anyway I created 3 commits under: https://github.com/apache/flink/compare/master...walterddr:FLINK-11589-final. I will force push the first part once Travis show green.
Thanks
--
Rong
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#issuecomment-573438212
<!--
Meta data
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144062568 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:c5927b76a270ceaf3ae6442826e582d97487c52d Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4415 TriggerType:PUSH TriggerID:c5927b76a270ceaf3ae6442826e582d97487c52d
Hash:c5927b76a270ceaf3ae6442826e582d97487c52d Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144863310 TriggerType:PUSH TriggerID:c5927b76a270ceaf3ae6442826e582d97487c52d
Hash:4abd8a69ee904427937fb2a1df0c2c70743e7f86 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144966253 TriggerType:PUSH TriggerID:4abd8a69ee904427937fb2a1df0c2c70743e7f86
Hash:4abd8a69ee904427937fb2a1df0c2c70743e7f86 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4445 TriggerType:PUSH TriggerID:4abd8a69ee904427937fb2a1df0c2c70743e7f86
Hash:b7fc04de87f5a4ce4330eed335441cd0f05c4b80 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148241552 TriggerType:PUSH TriggerID:b7fc04de87f5a4ce4330eed335441cd0f05c4b80
Hash:b7fc04de87f5a4ce4330eed335441cd0f05c4b80 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5019 TriggerType:PUSH TriggerID:b7fc04de87f5a4ce4330eed335441cd0f05c4b80
-->
## CI report:
* 0e53d682360fe30462917c820c9aa866caa957b5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144062568) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270)
* c5927b76a270ceaf3ae6442826e582d97487c52d Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144863310) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4415)
* 4abd8a69ee904427937fb2a1df0c2c70743e7f86 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144966253) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4445)
* b7fc04de87f5a4ce4330eed335441cd0f05c4b80 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/148241552) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5019)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] walterddr commented on issue #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
walterddr commented on issue #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#issuecomment-575679631
I see, I put both changes in the PR but kept the factory refactoring part as a separate one. `SecurityUtils` renaming has been stripped from this PR.
I also renamed the base commit msg. Thanks for the clarification. and great catch @aljoscha
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#issuecomment-573438212
<!--
Meta data
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144062568 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:c5927b76a270ceaf3ae6442826e582d97487c52d Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4415 TriggerType:PUSH TriggerID:c5927b76a270ceaf3ae6442826e582d97487c52d
Hash:c5927b76a270ceaf3ae6442826e582d97487c52d Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144863310 TriggerType:PUSH TriggerID:c5927b76a270ceaf3ae6442826e582d97487c52d
Hash:4abd8a69ee904427937fb2a1df0c2c70743e7f86 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144966253 TriggerType:PUSH TriggerID:4abd8a69ee904427937fb2a1df0c2c70743e7f86
Hash:4abd8a69ee904427937fb2a1df0c2c70743e7f86 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4445 TriggerType:PUSH TriggerID:4abd8a69ee904427937fb2a1df0c2c70743e7f86
Hash:b7fc04de87f5a4ce4330eed335441cd0f05c4b80 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148241552 TriggerType:PUSH TriggerID:b7fc04de87f5a4ce4330eed335441cd0f05c4b80
Hash:b7fc04de87f5a4ce4330eed335441cd0f05c4b80 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5019 TriggerType:PUSH TriggerID:b7fc04de87f5a4ce4330eed335441cd0f05c4b80
Hash:e9b600c4247ed0e732ffdb22da29a4420968fe30 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149315280 TriggerType:PUSH TriggerID:e9b600c4247ed0e732ffdb22da29a4420968fe30
Hash:e9b600c4247ed0e732ffdb22da29a4420968fe30 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5257 TriggerType:PUSH TriggerID:e9b600c4247ed0e732ffdb22da29a4420968fe30
Hash:d89ec0b2ac3a2f1547369443af8262a2fa6b8173 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5303 TriggerType:PUSH TriggerID:d89ec0b2ac3a2f1547369443af8262a2fa6b8173
Hash:d89ec0b2ac3a2f1547369443af8262a2fa6b8173 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/149602081 TriggerType:PUSH TriggerID:d89ec0b2ac3a2f1547369443af8262a2fa6b8173
-->
## CI report:
* 0e53d682360fe30462917c820c9aa866caa957b5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144062568) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270)
* c5927b76a270ceaf3ae6442826e582d97487c52d Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144863310) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4415)
* 4abd8a69ee904427937fb2a1df0c2c70743e7f86 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144966253) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4445)
* b7fc04de87f5a4ce4330eed335441cd0f05c4b80 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/148241552) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5019)
* e9b600c4247ed0e732ffdb22da29a4420968fe30 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149315280) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5257)
* d89ec0b2ac3a2f1547369443af8262a2fa6b8173 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149602081) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5303)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] walterddr commented on a change in pull request #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
walterddr commented on a change in pull request #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#discussion_r381363305
##########
File path: docs/_includes/generated/security_configuration.html
##########
@@ -32,6 +38,12 @@
<td>Boolean</td>
<td>Indicates whether to read from your Kerberos ticket cache.</td>
</tr>
+ <tr>
+ <td><h5>security.module.factory.classes</h5></td>
+ <td style="word-wrap: break-word;">"org.apache.flink.runtime.security.modules.HadoopModuleFactory";<wbr>"org.apache.flink.runtime.security.modules.JaasModuleFactory";<wbr>"org.apache.flink.runtime.security.modules.ZookeeperModuleFactory"</td>
+ <td>List<String></td>
+ <td>List of factories that should be used to instantiate security modules. All listed modules will be installed. Keep in mind that the configured security context might rely on some modules being present.</td>
Review comment:
`configured security context might rely on some modules being present.`
does this means we should throw an exception after all modules are installed? or should we return false when `isCompatibleWith` is called?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#issuecomment-573438212
<!--
Meta data
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144062568 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:c5927b76a270ceaf3ae6442826e582d97487c52d Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4415 TriggerType:PUSH TriggerID:c5927b76a270ceaf3ae6442826e582d97487c52d
Hash:c5927b76a270ceaf3ae6442826e582d97487c52d Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144863310 TriggerType:PUSH TriggerID:c5927b76a270ceaf3ae6442826e582d97487c52d
Hash:4abd8a69ee904427937fb2a1df0c2c70743e7f86 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144966253 TriggerType:PUSH TriggerID:4abd8a69ee904427937fb2a1df0c2c70743e7f86
Hash:4abd8a69ee904427937fb2a1df0c2c70743e7f86 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4445 TriggerType:PUSH TriggerID:4abd8a69ee904427937fb2a1df0c2c70743e7f86
Hash:b7fc04de87f5a4ce4330eed335441cd0f05c4b80 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/148241552 TriggerType:PUSH TriggerID:b7fc04de87f5a4ce4330eed335441cd0f05c4b80
Hash:b7fc04de87f5a4ce4330eed335441cd0f05c4b80 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5019 TriggerType:PUSH TriggerID:b7fc04de87f5a4ce4330eed335441cd0f05c4b80
-->
## CI report:
* 0e53d682360fe30462917c820c9aa866caa957b5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144062568) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270)
* c5927b76a270ceaf3ae6442826e582d97487c52d Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144863310) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4415)
* 4abd8a69ee904427937fb2a1df0c2c70743e7f86 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144966253) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4445)
* b7fc04de87f5a4ce4330eed335441cd0f05c4b80 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/148241552) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5019)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#issuecomment-573438212
<!--
Meta data
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144062568 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:c5927b76a270ceaf3ae6442826e582d97487c52d Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4415 TriggerType:PUSH TriggerID:c5927b76a270ceaf3ae6442826e582d97487c52d
Hash:c5927b76a270ceaf3ae6442826e582d97487c52d Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144863310 TriggerType:PUSH TriggerID:c5927b76a270ceaf3ae6442826e582d97487c52d
Hash:4abd8a69ee904427937fb2a1df0c2c70743e7f86 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144966253 TriggerType:PUSH TriggerID:4abd8a69ee904427937fb2a1df0c2c70743e7f86
Hash:4abd8a69ee904427937fb2a1df0c2c70743e7f86 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4445 TriggerType:PUSH TriggerID:4abd8a69ee904427937fb2a1df0c2c70743e7f86
Hash:b7fc04de87f5a4ce4330eed335441cd0f05c4b80 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148241552 TriggerType:PUSH TriggerID:b7fc04de87f5a4ce4330eed335441cd0f05c4b80
Hash:b7fc04de87f5a4ce4330eed335441cd0f05c4b80 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5019 TriggerType:PUSH TriggerID:b7fc04de87f5a4ce4330eed335441cd0f05c4b80
-->
## CI report:
* 0e53d682360fe30462917c820c9aa866caa957b5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144062568) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270)
* c5927b76a270ceaf3ae6442826e582d97487c52d Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144863310) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4415)
* 4abd8a69ee904427937fb2a1df0c2c70743e7f86 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144966253) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4445)
* b7fc04de87f5a4ce4330eed335441cd0f05c4b80 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/148241552) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5019)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#issuecomment-573438212
<!--
Meta data
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144062568 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:c5927b76a270ceaf3ae6442826e582d97487c52d Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4415 TriggerType:PUSH TriggerID:c5927b76a270ceaf3ae6442826e582d97487c52d
Hash:c5927b76a270ceaf3ae6442826e582d97487c52d Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144863310 TriggerType:PUSH TriggerID:c5927b76a270ceaf3ae6442826e582d97487c52d
Hash:4abd8a69ee904427937fb2a1df0c2c70743e7f86 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:4abd8a69ee904427937fb2a1df0c2c70743e7f86
-->
## CI report:
* 0e53d682360fe30462917c820c9aa866caa957b5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144062568) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270)
* c5927b76a270ceaf3ae6442826e582d97487c52d Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144863310) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4415)
* 4abd8a69ee904427937fb2a1df0c2c70743e7f86 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] walterddr commented on a change in pull request #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
walterddr commented on a change in pull request #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#discussion_r375386292
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/security/SecurityConfiguration.java
##########
@@ -77,7 +87,8 @@ public SecurityConfiguration(Configuration flinkConf) {
* @param securityModuleFactories the security modules to apply.
*/
public SecurityConfiguration(Configuration flinkConf,
Review comment:
@aljoscha I am not sure whether this answers your question: the default security factories (module and context) is used when user doesn't explicitly set them. If users want to use their own - they will have to use this API to explicitly set the context and all module factories
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#issuecomment-573438212
<!--
Meta data
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144062568 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:c5927b76a270ceaf3ae6442826e582d97487c52d Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4415 TriggerType:PUSH TriggerID:c5927b76a270ceaf3ae6442826e582d97487c52d
Hash:c5927b76a270ceaf3ae6442826e582d97487c52d Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144863310 TriggerType:PUSH TriggerID:c5927b76a270ceaf3ae6442826e582d97487c52d
Hash:4abd8a69ee904427937fb2a1df0c2c70743e7f86 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144966253 TriggerType:PUSH TriggerID:4abd8a69ee904427937fb2a1df0c2c70743e7f86
Hash:4abd8a69ee904427937fb2a1df0c2c70743e7f86 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4445 TriggerType:PUSH TriggerID:4abd8a69ee904427937fb2a1df0c2c70743e7f86
Hash:b7fc04de87f5a4ce4330eed335441cd0f05c4b80 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148241552 TriggerType:PUSH TriggerID:b7fc04de87f5a4ce4330eed335441cd0f05c4b80
Hash:b7fc04de87f5a4ce4330eed335441cd0f05c4b80 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5019 TriggerType:PUSH TriggerID:b7fc04de87f5a4ce4330eed335441cd0f05c4b80
Hash:e9b600c4247ed0e732ffdb22da29a4420968fe30 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149315280 TriggerType:PUSH TriggerID:e9b600c4247ed0e732ffdb22da29a4420968fe30
Hash:e9b600c4247ed0e732ffdb22da29a4420968fe30 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5257 TriggerType:PUSH TriggerID:e9b600c4247ed0e732ffdb22da29a4420968fe30
Hash:d89ec0b2ac3a2f1547369443af8262a2fa6b8173 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5303 TriggerType:PUSH TriggerID:d89ec0b2ac3a2f1547369443af8262a2fa6b8173
Hash:d89ec0b2ac3a2f1547369443af8262a2fa6b8173 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/149602081 TriggerType:PUSH TriggerID:d89ec0b2ac3a2f1547369443af8262a2fa6b8173
Hash:1ae00a0129b97a081ac2c4d392434bc5cd4d3357 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5314 TriggerType:PUSH TriggerID:1ae00a0129b97a081ac2c4d392434bc5cd4d3357
Hash:1ae00a0129b97a081ac2c4d392434bc5cd4d3357 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/149623142 TriggerType:PUSH TriggerID:1ae00a0129b97a081ac2c4d392434bc5cd4d3357
Hash:d692bd963ddcd14f75be19cce29033234ae6259f Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5329 TriggerType:PUSH TriggerID:d692bd963ddcd14f75be19cce29033234ae6259f
Hash:d692bd963ddcd14f75be19cce29033234ae6259f Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/149674994 TriggerType:PUSH TriggerID:d692bd963ddcd14f75be19cce29033234ae6259f
Hash:62e65bc4a716669146d2d48a5f414afe4beb9498 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5354 TriggerType:PUSH TriggerID:62e65bc4a716669146d2d48a5f414afe4beb9498
Hash:62e65bc4a716669146d2d48a5f414afe4beb9498 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149795575 TriggerType:PUSH TriggerID:62e65bc4a716669146d2d48a5f414afe4beb9498
-->
## CI report:
* 0e53d682360fe30462917c820c9aa866caa957b5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144062568) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270)
* c5927b76a270ceaf3ae6442826e582d97487c52d Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144863310) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4415)
* 4abd8a69ee904427937fb2a1df0c2c70743e7f86 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144966253) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4445)
* b7fc04de87f5a4ce4330eed335441cd0f05c4b80 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/148241552) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5019)
* e9b600c4247ed0e732ffdb22da29a4420968fe30 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149315280) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5257)
* d89ec0b2ac3a2f1547369443af8262a2fa6b8173 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149602081) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5303)
* 1ae00a0129b97a081ac2c4d392434bc5cd4d3357 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149623142) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5314)
* d692bd963ddcd14f75be19cce29033234ae6259f Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149674994) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5329)
* 62e65bc4a716669146d2d48a5f414afe4beb9498 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149795575) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5354)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10836: [FLINK-11589][Security]
Support security module and context discovery via ServiceLoader
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#issuecomment-573438212
<!--
Meta data
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
-->
## CI report:
* 0e53d682360fe30462917c820c9aa866caa957b5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] aljoscha commented on issue #10836: [FLINK-11589][Security]
Support security module and context discovery via ServiceLoader
Posted by GitBox <gi...@apache.org>.
aljoscha commented on issue #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#issuecomment-581968373
One thing I noticed is that the list of factories is still hard coded in `SecurityConfiguration`. If users want to implement their own factories, how would they be picked up?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] walterddr commented on a change in pull request #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
walterddr commented on a change in pull request #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#discussion_r375375100
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/entrypoint/YarnEntrypointUtils.java
##########
@@ -46,6 +49,17 @@
*/
public class YarnEntrypointUtils {
+ public static SecurityContext installSecurityContext(
Review comment:
yes. this was suppose to be part of the rename PR. I will remove this from current PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#issuecomment-573438212
<!--
Meta data
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144062568 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:c5927b76a270ceaf3ae6442826e582d97487c52d Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4415 TriggerType:PUSH TriggerID:c5927b76a270ceaf3ae6442826e582d97487c52d
Hash:c5927b76a270ceaf3ae6442826e582d97487c52d Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144863310 TriggerType:PUSH TriggerID:c5927b76a270ceaf3ae6442826e582d97487c52d
Hash:4abd8a69ee904427937fb2a1df0c2c70743e7f86 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144966253 TriggerType:PUSH TriggerID:4abd8a69ee904427937fb2a1df0c2c70743e7f86
Hash:4abd8a69ee904427937fb2a1df0c2c70743e7f86 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4445 TriggerType:PUSH TriggerID:4abd8a69ee904427937fb2a1df0c2c70743e7f86
-->
## CI report:
* 0e53d682360fe30462917c820c9aa866caa957b5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144062568) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270)
* c5927b76a270ceaf3ae6442826e582d97487c52d Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144863310) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4415)
* 4abd8a69ee904427937fb2a1df0c2c70743e7f86 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144966253) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4445)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] aljoscha commented on a change in pull request #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#discussion_r374726865
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/security/factories/SecurityFactoryService.java
##########
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.security.factories;
+
+import org.apache.flink.util.Preconditions;
+
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.List;
+import java.util.ServiceLoader;
+
+/**
+ * The Service provider discovery for searching suitable {@link SecurityFactory}
+ * based on provided requirements.
+ */
+public class SecurityFactoryService {
Review comment:
Should be called `SecurityFactoryServiceLoader` or just `SecurityFactoryLoader`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#issuecomment-573438212
<!--
Meta data
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144062568 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
-->
## CI report:
* 0e53d682360fe30462917c820c9aa866caa957b5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144062568) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] aljoscha commented on a change in pull request #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#discussion_r375812980
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/security/SecurityConfiguration.java
##########
@@ -42,10 +44,18 @@
*/
public class SecurityConfiguration {
- private static final List<SecurityModuleFactory> DEFAULT_MODULES = Collections.unmodifiableList(
- Arrays.asList(new HadoopModuleFactory(), new JaasModuleFactory(), new ZookeeperModuleFactory()));
+ private static final String DEFAULT_CONTEXT_FACTORY = DefaultSecurityContextFactory.class.getCanonicalName();
- private final List<SecurityModuleFactory> securityModuleFactories;
+ private static final List<String> DEFAULT_MODULE_FACTORIES = Collections.unmodifiableList(Arrays.asList(
+ HadoopModuleFactory.class.getCanonicalName(),
+ JaasModuleFactory.class.getCanonicalName(),
+ ZookeeperModuleFactory.class.getCanonicalName()));
+
+ private final String securityContextFactory;
+
+ private final List<String> securityModuleFactories;
+
+ private final Map<String, Object> properties;
Review comment:
if that works, without changing the production code for the test, then yes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#issuecomment-573438212
<!--
Meta data
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144062568 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:c5927b76a270ceaf3ae6442826e582d97487c52d Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4415 TriggerType:PUSH TriggerID:c5927b76a270ceaf3ae6442826e582d97487c52d
Hash:c5927b76a270ceaf3ae6442826e582d97487c52d Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144863310 TriggerType:PUSH TriggerID:c5927b76a270ceaf3ae6442826e582d97487c52d
-->
## CI report:
* 0e53d682360fe30462917c820c9aa866caa957b5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144062568) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270)
* c5927b76a270ceaf3ae6442826e582d97487c52d Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144863310) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4415)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#issuecomment-573438212
<!--
Meta data
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144062568 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:c5927b76a270ceaf3ae6442826e582d97487c52d Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4415 TriggerType:PUSH TriggerID:c5927b76a270ceaf3ae6442826e582d97487c52d
Hash:c5927b76a270ceaf3ae6442826e582d97487c52d Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144863310 TriggerType:PUSH TriggerID:c5927b76a270ceaf3ae6442826e582d97487c52d
Hash:4abd8a69ee904427937fb2a1df0c2c70743e7f86 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144966253 TriggerType:PUSH TriggerID:4abd8a69ee904427937fb2a1df0c2c70743e7f86
Hash:4abd8a69ee904427937fb2a1df0c2c70743e7f86 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4445 TriggerType:PUSH TriggerID:4abd8a69ee904427937fb2a1df0c2c70743e7f86
Hash:b7fc04de87f5a4ce4330eed335441cd0f05c4b80 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148241552 TriggerType:PUSH TriggerID:b7fc04de87f5a4ce4330eed335441cd0f05c4b80
Hash:b7fc04de87f5a4ce4330eed335441cd0f05c4b80 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5019 TriggerType:PUSH TriggerID:b7fc04de87f5a4ce4330eed335441cd0f05c4b80
Hash:e9b600c4247ed0e732ffdb22da29a4420968fe30 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149315280 TriggerType:PUSH TriggerID:e9b600c4247ed0e732ffdb22da29a4420968fe30
Hash:e9b600c4247ed0e732ffdb22da29a4420968fe30 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5257 TriggerType:PUSH TriggerID:e9b600c4247ed0e732ffdb22da29a4420968fe30
Hash:d89ec0b2ac3a2f1547369443af8262a2fa6b8173 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5303 TriggerType:PUSH TriggerID:d89ec0b2ac3a2f1547369443af8262a2fa6b8173
Hash:d89ec0b2ac3a2f1547369443af8262a2fa6b8173 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/149602081 TriggerType:PUSH TriggerID:d89ec0b2ac3a2f1547369443af8262a2fa6b8173
Hash:1ae00a0129b97a081ac2c4d392434bc5cd4d3357 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5314 TriggerType:PUSH TriggerID:1ae00a0129b97a081ac2c4d392434bc5cd4d3357
Hash:1ae00a0129b97a081ac2c4d392434bc5cd4d3357 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/149623142 TriggerType:PUSH TriggerID:1ae00a0129b97a081ac2c4d392434bc5cd4d3357
Hash:d692bd963ddcd14f75be19cce29033234ae6259f Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:d692bd963ddcd14f75be19cce29033234ae6259f
-->
## CI report:
* 0e53d682360fe30462917c820c9aa866caa957b5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144062568) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270)
* c5927b76a270ceaf3ae6442826e582d97487c52d Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144863310) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4415)
* 4abd8a69ee904427937fb2a1df0c2c70743e7f86 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144966253) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4445)
* b7fc04de87f5a4ce4330eed335441cd0f05c4b80 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/148241552) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5019)
* e9b600c4247ed0e732ffdb22da29a4420968fe30 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149315280) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5257)
* d89ec0b2ac3a2f1547369443af8262a2fa6b8173 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149602081) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5303)
* 1ae00a0129b97a081ac2c4d392434bc5cd4d3357 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149623142) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5314)
* d692bd963ddcd14f75be19cce29033234ae6259f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] aljoscha commented on issue #10836: [FLINK-11589][Security]
Support security module and context discovery via ServiceLoader
Posted by GitBox <gi...@apache.org>.
aljoscha commented on issue #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#issuecomment-575538554
And can you please title the commits according to the standard, i.e `[FLINK-XXXXX] <title>`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] walterddr edited a comment on issue #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
walterddr edited a comment on issue #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#issuecomment-575229402
yes @aljoscha. Just to clarify, do you mean the renaming of the `SecurityUtils` to `SecurityEnvironment` part or does it also apply to the refactoring of the security `*Module` `*Factory` and `*Context`? I think the second part should go together with this PR.
Anyway I created 3 commits under: https://github.com/apache/flink/compare/master...walterddr:FLINK-11589-final. I will force push the first part once Travis show green.
Thanks --Rong
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#issuecomment-573438212
<!--
Meta data
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144062568 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:c5927b76a270ceaf3ae6442826e582d97487c52d Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4415 TriggerType:PUSH TriggerID:c5927b76a270ceaf3ae6442826e582d97487c52d
Hash:c5927b76a270ceaf3ae6442826e582d97487c52d Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144863310 TriggerType:PUSH TriggerID:c5927b76a270ceaf3ae6442826e582d97487c52d
-->
## CI report:
* 0e53d682360fe30462917c820c9aa866caa957b5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144062568) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270)
* c5927b76a270ceaf3ae6442826e582d97487c52d Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144863310) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4415)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] walterddr commented on issue #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
walterddr commented on issue #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#issuecomment-579829849
@aljoscha sorry for the ping. did you happen to get a chance taking a look at the PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#issuecomment-573438212
<!--
Meta data
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144062568 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:c5927b76a270ceaf3ae6442826e582d97487c52d Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:c5927b76a270ceaf3ae6442826e582d97487c52d
-->
## CI report:
* 0e53d682360fe30462917c820c9aa866caa957b5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144062568) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270)
* c5927b76a270ceaf3ae6442826e582d97487c52d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] walterddr commented on a change in pull request #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
walterddr commented on a change in pull request #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#discussion_r375374433
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/security/SecurityConfiguration.java
##########
@@ -42,10 +44,18 @@
*/
public class SecurityConfiguration {
- private static final List<SecurityModuleFactory> DEFAULT_MODULES = Collections.unmodifiableList(
- Arrays.asList(new HadoopModuleFactory(), new JaasModuleFactory(), new ZookeeperModuleFactory()));
+ private static final String DEFAULT_CONTEXT_FACTORY = DefaultSecurityContextFactory.class.getCanonicalName();
- private final List<SecurityModuleFactory> securityModuleFactories;
+ private static final List<String> DEFAULT_MODULE_FACTORIES = Collections.unmodifiableList(Arrays.asList(
+ HadoopModuleFactory.class.getCanonicalName(),
+ JaasModuleFactory.class.getCanonicalName(),
+ ZookeeperModuleFactory.class.getCanonicalName()));
+
+ private final String securityContextFactory;
+
+ private final List<String> securityModuleFactories;
+
+ private final Map<String, Object> properties;
Review comment:
hmm. you are absolutely right -> do you suggest I just use flinkConfig for storing/retrieving the additional properties?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10836: [FLINK-11589][Security]
Support security module and context discovery via ServiceLoader
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#issuecomment-573437027
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 0e53d682360fe30462917c820c9aa866caa957b5 (Sun Jan 12 17:19:54 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#issuecomment-573438212
<!--
Meta data
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144062568 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:c5927b76a270ceaf3ae6442826e582d97487c52d Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4415 TriggerType:PUSH TriggerID:c5927b76a270ceaf3ae6442826e582d97487c52d
Hash:c5927b76a270ceaf3ae6442826e582d97487c52d Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144863310 TriggerType:PUSH TriggerID:c5927b76a270ceaf3ae6442826e582d97487c52d
Hash:4abd8a69ee904427937fb2a1df0c2c70743e7f86 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144966253 TriggerType:PUSH TriggerID:4abd8a69ee904427937fb2a1df0c2c70743e7f86
Hash:4abd8a69ee904427937fb2a1df0c2c70743e7f86 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4445 TriggerType:PUSH TriggerID:4abd8a69ee904427937fb2a1df0c2c70743e7f86
-->
## CI report:
* 0e53d682360fe30462917c820c9aa866caa957b5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144062568) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270)
* c5927b76a270ceaf3ae6442826e582d97487c52d Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144863310) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4415)
* 4abd8a69ee904427937fb2a1df0c2c70743e7f86 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144966253) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4445)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#issuecomment-573438212
<!--
Meta data
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144062568 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:c5927b76a270ceaf3ae6442826e582d97487c52d Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4415 TriggerType:PUSH TriggerID:c5927b76a270ceaf3ae6442826e582d97487c52d
Hash:c5927b76a270ceaf3ae6442826e582d97487c52d Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144863310 TriggerType:PUSH TriggerID:c5927b76a270ceaf3ae6442826e582d97487c52d
Hash:4abd8a69ee904427937fb2a1df0c2c70743e7f86 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144966253 TriggerType:PUSH TriggerID:4abd8a69ee904427937fb2a1df0c2c70743e7f86
Hash:4abd8a69ee904427937fb2a1df0c2c70743e7f86 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4445 TriggerType:PUSH TriggerID:4abd8a69ee904427937fb2a1df0c2c70743e7f86
Hash:b7fc04de87f5a4ce4330eed335441cd0f05c4b80 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148241552 TriggerType:PUSH TriggerID:b7fc04de87f5a4ce4330eed335441cd0f05c4b80
Hash:b7fc04de87f5a4ce4330eed335441cd0f05c4b80 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5019 TriggerType:PUSH TriggerID:b7fc04de87f5a4ce4330eed335441cd0f05c4b80
Hash:e9b600c4247ed0e732ffdb22da29a4420968fe30 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149315280 TriggerType:PUSH TriggerID:e9b600c4247ed0e732ffdb22da29a4420968fe30
Hash:e9b600c4247ed0e732ffdb22da29a4420968fe30 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5257 TriggerType:PUSH TriggerID:e9b600c4247ed0e732ffdb22da29a4420968fe30
Hash:d89ec0b2ac3a2f1547369443af8262a2fa6b8173 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5303 TriggerType:PUSH TriggerID:d89ec0b2ac3a2f1547369443af8262a2fa6b8173
Hash:d89ec0b2ac3a2f1547369443af8262a2fa6b8173 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/149602081 TriggerType:PUSH TriggerID:d89ec0b2ac3a2f1547369443af8262a2fa6b8173
Hash:1ae00a0129b97a081ac2c4d392434bc5cd4d3357 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5314 TriggerType:PUSH TriggerID:1ae00a0129b97a081ac2c4d392434bc5cd4d3357
Hash:1ae00a0129b97a081ac2c4d392434bc5cd4d3357 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/149623142 TriggerType:PUSH TriggerID:1ae00a0129b97a081ac2c4d392434bc5cd4d3357
Hash:d692bd963ddcd14f75be19cce29033234ae6259f Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5329 TriggerType:PUSH TriggerID:d692bd963ddcd14f75be19cce29033234ae6259f
Hash:d692bd963ddcd14f75be19cce29033234ae6259f Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/149674994 TriggerType:PUSH TriggerID:d692bd963ddcd14f75be19cce29033234ae6259f
-->
## CI report:
* 0e53d682360fe30462917c820c9aa866caa957b5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144062568) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270)
* c5927b76a270ceaf3ae6442826e582d97487c52d Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144863310) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4415)
* 4abd8a69ee904427937fb2a1df0c2c70743e7f86 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144966253) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4445)
* b7fc04de87f5a4ce4330eed335441cd0f05c4b80 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/148241552) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5019)
* e9b600c4247ed0e732ffdb22da29a4420968fe30 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149315280) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5257)
* d89ec0b2ac3a2f1547369443af8262a2fa6b8173 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149602081) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5303)
* 1ae00a0129b97a081ac2c4d392434bc5cd4d3357 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149623142) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5314)
* d692bd963ddcd14f75be19cce29033234ae6259f Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149674994) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5329)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#issuecomment-573438212
<!--
Meta data
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144062568 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:c5927b76a270ceaf3ae6442826e582d97487c52d Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4415 TriggerType:PUSH TriggerID:c5927b76a270ceaf3ae6442826e582d97487c52d
Hash:c5927b76a270ceaf3ae6442826e582d97487c52d Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144863310 TriggerType:PUSH TriggerID:c5927b76a270ceaf3ae6442826e582d97487c52d
Hash:4abd8a69ee904427937fb2a1df0c2c70743e7f86 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144966253 TriggerType:PUSH TriggerID:4abd8a69ee904427937fb2a1df0c2c70743e7f86
Hash:4abd8a69ee904427937fb2a1df0c2c70743e7f86 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4445 TriggerType:PUSH TriggerID:4abd8a69ee904427937fb2a1df0c2c70743e7f86
Hash:b7fc04de87f5a4ce4330eed335441cd0f05c4b80 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148241552 TriggerType:PUSH TriggerID:b7fc04de87f5a4ce4330eed335441cd0f05c4b80
Hash:b7fc04de87f5a4ce4330eed335441cd0f05c4b80 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5019 TriggerType:PUSH TriggerID:b7fc04de87f5a4ce4330eed335441cd0f05c4b80
Hash:e9b600c4247ed0e732ffdb22da29a4420968fe30 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:e9b600c4247ed0e732ffdb22da29a4420968fe30
-->
## CI report:
* 0e53d682360fe30462917c820c9aa866caa957b5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144062568) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270)
* c5927b76a270ceaf3ae6442826e582d97487c52d Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144863310) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4415)
* 4abd8a69ee904427937fb2a1df0c2c70743e7f86 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144966253) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4445)
* b7fc04de87f5a4ce4330eed335441cd0f05c4b80 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/148241552) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5019)
* e9b600c4247ed0e732ffdb22da29a4420968fe30 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] walterddr commented on a change in pull request #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
walterddr commented on a change in pull request #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#discussion_r381363305
##########
File path: docs/_includes/generated/security_configuration.html
##########
@@ -32,6 +38,12 @@
<td>Boolean</td>
<td>Indicates whether to read from your Kerberos ticket cache.</td>
</tr>
+ <tr>
+ <td><h5>security.module.factory.classes</h5></td>
+ <td style="word-wrap: break-word;">"org.apache.flink.runtime.security.modules.HadoopModuleFactory";<wbr>"org.apache.flink.runtime.security.modules.JaasModuleFactory";<wbr>"org.apache.flink.runtime.security.modules.ZookeeperModuleFactory"</td>
+ <td>List<String></td>
+ <td>List of factories that should be used to instantiate security modules. All listed modules will be installed. Keep in mind that the configured security context might rely on some modules being present.</td>
Review comment:
`configured security context might rely on some modules being present.`
does this means we should throw an exception when installing module? or should we return false when `isCompatibleWith` is called?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#issuecomment-573438212
<!--
Meta data
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144062568 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:c5927b76a270ceaf3ae6442826e582d97487c52d Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4415 TriggerType:PUSH TriggerID:c5927b76a270ceaf3ae6442826e582d97487c52d
Hash:c5927b76a270ceaf3ae6442826e582d97487c52d Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144863310 TriggerType:PUSH TriggerID:c5927b76a270ceaf3ae6442826e582d97487c52d
Hash:4abd8a69ee904427937fb2a1df0c2c70743e7f86 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144966253 TriggerType:PUSH TriggerID:4abd8a69ee904427937fb2a1df0c2c70743e7f86
Hash:4abd8a69ee904427937fb2a1df0c2c70743e7f86 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4445 TriggerType:PUSH TriggerID:4abd8a69ee904427937fb2a1df0c2c70743e7f86
Hash:b7fc04de87f5a4ce4330eed335441cd0f05c4b80 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148241552 TriggerType:PUSH TriggerID:b7fc04de87f5a4ce4330eed335441cd0f05c4b80
Hash:b7fc04de87f5a4ce4330eed335441cd0f05c4b80 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5019 TriggerType:PUSH TriggerID:b7fc04de87f5a4ce4330eed335441cd0f05c4b80
Hash:e9b600c4247ed0e732ffdb22da29a4420968fe30 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149315280 TriggerType:PUSH TriggerID:e9b600c4247ed0e732ffdb22da29a4420968fe30
Hash:e9b600c4247ed0e732ffdb22da29a4420968fe30 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5257 TriggerType:PUSH TriggerID:e9b600c4247ed0e732ffdb22da29a4420968fe30
Hash:d89ec0b2ac3a2f1547369443af8262a2fa6b8173 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:d89ec0b2ac3a2f1547369443af8262a2fa6b8173
-->
## CI report:
* 0e53d682360fe30462917c820c9aa866caa957b5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144062568) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270)
* c5927b76a270ceaf3ae6442826e582d97487c52d Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144863310) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4415)
* 4abd8a69ee904427937fb2a1df0c2c70743e7f86 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144966253) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4445)
* b7fc04de87f5a4ce4330eed335441cd0f05c4b80 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/148241552) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5019)
* e9b600c4247ed0e732ffdb22da29a4420968fe30 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149315280) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5257)
* d89ec0b2ac3a2f1547369443af8262a2fa6b8173 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#issuecomment-573438212
<!--
Meta data
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144062568 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:c5927b76a270ceaf3ae6442826e582d97487c52d Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4415 TriggerType:PUSH TriggerID:c5927b76a270ceaf3ae6442826e582d97487c52d
Hash:c5927b76a270ceaf3ae6442826e582d97487c52d Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144863310 TriggerType:PUSH TriggerID:c5927b76a270ceaf3ae6442826e582d97487c52d
Hash:4abd8a69ee904427937fb2a1df0c2c70743e7f86 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144966253 TriggerType:PUSH TriggerID:4abd8a69ee904427937fb2a1df0c2c70743e7f86
Hash:4abd8a69ee904427937fb2a1df0c2c70743e7f86 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4445 TriggerType:PUSH TriggerID:4abd8a69ee904427937fb2a1df0c2c70743e7f86
Hash:b7fc04de87f5a4ce4330eed335441cd0f05c4b80 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148241552 TriggerType:PUSH TriggerID:b7fc04de87f5a4ce4330eed335441cd0f05c4b80
Hash:b7fc04de87f5a4ce4330eed335441cd0f05c4b80 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5019 TriggerType:PUSH TriggerID:b7fc04de87f5a4ce4330eed335441cd0f05c4b80
Hash:e9b600c4247ed0e732ffdb22da29a4420968fe30 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149315280 TriggerType:PUSH TriggerID:e9b600c4247ed0e732ffdb22da29a4420968fe30
Hash:e9b600c4247ed0e732ffdb22da29a4420968fe30 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5257 TriggerType:PUSH TriggerID:e9b600c4247ed0e732ffdb22da29a4420968fe30
Hash:d89ec0b2ac3a2f1547369443af8262a2fa6b8173 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5303 TriggerType:PUSH TriggerID:d89ec0b2ac3a2f1547369443af8262a2fa6b8173
Hash:d89ec0b2ac3a2f1547369443af8262a2fa6b8173 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/149602081 TriggerType:PUSH TriggerID:d89ec0b2ac3a2f1547369443af8262a2fa6b8173
Hash:1ae00a0129b97a081ac2c4d392434bc5cd4d3357 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5314 TriggerType:PUSH TriggerID:1ae00a0129b97a081ac2c4d392434bc5cd4d3357
Hash:1ae00a0129b97a081ac2c4d392434bc5cd4d3357 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/149623142 TriggerType:PUSH TriggerID:1ae00a0129b97a081ac2c4d392434bc5cd4d3357
Hash:d692bd963ddcd14f75be19cce29033234ae6259f Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5329 TriggerType:PUSH TriggerID:d692bd963ddcd14f75be19cce29033234ae6259f
Hash:d692bd963ddcd14f75be19cce29033234ae6259f Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/149674994 TriggerType:PUSH TriggerID:d692bd963ddcd14f75be19cce29033234ae6259f
Hash:62e65bc4a716669146d2d48a5f414afe4beb9498 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5354 TriggerType:PUSH TriggerID:62e65bc4a716669146d2d48a5f414afe4beb9498
Hash:62e65bc4a716669146d2d48a5f414afe4beb9498 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/149795575 TriggerType:PUSH TriggerID:62e65bc4a716669146d2d48a5f414afe4beb9498
-->
## CI report:
* 0e53d682360fe30462917c820c9aa866caa957b5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144062568) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270)
* c5927b76a270ceaf3ae6442826e582d97487c52d Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144863310) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4415)
* 4abd8a69ee904427937fb2a1df0c2c70743e7f86 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144966253) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4445)
* b7fc04de87f5a4ce4330eed335441cd0f05c4b80 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/148241552) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5019)
* e9b600c4247ed0e732ffdb22da29a4420968fe30 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149315280) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5257)
* d89ec0b2ac3a2f1547369443af8262a2fa6b8173 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149602081) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5303)
* 1ae00a0129b97a081ac2c4d392434bc5cd4d3357 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149623142) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5314)
* d692bd963ddcd14f75be19cce29033234ae6259f Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149674994) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5329)
* 62e65bc4a716669146d2d48a5f414afe4beb9498 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/149795575) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5354)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] aljoscha commented on a change in pull request #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#discussion_r374729791
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/security/factories/DefaultSecurityContextFactory.java
##########
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.security.factories;
+
+import org.apache.flink.runtime.security.SecurityConfiguration;
+import org.apache.flink.runtime.security.contexts.HadoopSecurityContext;
+import org.apache.flink.runtime.security.contexts.NoOpSecurityContext;
+import org.apache.flink.runtime.security.contexts.SecurityContext;
+
+import org.apache.hadoop.security.UserGroupInformation;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+
+/**
+ * Default security context factory that instantiates {@link SecurityContext}
+ * based on installed modules, it would instantiate {@link HadoopSecurityContext} if
+ * a {@link HadoopModuleFactory} is included.
+ */
+public class DefaultSecurityContextFactory implements SecurityContextFactory {
+ private static final Logger LOG = LoggerFactory.getLogger(DefaultSecurityContextFactory.class);
+
+ @Override
+ public SecurityContext createContext(SecurityConfiguration securityConfig) {
Review comment:
It seem like this could be split up into two factories, once for Hadoop and one for no-op. Take a look at `PipelineExecutorFactory`, where the factory has a method for checking if the factory is applicable or not. We could use the same pattern here instead of making the `createContext()` method serve two purposes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] aljoscha commented on issue #10836: [FLINK-11589][Security]
Support security module and context discovery via ServiceLoader
Posted by GitBox <gi...@apache.org>.
aljoscha commented on issue #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#issuecomment-580149140
Sorry, I was a bit busy with release related stuff. I'll now prioritize this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#issuecomment-573438212
<!--
Meta data
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144062568 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:c5927b76a270ceaf3ae6442826e582d97487c52d Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4415 TriggerType:PUSH TriggerID:c5927b76a270ceaf3ae6442826e582d97487c52d
Hash:c5927b76a270ceaf3ae6442826e582d97487c52d Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144863310 TriggerType:PUSH TriggerID:c5927b76a270ceaf3ae6442826e582d97487c52d
Hash:4abd8a69ee904427937fb2a1df0c2c70743e7f86 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144966253 TriggerType:PUSH TriggerID:4abd8a69ee904427937fb2a1df0c2c70743e7f86
Hash:4abd8a69ee904427937fb2a1df0c2c70743e7f86 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4445 TriggerType:PUSH TriggerID:4abd8a69ee904427937fb2a1df0c2c70743e7f86
Hash:b7fc04de87f5a4ce4330eed335441cd0f05c4b80 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148241552 TriggerType:PUSH TriggerID:b7fc04de87f5a4ce4330eed335441cd0f05c4b80
Hash:b7fc04de87f5a4ce4330eed335441cd0f05c4b80 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5019 TriggerType:PUSH TriggerID:b7fc04de87f5a4ce4330eed335441cd0f05c4b80
Hash:e9b600c4247ed0e732ffdb22da29a4420968fe30 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149315280 TriggerType:PUSH TriggerID:e9b600c4247ed0e732ffdb22da29a4420968fe30
Hash:e9b600c4247ed0e732ffdb22da29a4420968fe30 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5257 TriggerType:PUSH TriggerID:e9b600c4247ed0e732ffdb22da29a4420968fe30
Hash:d89ec0b2ac3a2f1547369443af8262a2fa6b8173 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5303 TriggerType:PUSH TriggerID:d89ec0b2ac3a2f1547369443af8262a2fa6b8173
Hash:d89ec0b2ac3a2f1547369443af8262a2fa6b8173 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/149602081 TriggerType:PUSH TriggerID:d89ec0b2ac3a2f1547369443af8262a2fa6b8173
Hash:1ae00a0129b97a081ac2c4d392434bc5cd4d3357 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5314 TriggerType:PUSH TriggerID:1ae00a0129b97a081ac2c4d392434bc5cd4d3357
Hash:1ae00a0129b97a081ac2c4d392434bc5cd4d3357 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/149623142 TriggerType:PUSH TriggerID:1ae00a0129b97a081ac2c4d392434bc5cd4d3357
-->
## CI report:
* 0e53d682360fe30462917c820c9aa866caa957b5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144062568) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270)
* c5927b76a270ceaf3ae6442826e582d97487c52d Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144863310) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4415)
* 4abd8a69ee904427937fb2a1df0c2c70743e7f86 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144966253) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4445)
* b7fc04de87f5a4ce4330eed335441cd0f05c4b80 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/148241552) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5019)
* e9b600c4247ed0e732ffdb22da29a4420968fe30 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149315280) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5257)
* d89ec0b2ac3a2f1547369443af8262a2fa6b8173 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149602081) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5303)
* 1ae00a0129b97a081ac2c4d392434bc5cd4d3357 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149623142) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5314)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] aljoscha commented on a change in pull request #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#discussion_r374734280
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/security/SecurityUtils.java
##########
@@ -56,43 +56,42 @@ public static SecurityContext getInstalledContext() {
* <p>Applies the configuration using the available security modules (i.e. Hadoop, JAAS).
*/
public static void install(SecurityConfiguration config) throws Exception {
+ // Install the security modules first before installing the security context
+ installModules(config);
+ installContext(config);
+ }
+
+ static void installModules(SecurityConfiguration config) throws Exception {
- // install the security modules
+ // install the security module factories
List<SecurityModule> modules = new ArrayList<>();
try {
- for (SecurityModuleFactory moduleFactory : config.getSecurityModuleFactories()) {
+ for (String moduleFactoryClass : config.getSecurityModuleFactories()) {
+ SecurityModuleFactory moduleFactory = SecurityFactoryService.findModuleFactory(moduleFactoryClass);
+ if (moduleFactory == null) {
Review comment:
I think the service loader will throw an exception if it cannot find a factory, it will not return `null`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#issuecomment-573438212
<!--
Meta data
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144062568 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:c5927b76a270ceaf3ae6442826e582d97487c52d Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4415 TriggerType:PUSH TriggerID:c5927b76a270ceaf3ae6442826e582d97487c52d
Hash:c5927b76a270ceaf3ae6442826e582d97487c52d Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144863310 TriggerType:PUSH TriggerID:c5927b76a270ceaf3ae6442826e582d97487c52d
Hash:4abd8a69ee904427937fb2a1df0c2c70743e7f86 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144966253 TriggerType:PUSH TriggerID:4abd8a69ee904427937fb2a1df0c2c70743e7f86
Hash:4abd8a69ee904427937fb2a1df0c2c70743e7f86 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4445 TriggerType:PUSH TriggerID:4abd8a69ee904427937fb2a1df0c2c70743e7f86
Hash:b7fc04de87f5a4ce4330eed335441cd0f05c4b80 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148241552 TriggerType:PUSH TriggerID:b7fc04de87f5a4ce4330eed335441cd0f05c4b80
Hash:b7fc04de87f5a4ce4330eed335441cd0f05c4b80 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5019 TriggerType:PUSH TriggerID:b7fc04de87f5a4ce4330eed335441cd0f05c4b80
Hash:e9b600c4247ed0e732ffdb22da29a4420968fe30 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149315280 TriggerType:PUSH TriggerID:e9b600c4247ed0e732ffdb22da29a4420968fe30
Hash:e9b600c4247ed0e732ffdb22da29a4420968fe30 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5257 TriggerType:PUSH TriggerID:e9b600c4247ed0e732ffdb22da29a4420968fe30
Hash:d89ec0b2ac3a2f1547369443af8262a2fa6b8173 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5303 TriggerType:PUSH TriggerID:d89ec0b2ac3a2f1547369443af8262a2fa6b8173
Hash:d89ec0b2ac3a2f1547369443af8262a2fa6b8173 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/149602081 TriggerType:PUSH TriggerID:d89ec0b2ac3a2f1547369443af8262a2fa6b8173
Hash:1ae00a0129b97a081ac2c4d392434bc5cd4d3357 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5314 TriggerType:PUSH TriggerID:1ae00a0129b97a081ac2c4d392434bc5cd4d3357
Hash:1ae00a0129b97a081ac2c4d392434bc5cd4d3357 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/149623142 TriggerType:PUSH TriggerID:1ae00a0129b97a081ac2c4d392434bc5cd4d3357
Hash:d692bd963ddcd14f75be19cce29033234ae6259f Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5329 TriggerType:PUSH TriggerID:d692bd963ddcd14f75be19cce29033234ae6259f
Hash:d692bd963ddcd14f75be19cce29033234ae6259f Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/149674994 TriggerType:PUSH TriggerID:d692bd963ddcd14f75be19cce29033234ae6259f
Hash:62e65bc4a716669146d2d48a5f414afe4beb9498 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:62e65bc4a716669146d2d48a5f414afe4beb9498
-->
## CI report:
* 0e53d682360fe30462917c820c9aa866caa957b5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144062568) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270)
* c5927b76a270ceaf3ae6442826e582d97487c52d Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144863310) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4415)
* 4abd8a69ee904427937fb2a1df0c2c70743e7f86 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144966253) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4445)
* b7fc04de87f5a4ce4330eed335441cd0f05c4b80 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/148241552) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5019)
* e9b600c4247ed0e732ffdb22da29a4420968fe30 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149315280) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5257)
* d89ec0b2ac3a2f1547369443af8262a2fa6b8173 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149602081) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5303)
* 1ae00a0129b97a081ac2c4d392434bc5cd4d3357 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149623142) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5314)
* d692bd963ddcd14f75be19cce29033234ae6259f Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149674994) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5329)
* 62e65bc4a716669146d2d48a5f414afe4beb9498 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#issuecomment-573438212
<!--
Meta data
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144062568 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:c5927b76a270ceaf3ae6442826e582d97487c52d Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4415 TriggerType:PUSH TriggerID:c5927b76a270ceaf3ae6442826e582d97487c52d
Hash:c5927b76a270ceaf3ae6442826e582d97487c52d Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144863310 TriggerType:PUSH TriggerID:c5927b76a270ceaf3ae6442826e582d97487c52d
Hash:4abd8a69ee904427937fb2a1df0c2c70743e7f86 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144966253 TriggerType:PUSH TriggerID:4abd8a69ee904427937fb2a1df0c2c70743e7f86
Hash:4abd8a69ee904427937fb2a1df0c2c70743e7f86 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4445 TriggerType:PUSH TriggerID:4abd8a69ee904427937fb2a1df0c2c70743e7f86
Hash:b7fc04de87f5a4ce4330eed335441cd0f05c4b80 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148241552 TriggerType:PUSH TriggerID:b7fc04de87f5a4ce4330eed335441cd0f05c4b80
Hash:b7fc04de87f5a4ce4330eed335441cd0f05c4b80 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5019 TriggerType:PUSH TriggerID:b7fc04de87f5a4ce4330eed335441cd0f05c4b80
Hash:e9b600c4247ed0e732ffdb22da29a4420968fe30 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/149315280 TriggerType:PUSH TriggerID:e9b600c4247ed0e732ffdb22da29a4420968fe30
Hash:e9b600c4247ed0e732ffdb22da29a4420968fe30 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5257 TriggerType:PUSH TriggerID:e9b600c4247ed0e732ffdb22da29a4420968fe30
-->
## CI report:
* 0e53d682360fe30462917c820c9aa866caa957b5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144062568) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270)
* c5927b76a270ceaf3ae6442826e582d97487c52d Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144863310) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4415)
* 4abd8a69ee904427937fb2a1df0c2c70743e7f86 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144966253) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4445)
* b7fc04de87f5a4ce4330eed335441cd0f05c4b80 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/148241552) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5019)
* e9b600c4247ed0e732ffdb22da29a4420968fe30 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/149315280) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5257)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] aljoscha commented on issue #10836: [FLINK-11589][Security]
Support security module and context discovery via ServiceLoader
Posted by GitBox <gi...@apache.org>.
aljoscha commented on issue #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#issuecomment-575538336
Yes, I meant the simple renaming, for example `SecurityUtils`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#issuecomment-573438212
<!--
Meta data
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144062568 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:c5927b76a270ceaf3ae6442826e582d97487c52d Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4415 TriggerType:PUSH TriggerID:c5927b76a270ceaf3ae6442826e582d97487c52d
Hash:c5927b76a270ceaf3ae6442826e582d97487c52d Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144863310 TriggerType:PUSH TriggerID:c5927b76a270ceaf3ae6442826e582d97487c52d
Hash:4abd8a69ee904427937fb2a1df0c2c70743e7f86 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144966253 TriggerType:PUSH TriggerID:4abd8a69ee904427937fb2a1df0c2c70743e7f86
Hash:4abd8a69ee904427937fb2a1df0c2c70743e7f86 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4445 TriggerType:PUSH TriggerID:4abd8a69ee904427937fb2a1df0c2c70743e7f86
-->
## CI report:
* 0e53d682360fe30462917c820c9aa866caa957b5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144062568) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270)
* c5927b76a270ceaf3ae6442826e582d97487c52d Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144863310) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4415)
* 4abd8a69ee904427937fb2a1df0c2c70743e7f86 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144966253) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4445)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] aljoscha commented on a change in pull request #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#discussion_r376284565
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/security/SecurityConfiguration.java
##########
@@ -77,7 +87,8 @@ public SecurityConfiguration(Configuration flinkConf) {
* @param securityModuleFactories the security modules to apply.
*/
public SecurityConfiguration(Configuration flinkConf,
Review comment:
How would they do that? I think this is only possible if you setup your own TaskManagerRunners and other runners, for example for YARN. Is this the intended purpose?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] aljoscha commented on issue #10836: [FLINK-11589][Security]
Support security module and context discovery via ServiceLoader
Posted by GitBox <gi...@apache.org>.
aljoscha commented on issue #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#issuecomment-589599397
Thanks a lot for your work @walterddr! I merged this. 🍵
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#issuecomment-573438212
<!--
Meta data
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144062568 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
-->
## CI report:
* 0e53d682360fe30462917c820c9aa866caa957b5 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144062568) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] aljoscha commented on issue #10836: [FLINK-11589][Security]
Support security module and context discovery via ServiceLoader
Posted by GitBox <gi...@apache.org>.
aljoscha commented on issue #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#issuecomment-588125551
@walterddr I rebased this and pushed some changes to your PR (I hope that's ok).
I removed the `factories` package and instead moved the factories to the same module as either the contexts or modules. Before, the `factories` package had factories for both modules and contexts.
I updated the documentation of the new config options, please also have a look at that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#issuecomment-573438212
<!--
Meta data
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144062568 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:c5927b76a270ceaf3ae6442826e582d97487c52d Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4415 TriggerType:PUSH TriggerID:c5927b76a270ceaf3ae6442826e582d97487c52d
Hash:c5927b76a270ceaf3ae6442826e582d97487c52d Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144863310 TriggerType:PUSH TriggerID:c5927b76a270ceaf3ae6442826e582d97487c52d
Hash:4abd8a69ee904427937fb2a1df0c2c70743e7f86 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144966253 TriggerType:PUSH TriggerID:4abd8a69ee904427937fb2a1df0c2c70743e7f86
Hash:4abd8a69ee904427937fb2a1df0c2c70743e7f86 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4445 TriggerType:PUSH TriggerID:4abd8a69ee904427937fb2a1df0c2c70743e7f86
Hash:b7fc04de87f5a4ce4330eed335441cd0f05c4b80 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:b7fc04de87f5a4ce4330eed335441cd0f05c4b80
-->
## CI report:
* 0e53d682360fe30462917c820c9aa866caa957b5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144062568) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270)
* c5927b76a270ceaf3ae6442826e582d97487c52d Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144863310) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4415)
* 4abd8a69ee904427937fb2a1df0c2c70743e7f86 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144966253) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4445)
* b7fc04de87f5a4ce4330eed335441cd0f05c4b80 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] walterddr commented on a change in pull request #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
walterddr commented on a change in pull request #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#discussion_r375375522
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/security/factories/SecurityFactoryService.java
##########
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.security.factories;
+
+import org.apache.flink.util.Preconditions;
+
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.List;
+import java.util.ServiceLoader;
+
+/**
+ * The Service provider discovery for searching suitable {@link SecurityFactory}
+ * based on provided requirements.
+ */
+public class SecurityFactoryService {
Review comment:
+1 for `SecurityFactoryServiceLoader`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] aljoscha commented on a change in pull request #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#discussion_r374728244
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/security/factories/SecurityContextFactory.java
##########
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.security.factories;
+
+import org.apache.flink.runtime.security.SecurityConfiguration;
+import org.apache.flink.runtime.security.contexts.SecurityContext;
+
+/**
Review comment:
Missing Javadoc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] aljoscha closed pull request #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
aljoscha closed pull request #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] aljoscha commented on a change in pull request #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#discussion_r374732482
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/security/SecurityConfiguration.java
##########
@@ -42,10 +44,18 @@
*/
public class SecurityConfiguration {
- private static final List<SecurityModuleFactory> DEFAULT_MODULES = Collections.unmodifiableList(
- Arrays.asList(new HadoopModuleFactory(), new JaasModuleFactory(), new ZookeeperModuleFactory()));
+ private static final String DEFAULT_CONTEXT_FACTORY = DefaultSecurityContextFactory.class.getCanonicalName();
- private final List<SecurityModuleFactory> securityModuleFactories;
+ private static final List<String> DEFAULT_MODULE_FACTORIES = Collections.unmodifiableList(Arrays.asList(
+ HadoopModuleFactory.class.getCanonicalName(),
+ JaasModuleFactory.class.getCanonicalName(),
+ ZookeeperModuleFactory.class.getCanonicalName()));
+
+ private final String securityContextFactory;
+
+ private final List<String> securityModuleFactories;
+
+ private final Map<String, Object> properties;
Review comment:
Why are the properties needed? Is it only to make the test work?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#issuecomment-573438212
<!--
Meta data
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144062568 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:c5927b76a270ceaf3ae6442826e582d97487c52d Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4415 TriggerType:PUSH TriggerID:c5927b76a270ceaf3ae6442826e582d97487c52d
Hash:c5927b76a270ceaf3ae6442826e582d97487c52d Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144863310 TriggerType:PUSH TriggerID:c5927b76a270ceaf3ae6442826e582d97487c52d
Hash:4abd8a69ee904427937fb2a1df0c2c70743e7f86 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144966253 TriggerType:PUSH TriggerID:4abd8a69ee904427937fb2a1df0c2c70743e7f86
Hash:4abd8a69ee904427937fb2a1df0c2c70743e7f86 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4445 TriggerType:PUSH TriggerID:4abd8a69ee904427937fb2a1df0c2c70743e7f86
Hash:b7fc04de87f5a4ce4330eed335441cd0f05c4b80 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148241552 TriggerType:PUSH TriggerID:b7fc04de87f5a4ce4330eed335441cd0f05c4b80
Hash:b7fc04de87f5a4ce4330eed335441cd0f05c4b80 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5019 TriggerType:PUSH TriggerID:b7fc04de87f5a4ce4330eed335441cd0f05c4b80
Hash:e9b600c4247ed0e732ffdb22da29a4420968fe30 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149315280 TriggerType:PUSH TriggerID:e9b600c4247ed0e732ffdb22da29a4420968fe30
Hash:e9b600c4247ed0e732ffdb22da29a4420968fe30 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5257 TriggerType:PUSH TriggerID:e9b600c4247ed0e732ffdb22da29a4420968fe30
Hash:d89ec0b2ac3a2f1547369443af8262a2fa6b8173 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5303 TriggerType:PUSH TriggerID:d89ec0b2ac3a2f1547369443af8262a2fa6b8173
Hash:d89ec0b2ac3a2f1547369443af8262a2fa6b8173 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/149602081 TriggerType:PUSH TriggerID:d89ec0b2ac3a2f1547369443af8262a2fa6b8173
Hash:1ae00a0129b97a081ac2c4d392434bc5cd4d3357 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:1ae00a0129b97a081ac2c4d392434bc5cd4d3357
-->
## CI report:
* 0e53d682360fe30462917c820c9aa866caa957b5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144062568) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270)
* c5927b76a270ceaf3ae6442826e582d97487c52d Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144863310) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4415)
* 4abd8a69ee904427937fb2a1df0c2c70743e7f86 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144966253) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4445)
* b7fc04de87f5a4ce4330eed335441cd0f05c4b80 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/148241552) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5019)
* e9b600c4247ed0e732ffdb22da29a4420968fe30 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149315280) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5257)
* d89ec0b2ac3a2f1547369443af8262a2fa6b8173 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149602081) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5303)
* 1ae00a0129b97a081ac2c4d392434bc5cd4d3357 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] walterddr commented on a change in pull request #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
walterddr commented on a change in pull request #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#discussion_r377181512
##########
File path: docs/_includes/generated/security_configuration.html
##########
@@ -8,6 +8,18 @@
</tr>
</thead>
<tbody>
+ <tr>
+ <td><h5>security.context.factory.class</h5></td>
Review comment:
the new configuration options are context.factory.class and module.factory.classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] walterddr commented on a change in pull request #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
walterddr commented on a change in pull request #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#discussion_r375373240
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/security/factories/SecurityFactory.java
##########
@@ -0,0 +1,25 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.security.factories;
+
+/**
+ * Base class for all security related security factory instantiable.
+ */
+public interface SecurityFactory {
Review comment:
yes. that's correct I was trying to make the loader code of `private static SecurityFactory findFactoryInternal` simpler. but yes I think it makes sense to use a generic type param.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] aljoscha commented on a change in pull request #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#discussion_r381413011
##########
File path: docs/_includes/generated/security_configuration.html
##########
@@ -32,6 +38,12 @@
<td>Boolean</td>
<td>Indicates whether to read from your Kerberos ticket cache.</td>
</tr>
+ <tr>
+ <td><h5>security.module.factory.classes</h5></td>
+ <td style="word-wrap: break-word;">"org.apache.flink.runtime.security.modules.HadoopModuleFactory";<wbr>"org.apache.flink.runtime.security.modules.JaasModuleFactory";<wbr>"org.apache.flink.runtime.security.modules.ZookeeperModuleFactory"</td>
+ <td>List<String></td>
+ <td>List of factories that should be used to instantiate security modules. All listed modules will be installed. Keep in mind that the configured security context might rely on some modules being present.</td>
Review comment:
It's referring to the fact that for example the `HadoopSecurityContext` needs the `HadoopModule` to be present.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10836:
[FLINK-11589][Security] Support security module and context discovery via
ServiceLoader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10836: [FLINK-11589][Security] Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#issuecomment-573438212
<!--
Meta data
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144062568 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:0e53d682360fe30462917c820c9aa866caa957b5 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270 TriggerType:PUSH TriggerID:0e53d682360fe30462917c820c9aa866caa957b5
Hash:c5927b76a270ceaf3ae6442826e582d97487c52d Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4415 TriggerType:PUSH TriggerID:c5927b76a270ceaf3ae6442826e582d97487c52d
Hash:c5927b76a270ceaf3ae6442826e582d97487c52d Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144863310 TriggerType:PUSH TriggerID:c5927b76a270ceaf3ae6442826e582d97487c52d
Hash:4abd8a69ee904427937fb2a1df0c2c70743e7f86 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144966253 TriggerType:PUSH TriggerID:4abd8a69ee904427937fb2a1df0c2c70743e7f86
Hash:4abd8a69ee904427937fb2a1df0c2c70743e7f86 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4445 TriggerType:PUSH TriggerID:4abd8a69ee904427937fb2a1df0c2c70743e7f86
Hash:b7fc04de87f5a4ce4330eed335441cd0f05c4b80 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148241552 TriggerType:PUSH TriggerID:b7fc04de87f5a4ce4330eed335441cd0f05c4b80
Hash:b7fc04de87f5a4ce4330eed335441cd0f05c4b80 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5019 TriggerType:PUSH TriggerID:b7fc04de87f5a4ce4330eed335441cd0f05c4b80
Hash:e9b600c4247ed0e732ffdb22da29a4420968fe30 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149315280 TriggerType:PUSH TriggerID:e9b600c4247ed0e732ffdb22da29a4420968fe30
Hash:e9b600c4247ed0e732ffdb22da29a4420968fe30 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5257 TriggerType:PUSH TriggerID:e9b600c4247ed0e732ffdb22da29a4420968fe30
-->
## CI report:
* 0e53d682360fe30462917c820c9aa866caa957b5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144062568) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4270)
* c5927b76a270ceaf3ae6442826e582d97487c52d Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144863310) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4415)
* 4abd8a69ee904427937fb2a1df0c2c70743e7f86 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144966253) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4445)
* b7fc04de87f5a4ce4330eed335441cd0f05c4b80 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/148241552) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5019)
* e9b600c4247ed0e732ffdb22da29a4420968fe30 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149315280) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5257)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services