You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by AhyoungRyu <gi...@git.apache.org> on 2017/02/19 17:42:30 UTC
[GitHub] zeppelin pull request #2037: [ZEPPELIN-2109][ZEPPELIN-2110] Sortable Helium ...
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/zeppelin/pull/2037
[ZEPPELIN-2109][ZEPPELIN-2110] Sortable Helium pkgs & Introduce "INTERPRETER" type
### What is this PR for?
* Make Helium pkgs sortable
For now, we have 3 types of Helium packages: `VISUALIZATION`, `SPELL` and `APPLICATION`.
`VISUALIZATION` and `SPELL` type of pkgs can be published [NPM registry](https://www.npmjs.com/). Likewise, `APPLICATION` type pkg can be registered in [Maven central repository](http://search.maven.org/).
But all available Helium packages are not sorted and shown in random order in Helium menu.
To do this, I put "NPM Packages" & "Maven Artifacts" button at top-right corner of Helium menu.
* Introduce "INTERPRETER" type
As a first step of [ZEPPELIN-1993: Install interpreter from Helium menu](https://issues.apache.org/jira/browse/ZEPPELIN-1993), I added `INTERPRETER` type as a new Helium pkg type. Like [ZEPPELIN-1973](https://issues.apache.org/jira/browse/ZEPPELIN-1973) did, we can retrieve Maven artifact(which has `zeppelin-interpreter` as its dependency) info and save it to Helium online registry as well.
For more detailed explanation, please see [ZEPPELIN-1993](https://issues.apache.org/jira/browse/ZEPPELIN-1993) and [ZEPPELIN-2110](https://issues.apache.org/jira/browse/ZEPPELIN-2110)'s description.
### What type of PR is it?
Improvement
### Todos
* [ ] - address feedback
### What is the Jira issue?
* [ZEPPELIN-2109](https://issues.apache.org/jira/browse/ZEPPELIN-2109) : Make Helium packages sortable in Helium menu
* [ZEPPELIN-2110](https://issues.apache.org/jira/browse/ZEPPELIN-2110) : List community & 3rd party interpreter registered at Maven central repo in Helium menu
### How should this be tested?
To see how `INTERPRETER` type can be shown in Helium menu,
1. Replace temporarily [ZeppelinConfiguration.java#L46](https://github.com/apache/zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java#L46) with [this url](https://raw.githubusercontent.com/AhyoungRyu/spark-notebook-example/master/helium-test.json)
2. Build \w below command and restart
```
$ mvn clean package -DskipTests -pl 'zeppelin-zengine, zeppelin-server, zeppelin-interpreter'
```
3. Start web dev server under `ZEPPELIN_HOME/zeppelin-web` and browse `localhost:9000`
```
$ yarn run dev:helium
```
4. Go to Helium menu
### Screenshots (if appropriate)
- How's it look?
- Package selection by types (NPM pkgs(`SPELL` or `VISUALIZATION`)? or Maven artifacts(`APPLICATION` or `INTERPRETER`)?)
<img width="300" alt="screen shot 2017-02-20 at 1 59 37 am" src="https://cloud.githubusercontent.com/assets/10060731/23104398/84721784-f710-11e6-80fa-6c7730ab88ea.png">
<img width="300" alt="screen shot 2017-02-20 at 1 59 46 am" src="https://cloud.githubusercontent.com/assets/10060731/23104401/85c02450-f710-11e6-90bb-e98dbe5af70d.png">
- Disabled "Enable" button until [ZEPPELIN-1993](https://issues.apache.org/jira/browse/ZEPPELIN-1993) is resolved
<img width="580px" alt="screen shot 2017-02-20 at 2 03 23 am" src="https://cloud.githubusercontent.com/assets/10060731/23104412/c95dccb2-f710-11e6-9602-4159c7182e64.png">
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/zeppelin ZEPPELIN-2109
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2037.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2037
----
commit 6f099661a93ca49ca6e627f56b477f84c3cf157d
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-02-19T16:46:05Z
Add img files
commit 51efa29b36935e5d19894c9c957db7e8247c2cf6
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-02-19T16:47:17Z
Add 'INTERPRETER', 'APPLICATION' as helium pkg types
commit 38c2e03517521907036f204c7d95510113296b58
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-02-19T16:51:00Z
Enable Helium pkg type sortable
commit 34ed7cd4541835903e8161998b13bc06469942b6
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-02-19T17:12:16Z
Remove console.log
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2037: [ZEPPELIN-2109][2110] Sortable Helium pkgs & In...
Posted by AhyoungRyu <gi...@git.apache.org>.
GitHub user AhyoungRyu reopened a pull request:
https://github.com/apache/zeppelin/pull/2037
[ZEPPELIN-2109][2110] Sortable Helium pkgs & Introduce "INTERPRETER" type
### What is this PR for?
* Make Helium pkgs sortable
For now, we have 3 types of Helium packages: `VISUALIZATION`, `SPELL` and `APPLICATION`.
`VISUALIZATION` and `SPELL` type of pkgs can be published [NPM registry](https://www.npmjs.com/). Likewise, `APPLICATION` type pkg can be registered in [Maven central repository](http://search.maven.org/).
But all available Helium packages are not sorted and shown in random order in Helium menu.
To do this, I put "NPM Packages" & "Maven Artifacts" button at top-right corner of Helium menu.
* Introduce "INTERPRETER" type
As a first step of [ZEPPELIN-1993: Install interpreter from Helium menu](https://issues.apache.org/jira/browse/ZEPPELIN-1993), I added `INTERPRETER` type as a new Helium pkg type. Like [ZEPPELIN-1973](https://issues.apache.org/jira/browse/ZEPPELIN-1973) did, we can retrieve Maven artifact(which has `zeppelin-interpreter` as its dependency) info and save it to Helium online registry as well.
For more detailed explanation, please see [ZEPPELIN-1993](https://issues.apache.org/jira/browse/ZEPPELIN-1993) and [ZEPPELIN-2110](https://issues.apache.org/jira/browse/ZEPPELIN-2110)'s description.
### What type of PR is it?
Improvement
### Todos
* [ ] - address feedback
### What is the Jira issue?
* [ZEPPELIN-2109](https://issues.apache.org/jira/browse/ZEPPELIN-2109) : Make Helium packages sortable in Helium menu
* [ZEPPELIN-2110](https://issues.apache.org/jira/browse/ZEPPELIN-2110) : List community & 3rd party interpreter registered at Maven central repo in Helium menu
### How should this be tested?
To see how `INTERPRETER` type can be shown in Helium menu,
1. Replace temporarily [ZeppelinConfiguration.java#L46](https://github.com/apache/zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java#L46) with [this url](https://raw.githubusercontent.com/AhyoungRyu/spark-notebook-example/master/helium-test.json)
2. Build \w below command and restart
```
$ mvn clean package -DskipTests -pl 'zeppelin-zengine, zeppelin-server, zeppelin-interpreter'
```
3. Start web dev server under `ZEPPELIN_HOME/zeppelin-web` and browse `localhost:9000`
```
$ yarn run dev:helium
```
4. Go to Helium menu
### Screenshots (if appropriate)
- How's it look?
- Package selection by types (`VISUALIZATION`, `SPELL`, `INTERPRETER` and `APPLICATION`)
<img width="500" alt="screen shot 2017-02-23 at 12 51 22 am" src="https://cloud.githubusercontent.com/assets/10060731/23219377/3c020fb4-f962-11e6-849c-6da193414d87.png">
- Disabled "Enable" button until [ZEPPELIN-1993](https://issues.apache.org/jira/browse/ZEPPELIN-1993) is resolved
<img width="580px" alt="screen shot 2017-02-20 at 2 03 23 am" src="https://cloud.githubusercontent.com/assets/10060731/23104412/c95dccb2-f710-11e6-9602-4159c7182e64.png">
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/zeppelin ZEPPELIN-2109
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2037.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2037
----
commit 6de9169988dae72b084566fef7e401949d5287a4
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-02-19T16:46:05Z
Add img files
commit f1c7bac81e15f8dd577e1e96de698567e004b1f0
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-02-19T16:47:17Z
Add 'INTERPRETER', 'APPLICATION' as helium pkg types
commit 4a6eace7a9a0356b21d93743105cbd3690a65d9e
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-02-19T16:51:00Z
Enable Helium pkg type sortable
commit b74c599178edc28c240ceb3ba9ac7f01b3d2faf1
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-02-19T17:12:16Z
Remove console.log
commit 86e1eda3ef7d1b79d2544864fd568ce22701c697
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-02-19T17:43:54Z
Remove unnecassary words
commit 6d7f4fab5be6dc4b568f238f9403872309386be0
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-02-22T15:37:39Z
Make packages sortable by type not repository
commit c68efd211bd1741c7d2efd1552d41e9164904694
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-02-22T15:45:27Z
Remove unused img files
commit 899e8fa8eba08a293821470a00c582145c64ea36
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-02-22T15:45:46Z
Put license sentences back removed by mistake
commit d5ae4e2f04a8f61cf2759c1595f776e8f8aa7fd9
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-02-23T07:36:00Z
Add default msg to show when each package size is 0
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2037: [ZEPPELIN-2109][2110] Sortable Helium pkgs & Introduce...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2037
@1ambda Thanks for the review. Sadly there some conflicts. Let me updated again :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2037: [ZEPPELIN-2109][2110] Sortable Helium pkgs & Introduce...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2037
I will review and comment soon. Great Feature!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2037: [ZEPPELIN-2109][2110] Sortable Helium pkgs & In...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu closed the pull request at:
https://github.com/apache/zeppelin/pull/2037
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2037: [ZEPPELIN-2109][2110] Sortable Helium pkgs & In...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu closed the pull request at:
https://github.com/apache/zeppelin/pull/2037
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2037: [ZEPPELIN-2109][2110] Sortable Helium pkgs & Introduce...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2037
Looks great. zeppelin-web has build error. Can you take care of it and make CI green?
```
[INFO] $ grunt pre-webpack-dist && webpack && grunt post-webpack-dist
[INFO] Running "eslint:all" (eslint) task
[INFO]
[INFO] /Users/moon/Projects/zeppelin-review/pr2037/zeppelin-web/src/app/helium/helium.controller.js
[INFO] 159:14 error Expected '===' and instead saw '==' eqeqeq
[INFO]
[INFO] \u2716 1 problem (1 error, 0 warnings)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2037: [ZEPPELIN-2109][2110] Sortable Helium pkgs & In...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2037
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2037: [ZEPPELIN-2109][2110] Sortable Helium pkgs & In...
Posted by AhyoungRyu <gi...@git.apache.org>.
GitHub user AhyoungRyu reopened a pull request:
https://github.com/apache/zeppelin/pull/2037
[ZEPPELIN-2109][2110] Sortable Helium pkgs & Introduce "INTERPRETER" type
### What is this PR for?
* Make Helium pkgs sortable
For now, we have 3 types of Helium packages: `VISUALIZATION`, `SPELL` and `APPLICATION`.
`VISUALIZATION` and `SPELL` type of pkgs can be published [NPM registry](https://www.npmjs.com/). Likewise, `APPLICATION` type pkg can be registered in [Maven central repository](http://search.maven.org/).
But all available Helium packages are not sorted and shown in random order in Helium menu.
To do this, I put "NPM Packages" & "Maven Artifacts" button at top-right corner of Helium menu.
* Introduce "INTERPRETER" type
As a first step of [ZEPPELIN-1993: Install interpreter from Helium menu](https://issues.apache.org/jira/browse/ZEPPELIN-1993), I added `INTERPRETER` type as a new Helium pkg type. Like [ZEPPELIN-1973](https://issues.apache.org/jira/browse/ZEPPELIN-1973) did, we can retrieve Maven artifact(which has `zeppelin-interpreter` as its dependency) info and save it to Helium online registry as well.
For more detailed explanation, please see [ZEPPELIN-1993](https://issues.apache.org/jira/browse/ZEPPELIN-1993) and [ZEPPELIN-2110](https://issues.apache.org/jira/browse/ZEPPELIN-2110)'s description.
### What type of PR is it?
Improvement
### What is the Jira issue?
* [ZEPPELIN-2109](https://issues.apache.org/jira/browse/ZEPPELIN-2109) : Make Helium packages sortable in Helium menu
* [ZEPPELIN-2110](https://issues.apache.org/jira/browse/ZEPPELIN-2110) : List community & 3rd party interpreter registered at Maven central repo in Helium menu
### How should this be tested?
To see how `INTERPRETER` type can be shown in Helium menu,
1. Replace temporarily [ZeppelinConfiguration.java#L46](https://github.com/apache/zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java#L46) with [this url](https://raw.githubusercontent.com/AhyoungRyu/spark-notebook-example/master/helium-test.json)
2. Build \w below command and restart
```
$ mvn clean package -DskipTests -pl 'zeppelin-zengine, zeppelin-server, zeppelin-interpreter'
```
3. Start web dev server under `ZEPPELIN_HOME/zeppelin-web` and browse `localhost:9000`
```
$ yarn run dev:helium
```
4. Go to Helium menu
### Screenshots (if appropriate)
- How's it look?
- Package selection by types (`VISUALIZATION`, `SPELL`, `INTERPRETER` and `APPLICATION`)
<img width="500" alt="screen shot 2017-02-23 at 12 51 22 am" src="https://cloud.githubusercontent.com/assets/10060731/23219377/3c020fb4-f962-11e6-849c-6da193414d87.png">
- Disabled "Enable" button until [ZEPPELIN-1993](https://issues.apache.org/jira/browse/ZEPPELIN-1993) is resolved
<img width="580px" alt="screen shot 2017-02-20 at 2 03 23 am" src="https://cloud.githubusercontent.com/assets/10060731/23104412/c95dccb2-f710-11e6-9602-4159c7182e64.png">
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/zeppelin ZEPPELIN-2109
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2037.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2037
----
commit 6de9169988dae72b084566fef7e401949d5287a4
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-02-19T16:46:05Z
Add img files
commit f1c7bac81e15f8dd577e1e96de698567e004b1f0
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-02-19T16:47:17Z
Add 'INTERPRETER', 'APPLICATION' as helium pkg types
commit 4a6eace7a9a0356b21d93743105cbd3690a65d9e
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-02-19T16:51:00Z
Enable Helium pkg type sortable
commit b74c599178edc28c240ceb3ba9ac7f01b3d2faf1
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-02-19T17:12:16Z
Remove console.log
commit 86e1eda3ef7d1b79d2544864fd568ce22701c697
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-02-19T17:43:54Z
Remove unnecassary words
commit 6d7f4fab5be6dc4b568f238f9403872309386be0
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-02-22T15:37:39Z
Make packages sortable by type not repository
commit c68efd211bd1741c7d2efd1552d41e9164904694
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-02-22T15:45:27Z
Remove unused img files
commit 899e8fa8eba08a293821470a00c582145c64ea36
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-02-22T15:45:46Z
Put license sentences back removed by mistake
commit d5ae4e2f04a8f61cf2759c1595f776e8f8aa7fd9
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-02-23T07:36:00Z
Add default msg to show when each package size is 0
commit 894a27e5190f4ca48e5bf8345e4ca85b158a4444
Author: Ahyoung Ryu <ah...@apache.org>
Date: 2017-03-03T15:15:51Z
Merge branch 'master' into ZEPPELIN-2109
commit 95b0b87ffea6d8d49d505a6a68644a0d9fa913e4
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-03-03T15:39:05Z
Fix mistakes made by resolving conflicts
commit 03312acb60f1e18fc576db1b71386d032f5f711a
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-03-03T15:51:54Z
Fix interpreter type name duplication
commit 170788298387fbf6695cee26edce584cbf33fbbb
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-03-04T16:40:38Z
Get publishedDate, artifactId and groupId from online registry data
commit a5eb00686117d446ee660a9dbfd2323e48dad339
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-03-04T16:41:20Z
Add 'spell' to description
commit bb34428f04385ea24c86b231e92d86fddf89fbb6
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-03-04T17:21:03Z
Package orderBy publishedDate
commit e6ccc289d0aafc34c756a83be206858cfea5c172
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-03-04T19:02:45Z
Fix typo in docs
commit 569f9c9e405b1553188ccfb2a8438d8bc9942d95
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-03-04T19:03:20Z
Add guide dialog msg for INTERPRETER type pkg
commit 0fd68ba4814a618c433e62c639cb3fcfe0277d7c
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-03-06T13:38:23Z
Remove useless comment code
commit 7393c6ab0ebb04dd8b608f1437484c41e7bd13ad
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-03-07T02:36:28Z
Change '==' to '===' to make CI green
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2037: [ZEPPELIN-2109][2110] Sortable Helium pkgs & Introduce...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2037
Thanks @1ambda!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2037: [ZEPPELIN-2109][2110] Sortable Helium pkgs & Introduce...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2037
Tested and works as described.
- LGTM except https://github.com/apache/zeppelin/pull/2037#pullrequestreview-24893904
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2037: [ZEPPELIN-2109][2110] Sortable Helium pkgs & Introduce...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2037
@Leemoonsoo Thanks for testing it out. CI is green now!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2037: [ZEPPELIN-2109][2110] Sortable Helium pkgs & Introduce...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2037
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2037: [ZEPPELIN-2109][2110] Sortable Helium pkgs & Introduce...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2037
Ready for review again
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2037: [ZEPPELIN-2109][2110] Sortable Helium pkgs & Introduce...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2037
@Leemoonsoo Thanks for your feedback and sorry for my late response. I updated again as you said.
- overall looks
- buttons in header used to sort packages by type
<img width="500" alt="screen shot 2017-02-23 at 12 51 22 am" src="https://cloud.githubusercontent.com/assets/10060731/23219552/b74a0bf4-f962-11e6-8b02-e23f5307c472.png">
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2037: [ZEPPELIN-2109][2110] Sortable Helium pkgs & Introduce...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2037
@Leemoonsoo Thanks for your feedback. Addressed your comment like below. Please let me know if we need better guide :)
- Dialog
<img width="611" alt="screen shot 2017-03-05 at 4 08 39 am" src="https://cloud.githubusercontent.com/assets/10060731/23581561/7c5429ea-0159-11e7-937f-e64dd4f8b079.png">
- gif
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2037: [ZEPPELIN-2109][2110] Sortable Helium pkgs & Introduce...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2037
@Leemoonsoo Thanks!
Will merge into master if there are no more comments on this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2037: [ZEPPELIN-2109][ZEPPELIN-2110] Sortable Helium pkgs & ...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2037
Thanks @AhyoungRyu for the great contribution.
> I put "NPM Packages" & "Maven Artifacts" button at top-right corner of Helium menu.
My guess is, where package lives is not the most interesting information in end-user might interested. I think package type is more important and useful information to be filtered.
How about having a package type filter instead of repository filter?
i.e. filter by package type : interpreter | visualization | spell | ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---