You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Viraj Jasani (Jira)" <ji...@apache.org> on 2019/12/22 12:55:00 UTC
[jira] [Comment Edited] (HBASE-23590) Update maxStoreFileRefCount
to maxCompactedStoreFileRefCount
[ https://issues.apache.org/jira/browse/HBASE-23590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17001858#comment-17001858 ]
Viraj Jasani edited comment on HBASE-23590 at 12/22/19 12:54 PM:
-----------------------------------------------------------------
[~apurtell]
HBASE-22460 has not yet landed to any releases (2.3.0/1.6.1) and now we know that the refCounts that we had taken into consideration are not the correct ones, (we calculate refCount of current store files instead of compacted away store files) could you please review this patch
Sorry for being late on this
While work on HBASE-23349 is still in progress(low no of refCounts), with this Jira, we can ensure that at least we can deal with abnormally high no of refCounts(~1k) preventing archival of compacted store files(the bug fix associated with it). Will attach branch-1 backport to this Jira once the patch looks good to you.
Thanks
was (Author: vjasani):
[~apurtell]
HBASE-22460 has not yet landed to any releases (2.3.0/1.6.1) and now we know that the refCounts that we had taken into consideration are not the correct ones, (we calculate refCount of current store files instead of compacted away store files) could you please review this patch
While work on HBASE-23349 is still in progress(low no of refCounts), with this Jira, we can ensure that at least we can deal with abnormally high no of refCounts(~1k) preventing archival of compacted store files(the bug fix associated with it). Will attach branch-1 backport to this Jira once the patch looks good to you.
Thanks
> Update maxStoreFileRefCount to maxCompactedStoreFileRefCount
> ------------------------------------------------------------
>
> Key: HBASE-23590
> URL: https://issues.apache.org/jira/browse/HBASE-23590
> Project: HBase
> Issue Type: Bug
> Affects Versions: 3.0.0, 2.3.0, 1.6.0
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Fix For: 3.0.0, 2.3.0, 1.6.0
>
>
> As per discussion on HBASE-23349, RegionsRecoveryChore should use max refCount on compacted away store files and not on new store files to determine when to reopen the region. Although work on HBASE-23349 is in progress, we need to at least update the metric to get the desired refCount i.e. max refCount among all compacted away store files for a given region.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)