[GitHub] [iceberg] aokolnychyi commented on a change in pull request #2398: API: Add metadataFileLocation to Table

[GitBox <gi...@apache.org>]

aokolnychyi commented on a change in pull request #2398:
URL: https://github.com/apache/iceberg/pull/2398#discussion_r604637843



##########
File path: core/src/main/java/org/apache/iceberg/AllDataFilesTable.java
##########
@@ -40,51 +40,31 @@
  * This table may return duplicate rows.
  */
 public class AllDataFilesTable extends BaseMetadataTable {
-  private final TableOperations ops;

Review comment:
       Instead of modifying `metadataLocation` in each metadata table, I added `ops` and `table` to the parent class and implemented needed methods there. I can put the refactoring into a separate PR if that simplifies the review.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org