[GitHub] [apisix] moonming commented on a diff in pull request #9016: fix: the problem of high cpu and memory usage (#9015)

["moonming (via GitHub)" <gi...@apache.org>]

moonming commented on code in PR #9016:
URL: https://github.com/apache/apisix/pull/9016#discussion_r1130269358


##########
apisix/core/config_util.lua:
##########
@@ -88,8 +88,14 @@ function _M.cancel_clean_handler(item, idx, fire)
     end
 
     core_tab.remove(item.clean_handlers, pos)
-    if fire then
+    if not fire then
+        return
+    end
+
+    if f then
         f(item)
+    else
+        log.error("call cancel_clean_handler error, f is nil")

Review Comment:
   Can there be a more clear error message?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org