[GitHub] [netbeans] matthiasblaesing commented on pull request #5893: small move to a more explicit "protocol" for libraries

["matthiasblaesing (via GitHub)" <gi...@apache.org>]

matthiasblaesing commented on PR #5893:
URL: https://github.com/apache/netbeans/pull/5893#issuecomment-1544561716

   Regarding library updates:
   
   Yes they suck, but not because you need to update two or three files. You have to check licenses and notices anyway, so changing our integration only slightly lightens the burden. The files are also not all equal:
   
   - `*-licenses.txt`, `*-notice.txt`: They need to be check on _every_ update
   - `binaries-list`: covers downloads, nothing more. These might be bundled libraries, but often enough they are also compile time dependencies that are not bundled
   - `project.properties`: References files that are to be copied by the build system. These are not necessarily downloaded, but also could be part of regular sources
   - `project.xml`: The project file is independed of the build system, but tied to the ant based project type, so we can't tie it to the binaries list
   - `build.xml`: This is highly dependend on the project type. Some project rebundle files or fix issues in downloaded binaries, so little sharing there
   - `ignoried-overlaps`: Well, we can discuss whether or not this helps
   - `binariesembedded-list`: If I remember correctly this is, so that we don't push our binaries to maven central and instead reference the maven bits.
   
   So all in, there is little to gain and the referenced (embedded maven) is very near a worst case scenario. Yes it is not nice, but also less painful, than changing the bits, that make up this net.
   
   
   The hashes in `binaries-list` have to stay as they double as integrity checks.
   
   
   If the need is to create a list of all URLs that would be downloaded, it would IMHO better to create  a task for that in the build system, as that would also be able to consider the cluster that is being build and thus giving "the right" list.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists