You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "sadpandajoe (via GitHub)" <gi...@apache.org> on 2026/08/17 17:48:26 UTC

[PR] test(frontend): shrink flaky/misplaced recently-archived e2e coverage to Jest unit tests [superset]

sadpandajoe opened a new pull request, #43264:
URL: https://github.com/apache/superset/pull/43264

   ### SUMMARY
   Fixes #43200. The flaky test at recently-archived.spec.ts:192 ("shows an empty message and no rows when the search matches nothing") races the list's first-page load: it waits only for the `archived-list-view` container to mount before typing a search query, so the keystroke can be swallowed before the filter machinery is wired up (the container is visible before data loads). Rather than just patch the wait, I reviewed the whole `recently-archived/` e2e suite against the existing `ArchivedList.test.tsx` Jest/RTL coverage and found this test — plus two siblings — never actually needed a real backend or browser, so they move to deterministic component tests instead of race-prone e2e:
   
   - `recently-archived.spec.ts`: removed the flaky empty-search test and the "restoring an already-restored row surfaces an error" test; both now live in `ArchivedList.test.tsx` as Jest tests with mocked responses (empty list result / 404 restore, respectively).
   - `delete-modal.spec.ts`: removed entirely — its one test only asserted feature-flag-gated confirm-dialog copy and never deleted or archived anything real; moved to `ChartList.test.tsx`.
   - The three real soft-delete-restore e2e tests, the real permanent-delete e2e test, and `menu-link.spec.ts` are untouched — they exercise real backend state changes and real app-shell routing, which e2e is for.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   N/A — test-only change, no UI/behavior change.
   
   ### TESTING INSTRUCTIONS
   - `cd superset-frontend && npx jest src/pages/ArchivedList src/pages/ChartList` — 5 suites, 94 tests, all passing.
   - `npx playwright test --list playwright/tests/recently-archived/` — lists the 5 remaining tests across `menu-link.spec.ts` and `recently-archived.spec.ts` (down from 7 across 3 files), confirming valid syntax after the removals.
   
   ### ADDITIONAL INFORMATION
   - [x] Has associated issue: Fixes #43200
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] test(frontend): shrink flaky/misplaced recently-archived e2e coverage to Jest unit tests [superset]

Posted by "yousoph (via GitHub)" <gi...@apache.org>.
yousoph commented on code in PR #43264:
URL: https://github.com/apache/superset/pull/43264#discussion_r3824398468


##########
superset-frontend/src/pages/ArchivedList/ArchivedList.test.tsx:
##########
@@ -204,6 +205,31 @@ test('restore failure surfaces an error and leaves the row in place', async () =
   expect(screen.getByText('Deleted Chart One')).toBeInTheDocument();
 });
 
+test('restoring an already-restored row (404) surfaces an error without crashing', async () => {

Review Comment:
   Optional: this exercises the same single `catch → addDangerToast` path as the existing 422 test above (the component treats any non-200 restore identically), so it's near-duplicate coverage. The genuinely new value here is the explicit toast text/count assertion — that could just as easily be folded into the 422 test. Harmless as-is, just flagging in case you'd rather keep one restore-failure test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] test(frontend): shrink flaky/misplaced recently-archived e2e coverage to Jest unit tests [superset]

Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #43264:
URL: https://github.com/apache/superset/pull/43264#issuecomment-5320408926

   ### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
   
   
   |  Name | Link |
   |:-:|------------------------|
   |<span aria-hidden="true">🔨</span> Latest commit | 5bf71fccc4edbd486c4fe194a7ceb2deb1420fab |
   |<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6a837b5ba1617e0008a74bb3 |
   |<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-43264--superset-docs-preview.netlify.app](https://deploy-preview-43264--superset-docs-preview.netlify.app) |
   |<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br />![QR Code](https://app.netlify.com/qr-code/eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1cmwiOiJodHRwczovL2RlcGxveS1wcmV2aWV3LTQzMjY0LS1zdXBlcnNldC1kb2NzLXByZXZpZXcubmV0bGlmeS5hcHAifQ.fdkEnO1QxwbzVbDD_mptia3umn0XlnBJx4T2hNN4Zoc)<br /><br />_Use your smartphone camera to open QR code link._</details> |
   |<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DcpLCoAgEADQu8w6YUxT6QYdYyYHFfqIRBDR3XP3Fu-F2s69XjADDMCNjjV3p2zNiKiorbncEpWMoq5WKElvUep2Pkvs0VEwnicm7bQXRAzkLbOB7wc) |
   ---
   <!-- [superset-docs-preview Preview](https://deploy-preview-43264--superset-docs-preview.netlify.app) -->
   _To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] test(frontend): shrink flaky/misplaced recently-archived e2e coverage to Jest unit tests [superset]

Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #43264:
URL: https://github.com/apache/superset/pull/43264#discussion_r3798926795


##########
superset-frontend/src/pages/ArchivedList/ArchivedList.test.tsx:
##########
@@ -273,6 +299,28 @@ test('name search refetches with a contains filter on the name field', async ()
   });
 });
 
+test('a search that matches nothing shows the empty-state and no restore actions', async () => {
+  // The list answers with zero rows regardless of query -- the assertion
+  // only needs to observe the empty state a filtered, empty result produces.
+  fetchMock.get(infoEndpoint, { permissions: ['can_read', 'can_write'] });
+  fetchMock.get(listEndpoint, { result: [], count: 0 });
+  renderArchivedList();

Review Comment:
   **Suggestion:** The list endpoint is configured to return an empty result for the initial load as well as any subsequent request, so this test can pass without the search input or Enter key causing a filtered refetch. Return archived rows for the initial request, configure the filtered response to be empty, and assert that a request containing `e2e_nonexistent` was made before checking the empty state. [logic error]
   
   <details>
   <summary><b>Severity Level:</b> Major ⚠️</summary>
   
   ```mdx
   - ❌ Jest coverage can pass when search handling is broken.
   - ⚠️ The archived-list search regression remains undetected.
   - ⚠️ A false-positive test weakens CI protection for `ArchivedList`.
   ```
   </details>
   
   [![Fix in Cursor](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/fix-in-cursor-flat.svg)](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=b049b158971049d9a07be0e84a34845f&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [![Fix in VSCode Claude](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/fix-in-vscode-claude-flat.svg)](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=b049b158971049d9a07be0e84a34845f&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
   <details>
   <summary><b>Prompt for AI Agent 🤖 </b></summary>
   
   ```mdx
   This is a comment left during a code review.
   
   **Path:** superset-frontend/src/pages/ArchivedList/ArchivedList.test.tsx
   **Line:** 305:307
   **Comment:**
   	*Logic Error: The list endpoint is configured to return an empty result for the initial load as well as any subsequent request, so this test can pass without the search input or Enter key causing a filtered refetch. Return archived rows for the initial request, configure the filtered response to be empty, and assert that a request containing `e2e_nonexistent` was made before checking the empty state.
   
   Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
   Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
   ```
   </details>
   <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43264&comment_hash=5fa2d1cead6d8b28462f7c409db058dd338afdc5472a418e4a239f28c2c9385e&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43264&comment_hash=5fa2d1cead6d8b28462f7c409db058dd338afdc5472a418e4a239f28c2c9385e&reaction=dislike'>👎</a>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] test(frontend): shrink flaky/misplaced recently-archived e2e coverage to Jest unit tests [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43264:
URL: https://github.com/apache/superset/pull/43264#issuecomment-5333646904

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
   
   <details>
   <summary>
   Bito Usage Guide
   </summary>
   
   **Commands**
         
   Type the following command in the pull request comment and save the comment.
         
   - `/review` - Manually triggers a full AI review.
   
   - `/pause` - Pauses automatic reviews on this pull request.
   - `/resume` - Resumes automatic reviews.
   - `/resolve` - Marks all Bito-posted review comments as resolved.
   - `/abort` - Cancels all in-progress reviews.
   
         
   Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
         
   **Configuration**
   
   This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
         
   **Documentation & Help**
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] test(frontend): shrink flaky/misplaced recently-archived e2e coverage to Jest unit tests [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43264:
URL: https://github.com/apache/superset/pull/43264#issuecomment-5320138464

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
   
   <details>
   <summary>
   Bito Usage Guide
   </summary>
   
   **Commands**
         
   Type the following command in the pull request comment and save the comment.
         
   - `/review` - Manually triggers a full AI review.
   
   - `/pause` - Pauses automatic reviews on this pull request.
   - `/resume` - Resumes automatic reviews.
   - `/resolve` - Marks all Bito-posted review comments as resolved.
   - `/abort` - Cancels all in-progress reviews.
   
         
   Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
         
   **Configuration**
   
   This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
         
   **Documentation & Help**
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] test(frontend): shrink flaky/misplaced recently-archived e2e coverage to Jest unit tests [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43264:
URL: https://github.com/apache/superset/pull/43264#issuecomment-5318330680

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] test(frontend): shrink flaky/misplaced recently-archived e2e coverage to Jest unit tests [superset]

Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on code in PR #43264:
URL: https://github.com/apache/superset/pull/43264#discussion_r3806972195


##########
superset-frontend/src/pages/ArchivedList/ArchivedList.test.tsx:
##########
@@ -273,6 +299,28 @@ test('name search refetches with a contains filter on the name field', async ()
   });
 });
 
+test('a search that matches nothing shows the empty-state and no restore actions', async () => {
+  // The list answers with zero rows regardless of query -- the assertion
+  // only needs to observe the empty state a filtered, empty result produces.
+  fetchMock.get(infoEndpoint, { permissions: ['can_read', 'can_write'] });
+  fetchMock.get(listEndpoint, { result: [], count: 0 });
+  renderArchivedList();

Review Comment:
   Fixed in d811da1b74 — you're right, the mock returned an empty result unconditionally for both the initial load and the post-search request, so the test could pass without the search ever firing. Now the initial load returns real data (`getOnce`), the search-triggered request specifically returns empty, and the test asserts a request matching the search term was actually made before checking the empty-state assertion (same pattern as the adjacent name-search test). Independently re-verified: a fresh reviewer confirmed the fetch-mock@12.6.0 `getOnce`/`get` ordering against the library's own source, reproduced the negative check (temporarily disabling the search keypress) to confirm the test now genuinely fails without a real search firing, and re-ran it clean after a later master merge.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] test(frontend): shrink flaky/misplaced recently-archived e2e coverage to Jest unit tests [superset]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #43264:
URL: https://github.com/apache/superset/pull/43264#issuecomment-5320514277

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/43264?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 66.67%. Comparing base ([`aaf9eba`](https://app.codecov.io/gh/apache/superset/commit/aaf9eba1611e657a592de98e2f2c94d4aa276dcf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5bf71fc`](https://app.codecov.io/gh/apache/superset/commit/5bf71fccc4edbd486c4fe194a7ceb2deb1420fab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #43264      +/-   ##
   ==========================================
   + Coverage   66.09%   66.67%   +0.57%     
   ==========================================
     Files        2874     2873       -1     
     Lines      163787   163632     -155     
     Branches    37799    37768      -31     
   ==========================================
   + Hits       108255   109094     +839     
   + Misses      53393    52409     -984     
   + Partials     2139     2129      -10     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/superset/pull/43264/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [javascript](https://app.codecov.io/gh/apache/superset/pull/43264/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.78% <ø> (-0.02%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/43264?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] test(frontend): shrink flaky/misplaced recently-archived e2e coverage to Jest unit tests [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43264:
URL: https://github.com/apache/superset/pull/43264#issuecomment-5320462645

   <!-- Bito Reply -->
   The flagged issue is correct. The test `shows an empty message and no rows when the search matches nothing` is fragile because it relies on the list endpoint returning an empty result for both the initial load and the filtered request, allowing the test to pass even if the search functionality is broken. To resolve this, you should ensure the initial request returns data, configure the filtered request to return an empty result, and verify that the search request was actually triggered before asserting the empty state.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] test(frontend): shrink flaky/misplaced recently-archived e2e coverage to Jest unit tests [superset]

Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe merged PR #43264:
URL: https://github.com/apache/superset/pull/43264


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org