You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by xuchuanyin <gi...@git.apache.org> on 2018/08/22 01:20:08 UTC

[GitHub] carbondata pull request #2644: [CARBONDATA-2853] Implement file-level min/ma...

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2644#discussion_r211805649
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/DataTypeUtil.java ---
    @@ -324,13 +324,13 @@ public static Object getDataBasedOnDataType(String data, DataType actualDataType
         if (actualDataType == DataTypes.BOOLEAN) {
           return ByteUtil.toBytes(BooleanConvert.parseBoolean(dimensionValue));
         } else if (actualDataType == DataTypes.SHORT) {
    -      return ByteUtil.toBytes(Short.parseShort(dimensionValue));
    +      return ByteUtil.toXorBytes(Short.parseShort(dimensionValue));
    --- End diff --
    
    Will this affect the legacy store?
    It seems that a value will be encoded differently before and after this modification. If somewhere has used this method to encode and store data before, it will be a problem.


---