[GitHub] [superset] rusackas commented on a diff in pull request #19897: chore: Adds a storybook to FilterableTable

[GitBox <gi...@apache.org>]

rusackas commented on code in PR #19897:
URL: https://github.com/apache/superset/pull/19897#discussion_r863955281


##########
superset-frontend/src/components/FilterableTable/index.tsx:
##########
@@ -287,6 +277,33 @@ export default class FilterableTable extends PureComponent<
     this.fitTableToWidthIfNeeded();
   }
 
+  getJsonTreeTheme() {
+    if (!this.jsonTreeTheme) {
+      const { theme } = this.props;
+      this.jsonTreeTheme = {
+        scheme: 'monokai',
+        author: 'wimer hazenberg (http://www.monokai.nl)',

Review Comment:
   No need, per se, but I wonder if this is changed significantly enough that we should remove the scheme name and author ¯\\\_(ツ)_/¯ 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org