[GitHub] [hive] kishendas commented on a change in pull request #1253: Fix unit tests ( TestHiveMetaStoreChecker and TestMiniLlapLocalCliDriver tests ) in master

[GitBox <gi...@apache.org>]

kishendas commented on a change in pull request #1253:
URL: https://github.com/apache/hive/pull/1253#discussion_r454881803



##########
File path: ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHiveMetaStoreChecker.java
##########
@@ -82,6 +84,11 @@ public void setUp() throws Exception {
     msc = new HiveMetaStoreClient(hive.getConf());
     checker = new HiveMetaStoreChecker(msc, hive.getConf());
 
+    hive.getConf().setVar(HiveConf.ConfVars.HIVE_AUTHORIZATION_MANAGER,
+        "org.apache.hadoop.hive.ql.security.authorization.plugin.sqlstd.SQLStdHiveAuthorizerFactory");
+    HiveConf.setBoolVar(hive.getConf(), HiveConf.ConfVars.HIVE_SUPPORT_CONCURRENCY, false);
+    SessionState.start(hive.getConf());

Review comment:
       All tests here deal with transactional table, but doesn't initiate SessionState. So, this results in Nullpointer, when we try to retrieve transaction manager from SessionState, in order to derive ValidWriteIdList. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org