You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by sr...@apache.org on 2018/08/02 14:26:29 UTC
spark git commit: [MINOR] remove dead code in ExpressionEvalHelper
Repository: spark
Updated Branches:
refs/heads/master d182b3d34 -> f04cd6709
[MINOR] remove dead code in ExpressionEvalHelper
## What changes were proposed in this pull request?
This addresses https://github.com/apache/spark/pull/21236/files#r207078480
both https://github.com/apache/spark/pull/21236 and https://github.com/apache/spark/pull/21838 add a InternalRow result check to ExpressionEvalHelper and becomes duplicated.
## How was this patch tested?
N/A
Author: Wenchen Fan <we...@databricks.com>
Closes #21958 from cloud-fan/minor.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/f04cd670
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/f04cd670
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/f04cd670
Branch: refs/heads/master
Commit: f04cd670943d0eb6eb688a0f50d56293cda554ef
Parents: d182b3d
Author: Wenchen Fan <we...@databricks.com>
Authored: Thu Aug 2 09:26:27 2018 -0500
Committer: Sean Owen <sr...@gmail.com>
Committed: Thu Aug 2 09:26:27 2018 -0500
----------------------------------------------------------------------
.../spark/sql/catalyst/expressions/ExpressionEvalHelper.scala | 3 ---
1 file changed, 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/f04cd670/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
----------------------------------------------------------------------
diff --git a/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala b/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
index d045267..6684e5c 100644
--- a/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
+++ b/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
@@ -105,9 +105,6 @@ trait ExpressionEvalHelper extends GeneratorDrivenPropertyChecks with PlanTestBa
if (expected.isNaN) result.isNaN else expected == result
case (result: Float, expected: Float) =>
if (expected.isNaN) result.isNaN else expected == result
- case (result: UnsafeRow, expected: GenericInternalRow) =>
- val structType = exprDataType.asInstanceOf[StructType]
- result.toSeq(structType) == expected.toSeq(structType)
case (result: Row, expected: InternalRow) => result.toSeq == expected.toSeq(result.schema)
case _ =>
result == expected
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org