You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (JIRA)" <ji...@apache.org> on 2012/06/08 19:56:24 UTC
[jira] [Created] (LUCENE-4124) factor ByteBufferIndexInput out of
MMapDirectory
Robert Muir created LUCENE-4124:
-----------------------------------
Summary: factor ByteBufferIndexInput out of MMapDirectory
Key: LUCENE-4124
URL: https://issues.apache.org/jira/browse/LUCENE-4124
Project: Lucene - Java
Issue Type: Improvement
Components: core/store
Reporter: Robert Muir
Assignee: Uwe Schindler
I think we should factor a ByteBufferIndexInput out of MMapDir, leaving only the mmap/unmapping in mmapdir.
Its a cleaner separation and would allow it to be used for other purposes (e.g. direct or array-backed buffers)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4124) factor ByteBufferIndexInput out of
MMapDirectory
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291899#comment-13291899 ]
Uwe Schindler commented on LUCENE-4124:
---------------------------------------
Thanks for assigning me. Patch looks good as first step. The hashcode and equals in the (now abstract) base class must be final. This was not done before, as class on itself was final.
> factor ByteBufferIndexInput out of MMapDirectory
> ------------------------------------------------
>
> Key: LUCENE-4124
> URL: https://issues.apache.org/jira/browse/LUCENE-4124
> Project: Lucene - Java
> Issue Type: Improvement
> Components: core/store
> Reporter: Robert Muir
> Assignee: Uwe Schindler
> Attachments: LUCENE-4124.patch
>
>
> I think we should factor a ByteBufferIndexInput out of MMapDir, leaving only the mmap/unmapping in mmapdir.
> Its a cleaner separation and would allow it to be used for other purposes (e.g. direct or array-backed buffers)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4124) factor ByteBufferIndexInput out of
MMapDirectory
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-4124:
--------------------------------
Attachment: LUCENE-4124.patch
> factor ByteBufferIndexInput out of MMapDirectory
> ------------------------------------------------
>
> Key: LUCENE-4124
> URL: https://issues.apache.org/jira/browse/LUCENE-4124
> Project: Lucene - Java
> Issue Type: Improvement
> Components: core/store
> Reporter: Robert Muir
> Assignee: Uwe Schindler
> Attachments: LUCENE-4124.patch
>
>
> I think we should factor a ByteBufferIndexInput out of MMapDir, leaving only the mmap/unmapping in mmapdir.
> Its a cleaner separation and would allow it to be used for other purposes (e.g. direct or array-backed buffers)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4124) factor ByteBufferIndexInput out of
MMapDirectory
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292314#comment-13292314 ]
Robert Muir commented on LUCENE-4124:
-------------------------------------
I agree. actually we might want to make other methods final that arent intended to be subclassed (e.g. readByte).
The whole thing is a pkg-private class anyway and should be locked down unless we need.
Mainly i just wanted to get this patch off my laptop (have had it around for a while) and up on a JIRA issue instead
since I think its a good split to do.
> factor ByteBufferIndexInput out of MMapDirectory
> ------------------------------------------------
>
> Key: LUCENE-4124
> URL: https://issues.apache.org/jira/browse/LUCENE-4124
> Project: Lucene - Java
> Issue Type: Improvement
> Components: core/store
> Reporter: Robert Muir
> Assignee: Uwe Schindler
> Attachments: LUCENE-4124.patch
>
>
> I think we should factor a ByteBufferIndexInput out of MMapDir, leaving only the mmap/unmapping in mmapdir.
> Its a cleaner separation and would allow it to be used for other purposes (e.g. direct or array-backed buffers)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org