You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "Sh-Zh-7 (via GitHub)" <gi...@apache.org> on 2024/12/11 04:20:08 UTC

[PR] Add `removeInput` and `hasRemoveInput` to some specific Accmulators [iotdb]

Sh-Zh-7 opened a new pull request, #14380:
URL: https://github.com/apache/iotdb/pull/14380

   ## Description
   Add `removeInput` and `hasRemoveInput` to some Accumulators in Table Model for Window Function use.
   
   These following Accumulators have been influenced:
   - AvgAccumulator
   - SumAccumulator
   - CountAccumulator
   - TableModeAccumulator
   - TableVarianceAccumulator
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add `removeInput` and `removable` to some specific Accmulators [iotdb]

Posted by "JackieTien97 (via GitHub)" <gi...@apache.org>.
JackieTien97 merged PR #14380:
URL: https://github.com/apache/iotdb/pull/14380


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add `removeInput` and `hasRemoveInput` to some specific Accmulators [iotdb]

Posted by "Sh-Zh-7 (via GitHub)" <gi...@apache.org>.
Sh-Zh-7 commented on code in PR #14380:
URL: https://github.com/apache/iotdb/pull/14380#discussion_r1879413590


##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/source/relational/aggregation/TableAccumulator.java:
##########
@@ -49,4 +53,8 @@ public interface TableAccumulator {
   void addStatistics(Statistics[] statistics);
 
   void reset();
+
+  default boolean hasRemoveInput() {

Review Comment:
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add `removeInput` and `hasRemoveInput` to some specific Accmulators [iotdb]

Posted by "JackieTien97 (via GitHub)" <gi...@apache.org>.
JackieTien97 commented on code in PR #14380:
URL: https://github.com/apache/iotdb/pull/14380#discussion_r1879311042


##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/source/relational/aggregation/TableAccumulator.java:
##########
@@ -49,4 +53,8 @@ public interface TableAccumulator {
   void addStatistics(Statistics[] statistics);
 
   void reset();
+
+  default boolean hasRemoveInput() {

Review Comment:
   ```suggestion
     default boolean removable() {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org