[GitHub] [netbeans] mbien commented on a diff in pull request #4297: Cleanup references to the generic emptySet()..

[GitBox <gi...@apache.org>]

mbien commented on code in PR #4297:
URL: https://github.com/apache/netbeans/pull/4297#discussion_r910426498


##########
apisupport/maven.apisupport/src/org/netbeans/modules/maven/apisupport/ExamineManifest.java:
##########
@@ -51,7 +51,7 @@ public class ExamineManifest  {
     private String locBundle;
     private boolean publicPackages;
     private boolean populateDependencies = false;
-    private List dependencyTokens = Collections.emptyList();
+    private List<String> dependencyTokens = Collections.<String>emptyList();

Review Comment:
   I don't think the generic type passed to the method on the right side is needed. It would be only needed if the compiler can't infer the type in some edge cases. Try without first unless there is a warning (same for the other occurences).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists