You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/08/04 10:01:48 UTC
[GitHub] [hive] beliefer opened a new pull request, #3501: HIVE-26448: Improve UnsignedInt128.setV*()
beliefer opened a new pull request, #3501:
URL: https://github.com/apache/hive/pull/3501
### What changes were proposed in this pull request?
Currently, these method `setV0`, `setV1`, `setV2` of `UnsignedInt128` call `updateCount` directly.
The `updateCount` of `UnsignedInt128` have a lot `if ... else ...` logic.
In fact, we can improve the code by judge `count` field of `UnsignedInt128`.
### Why are the changes needed?
Improve UnsignedInt128.setV*()
### Does this PR introduce _any_ user-facing change?
'No'.
Just update the inner implementation.
### How was this patch tested?
New test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao merged pull request #3501: HIVE-26448: Improve UnsignedInt128.setV*()
Posted by GitBox <gi...@apache.org>.
sunchao merged PR #3501:
URL: https://github.com/apache/hive/pull/3501
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] wangyum commented on pull request #3501: HIVE-26448: Improve UnsignedInt128.setV*()
Posted by GitBox <gi...@apache.org>.
wangyum commented on PR #3501:
URL: https://github.com/apache/hive/pull/3501#issuecomment-1206174829
cc @sunchao
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao commented on pull request #3501: HIVE-26448: Improve UnsignedInt128.setV*()
Posted by GitBox <gi...@apache.org>.
sunchao commented on PR #3501:
URL: https://github.com/apache/hive/pull/3501#issuecomment-1206715867
Thanks, merged!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] beliefer commented on pull request #3501: HIVE-26448: Improve UnsignedInt128.setV*()
Posted by GitBox <gi...@apache.org>.
beliefer commented on PR #3501:
URL: https://github.com/apache/hive/pull/3501#issuecomment-1207159825
@sunchao @wangyum Thank you !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] beliefer commented on pull request #3501: HIVE-26448: Improve UnsignedInt128.setV*()
Posted by GitBox <gi...@apache.org>.
beliefer commented on PR #3501:
URL: https://github.com/apache/hive/pull/3501#issuecomment-1205947884
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org