Re: [PR] Read legacy text index directory without probing consolidated entry when it exists [pinot]

["xiangfu0 (via GitHub)" <gi...@apache.org>]

xiangfu0 commented on PR #18919:
URL: https://github.com/apache/pinot/pull/18919#issuecomment-5773906172

   Addressed the review feedback (rebased onto latest master):
   
   - Guarded the legacy-directory probe with `segmentDir.isDirectory()`, mirroring the vector reader (#18852). `findTextIndexIndexFile` → `findFormatFile` requires a local directory (`Preconditions.checkArgument(indexDir.isDirectory())`); for a remote/tiered `SegmentDirectory`, `getPath()` can be a non-existent local path while `getIndexFor()` still returns the valid consolidated `columns.psf` buffer, so the unconditional probe threw `IllegalArgumentException` and killed segment load before that buffer could be read.
   - Added `testReaderFactoryLoadsConsolidatedTextWhenSegmentDirectoryIsNotLocal`, the non-local consolidated-entry regression test analogous to the vector reader's. It stubs a non-local `getPath()` and a valid `columns.psf` buffer; it fails without the guard with the exact `Path: ... is not a directory` error and passes with it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org