[GitHub] [thrift] Jens-G edited a comment on pull request #2288: THRIFT-5318: Update PHP thrift_protocol extension for PHP 8

[GitBox <gi...@apache.org>]

Jens-G edited a comment on pull request #2288:
URL: https://github.com/apache/thrift/pull/2288#issuecomment-738343130


   This is only an excerpt. There's a ton of these.
   
   ```
   /usr/include/php/20151012/Zend/zend_API.h:107:70: error: expected unqualified-id before '{' token
    define ZEND_ARG_TYPE_INFO(pass_by_ref, name, type_hint, allow_null) { #name, NU
                                                                        ^
   /thrift/src/lib/php/src/ext/thrift_protocol/php_thrift_protocol_arginfo.h:10:2: note: in expansion of macro 'ZEND_ARG_TYPE_INFO'
     ZEND_ARG_TYPE_INFO(0, strict_write, _IS_BOOL, 0)
     ^
   /usr/include/php/20151012/Zend/zend_API.h:107:124: error: expected unqualified-id before ',' token
     type_hint, allow_null) { #name, NULL, type_hint, pass_by_ref, allow_null, 0 },
                                                                                  ^
   /thrift/src/lib/php/src/ext/thrift_protocol/php_thrift_protocol_arginfo.h:10:2: note: in expansion of macro 'ZEND_ARG_TYPE_INFO'
     ZEND_ARG_TYPE_INFO(0, strict_write, _IS_BOOL, 0)
     ^
   /usr/include/php/20151012/Zend/zend_API.h:122:30: error: expected unqualified-id before '}' token
    #define ZEND_END_ARG_INFO()  };
                                 ^
   /thrift/src/lib/php/src/ext/thrift_protocol/php_thrift_protocol_arginfo.h:11:1: note: in expansion of macro 'ZEND_END_ARG_INFO'
    ZEND_END_ARG_INFO()
    ^
   /usr/include/php/20151012/Zend/zend_API.h:122:30: error: expected declaration before '}' token
    #define ZEND_END_ARG_INFO()  };
                                 ^
   /thrift/src/lib/php/src/ext/thrift_protocol/php_thrift_protocol_arginfo.h:11:1: note: in expansion of macro 'ZEND_END_ARG_INFO'
    ZEND_END_ARG_INFO()
    ^
   Makefile:194: recipe for target 'php_thrift_protocol.lo' failed
   make[4]: *** [php_thrift_protocol.lo] Error 1
   make[4]: Leaving directory '/thrift/src/lib/php/src/ext/thrift_protocol'
   Makefile:1328: recipe for target 'src/ext/thrift_protocol/modules/thrift_protocol.so' failed
   make[3]: *** [src/ext/thrift_protocol/modules/thrift_protocol.so] Error 2
   make[3]: Leaving directory '/thrift/src/lib/php'
   Makefile:1018: recipe for target 'check-recursive' failed
   make[2]: *** [check-recursive] Error 1
   make[2]: Leaving directory '/thrift/src/lib/php'
   Makefile:579: recipe for target 'check-recursive' failed
   make[1]: *** [check-recursive] Error 1
   make[1]: Leaving directory '/thrift/src/lib'
   Makefile:679: recipe for target 'check-recursive' failed
   make: *** [check-recursive] Error 1
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org