[jira] Commented: (WINK-102) Changes to FlushResultHandler

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WINK-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12733119#action_12733119 ] 

Hudson commented on WINK-102:
-----------------------------

Integrated in Wink-Trunk-JDK1.5 #22 (See [http://hudson.zones.apache.org/hudson/job/Wink-Trunk-JDK1.5/22/])
    Allow writer to close stream, always flush headers

See []


> Changes to FlushResultHandler
> -----------------------------
>
>                 Key: WINK-102
>                 URL: https://issues.apache.org/jira/browse/WINK-102
>             Project: Wink
>          Issue Type: Bug
>          Components: Server
>    Affects Versions: 0.1
>            Reporter: Bryant Luk
>            Assignee: Bryant Luk
>             Fix For: 0.1
>
>
> 3 changes I think should be made for FlushResultHandler:
> 1)  I forgot about FlushHeadersOutputStream should override OutputStream.close().
> 2)  The FlushHeadersOutputStream's flushHeaders should be called directly after the MessageBodyWriter.writeTo is called and the DataContentHandler.writeTo.  The MessageBodyWriter is not guaranteed to write anything to the output stream but could just be pushing headers out (i.e. some headers to real content).
> 3)  The logger.warn() and logger.error() should be turned into an Info.  I don't think there's any reason to do repeated warnings to an administrator.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.