You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/10 10:35:50 UTC
[GitHub] [airflow] massamany opened a new pull request #17531: fix port overriding in cli for postgres
massamany opened a new pull request #17531:
URL: https://github.com/apache/airflow/pull/17531
When configuring the sql alchemy url like this :
```
sql_alchemy_conn = postgresql://user:password@localhost:9999/airflowdb
```
Then the Airflow shell can't be used, because the port is incorrectly propagated.
This PR fixes this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr closed pull request #17531: fix port overriding in cli for postgres
Posted by GitBox <gi...@apache.org>.
uranusjr closed pull request #17531:
URL: https://github.com/apache/airflow/pull/17531
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17531: fix port overriding in cli for postgres
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #17531:
URL: https://github.com/apache/airflow/pull/17531#issuecomment-895919947
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] massamany commented on pull request #17531: fix port overriding in cli for postgres
Posted by GitBox <gi...@apache.org>.
massamany commented on pull request #17531:
URL: https://github.com/apache/airflow/pull/17531#issuecomment-896003456
So should I modify the PR to target the main branch ? I think that it's probable that the issue is still there, but I can't be sure as we're still stuck on Airflow 1.10, and I won't be able to test the fix :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #17531: fix port overriding in cli for postgres
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #17531:
URL: https://github.com/apache/airflow/pull/17531#issuecomment-895984895
> > This PR is against v1-10-stable which has reached EOL currently. https://github.com/apache/airflow#version-life-cycle
> > Please check the "main" branch and PR against it
>
> Hi !
>
> I saw 1.10.15 was released not so long ago (5 month) so I thought a 1.10.16 might be released one day. Sorry for the confusion.
No worries at all :) 1.10.15 was the last release in 1.10.x series and the support ended in July. But thank you very much for the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] massamany commented on pull request #17531: fix port overriding in cli for postgres
Posted by GitBox <gi...@apache.org>.
massamany commented on pull request #17531:
URL: https://github.com/apache/airflow/pull/17531#issuecomment-895977218
> This PR is against v1-10-stable which has reached EOL currently. https://github.com/apache/airflow#version-life-cycle
>
> Please check the "main" branch and PR against it
Hi !
I saw 1.10.15 was released not so long ago (5 month) so I thought a 1.10.16 might be released one day. Sorry for the confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #17531: fix port overriding in cli for postgres
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #17531:
URL: https://github.com/apache/airflow/pull/17531#issuecomment-896015458
If the code is still there, the bug is probably still there. We can discuss when you file that PR.
I don’t think it’s possible to change a PR’s target, so you’ll need to create a new one. I’ll close this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org