You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/02 06:46:56 UTC

[GitHub] [airflow] uranusjr commented on pull request #17974: WIP: Implement before stm and after stm in DBApiHooks

uranusjr commented on pull request #17974:
URL: https://github.com/apache/airflow/pull/17974#issuecomment-911272411


   The string concatenation against free-form user input feels a bit fragile to me though. Would it be possible to explicitly declare what additions we allow instead? I’m thinking something like
   
   ```python
   hook.inser_rows("table", rows, after_statement=OnConflictDoNothing())
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org