You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/04/13 04:02:32 UTC
[GitHub] [incubator-inlong] luchunliang opened a new pull request, #3666: [INLONG-3659][DataProxy] DataProxy add manageable entry, used to stop some services(TCP service).
luchunliang opened a new pull request, #3666:
URL: https://github.com/apache/incubator-inlong/pull/3666
### Title Name: [INLONG-3659][DataProxy] DataProxy add manageable entry, used to stop some services(TCP service).
Fixes #3659
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve?*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang commented on pull request #3666: [INLONG-3659][DataProxy] Add manageable entry to stop some TCP services
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on PR #3666:
URL: https://github.com/apache/incubator-inlong/pull/3666#issuecomment-1105245950
it's not an elegant implementation, we need a better solution. [addShutdownHook](https://docs.oracle.com/javase/6/docs/api/java/lang/Runtime.html#addShutdownHook%28java.lang.Thread%29) may be a choice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang commented on pull request #3666: [INLONG-3659][DataProxy] Add manageable entry to stop some TCP services
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on PR #3666:
URL: https://github.com/apache/incubator-inlong/pull/3666#issuecomment-1101229227
what's the problem this PR wants to solve?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang merged pull request #3666: [INLONG-3659][DataProxy] Add manageable entry to stop TCP services or resume TCP services
Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #3666:
URL: https://github.com/apache/incubator-inlong/pull/3666
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org