You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2021/10/05 05:23:57 UTC
[GitHub] [zeppelin] jongyoul opened a new pull request #4242: [MINOR] Adopt maven wrapper to use the same version of Maven
jongyoul opened a new pull request #4242:
URL: https://github.com/apache/zeppelin/pull/4242
### What is this PR for?
Using maven wrapper when building and testing
### What type of PR is it?
[Improvement]
### Todos
* [ ] - Change `mvn` to `./mvnw`
### What is the Jira issue?
N/A
### How should this be tested?
Pass CI
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4242: [MINOR] Adopt maven wrapper to use the same version of Maven
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4242:
URL: https://github.com/apache/zeppelin/pull/4242#issuecomment-937703542
@jongyoul This is not a small change, it's better to create a ticket for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] jongyoul edited a comment on pull request #4242: [MINOR] Adopt maven wrapper to use the same version of Maven
Posted by GitBox <gi...@apache.org>.
jongyoul edited a comment on pull request #4242:
URL: https://github.com/apache/zeppelin/pull/4242#issuecomment-934131509
> A Jar is stored in the SCM.
This is a very similar mechanism with the Gradle wrapper which stores only one jar(50KB) is to get the actual Gradle version only. As you already knew, the jar is not a maven itself. It's just a wrapper program to get a specific version of Maven when running maven wrapper for the first time.
> I see it as an advantage to have multiple versions in the wild to build the zeppelin project.
I don't think Maven is not unstable at all but the main advantage of using it is to keep the same version for CI and the development environment. If we want to multiple versions of maven as we have multiple projects using maven, it's quite complicated. If we use a maven wrapper, we don't care about the maven version for Zeppelin because maven wrapper download and use the specific version for Zeppelin project. Moreover, we don't have to install maven in my local machine to build Zeppelin - yes, I also think most Java developers already installed Maven :-) -
The most important thing is that it's not mandatory to use a maven wrapper. It's just a helper feature. Everyone doesn't have to use a maven wrapper. If someone wants to use local maven, it's ok to use it as it has the same behaviors. Nonetheless, the reason why I thought I would like to adopt it is that I just want to use the same version of CI. (Recently, I got different warning messages between CI and my local machine.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] jongyoul closed pull request #4242: [MINOR] Adopt maven wrapper to use the same version of Maven
Posted by GitBox <gi...@apache.org>.
jongyoul closed pull request #4242:
URL: https://github.com/apache/zeppelin/pull/4242
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #4242: [MINOR] Adopt maven wrapper to use the same version of Maven
Posted by GitBox <gi...@apache.org>.
jongyoul commented on pull request #4242:
URL: https://github.com/apache/zeppelin/pull/4242#issuecomment-937483562
I would like to merge it if there isn't any further opinion. I believe that some people use this feature very usefully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4242: [MINOR] Adopt maven wrapper to use the same version of Maven
Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #4242:
URL: https://github.com/apache/zeppelin/pull/4242#issuecomment-934114853
I've heard of the Maven wrapper, but didn't know what the project was for until today. I read the following article about it.
https://www.baeldung.com/maven-wrapper
I am against using the maven wrapper for the following reasons.
1) A Jar is checked in the SCM.
2) I see it as an advantage to have multiple versions in the wild to build the zeppelin project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #4242: [MINOR] Adopt maven wrapper to use the same version of Maven
Posted by GitBox <gi...@apache.org>.
jongyoul commented on pull request #4242:
URL: https://github.com/apache/zeppelin/pull/4242#issuecomment-937483562
I would like to merge it if there isn't any further opinion. I believe that some people use this feature very usefully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] jongyoul edited a comment on pull request #4242: [MINOR] Adopt maven wrapper to use the same version of Maven
Posted by GitBox <gi...@apache.org>.
jongyoul edited a comment on pull request #4242:
URL: https://github.com/apache/zeppelin/pull/4242#issuecomment-934131509
> A Jar is stored in the SCM.
This is a very similar mechanism with the Gradle wrapper which stores only one jar is to get the actual Gradle version only. As you already knew, the jar is not a maven itself. It's just a wrapper program to get a specific version of Maven when running maven wrapper for the first time.
> I see it as an advantage to have multiple versions in the wild to build the zeppelin project.
I don't think Maven is not unstable at all but the main advantage of using it is to keep the same version for CI and the development environment. If we want to multiple version of maven as we have multiple project using maven, it's quite complicated. If we use a maven wrapper, we don't care about the maven version for Zeppelin because maven wrapper download and use the specific version for Zeppelin project. Moreover, we don't have to install maven in my local machine to build Zeppelin - yes, I also think most Java developers already installed Maven :-) -
The most important thing is that it's not mandatory to use a maven wrapper. It's just a helper feature. Everyone doesn't have to use a maven wrapper. If someone wants to use local maven, it's ok to use it as it has the same behaviors. Nonetheless, the reason why I thought I would like to adopt it is that I just want to use the same version of CI. (Recently, I got different warning messages between CI and my local machine.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] jongyoul closed pull request #4242: [MINOR] Adopt maven wrapper to use the same version of Maven
Posted by GitBox <gi...@apache.org>.
jongyoul closed pull request #4242:
URL: https://github.com/apache/zeppelin/pull/4242
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4242: [MINOR] Adopt maven wrapper to use the same version of Maven
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4242:
URL: https://github.com/apache/zeppelin/pull/4242#issuecomment-937703542
@jongyoul This is not a small change, it's better to create a ticket for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #4242: [MINOR] Adopt maven wrapper to use the same version of Maven
Posted by GitBox <gi...@apache.org>.
jongyoul commented on pull request #4242:
URL: https://github.com/apache/zeppelin/pull/4242#issuecomment-934131509
> A Jar is stored in the SCM.
This is a very similar mechanism with the Gradle wrapper which stores only one jar is to get the actual Gradle version only. As you already knew, the jar is not a maven itself. It's just a wrapper program to get a specific version of Maven when running maven wrapper for the first time.
> I see it as an advantage to have multiple versions in the wild to build the zeppelin project.
I don't think Maven is not unstable at all but the main advantage of using it is to keep the same version for CI and the development environment. If we want to multiple version of maven as we have multiple project using maven, it's quite complicated. If we use a maven wrapper, we don't care about the maven version for Zeppelin because maven wrapper download and use the specific version for Zeppelin project. Moreover, we don't have to install maven in my local machine to build Zeppelin - yes, I also think most Java developers already installed Maven :-) -
The most important thing is that it's not mandatory to use a maven wrapper. It's just a helper feature. Everyone doesn't have to use a maven wrapper. If someone wants to use local maven, it's ok to use it as it has the same behaviors. Nonetheless, the reason why I thought I would like to adopt it is that I just want to use the same version of CI. (Recently, I got different warning messages between CI and my local machine.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer edited a comment on pull request #4242: [MINOR] Adopt maven wrapper to use the same version of Maven
Posted by GitBox <gi...@apache.org>.
Reamer edited a comment on pull request #4242:
URL: https://github.com/apache/zeppelin/pull/4242#issuecomment-934114853
I've heard of the Maven wrapper, but didn't know what the project was for until today. I read the following article about it.
https://www.baeldung.com/maven-wrapper
I am against using the maven wrapper for the following reasons.
1) A Jar is stored in the SCM.
2) I see it as an advantage to have multiple versions in the wild to build the zeppelin project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org