You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by br...@apache.org on 2013/05/08 00:15:52 UTC
svn commit: r1480119 -
/subversion/trunk/subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.c
Author: breser
Date: Tue May 7 22:15:52 2013
New Revision: 1480119
URL: http://svn.apache.org/r1480119
Log:
Fix swig perl bindings on Windows.
* subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.c
(svn_swig_pl_array_to_apr_array_revision_range): Include a return to avoid
Visual Studio erroring out saying that some code paths the function doesn't
return a value.
Modified:
subversion/trunk/subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.c
Modified: subversion/trunk/subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.c?rev=1480119&r1=1480118&r2=1480119&view=diff
==============================================================================
--- subversion/trunk/subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.c (original)
+++ subversion/trunk/subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.c Tue May 7 22:15:52 2013
@@ -303,6 +303,11 @@ const apr_array_header_t *svn_swig_pl_ar
}
croak("must pass a single revision range or a reference to an array of revision ranges");
+
+ /* This return is actually unreachable because of the croak above,
+ * however, Visual Studio's compiler doesn't like if all paths don't have
+ * a return and errors out otherwise. */
+ return NULL;
}
/* element convertors for c -> perl */