You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "leonfin (via GitHub)" <gi...@apache.org> on 2025/11/23 04:30:14 UTC
[PR] GEODE-10526 - IndexTrackingQueryObserver.afterIndexLookup() throws Nu… [geode]
leonfin opened a new pull request, #7960:
URL: https://github.com/apache/geode/pull/7960
NullPointerException when indexMap ThreadLocal is uninitialized in partitioned region queries
<!-- Thank you for submitting a contribution to Apache Geode. -->
<!-- In order to streamline review of your contribution we ask that you
ensure you've taken the following steps. -->
### For all changes, please confirm:
- [X ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? GEODE-10526
- [ X] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? Yes
- [X ] Is your initial contribution a single, squashed commit? Yes
- [X ] Does `gradlew build` run cleanly? Yes
- [X ] Have you written or updated unit tests to verify your changes? yes
- [ X] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GEODE-10526 - IndexTrackingQueryObserver.afterIndexLookup() throws Nu… [geode]
Posted by "JinwooHwang (via GitHub)" <gi...@apache.org>.
JinwooHwang merged PR #7960:
URL: https://github.com/apache/geode/pull/7960
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GEODE-10526 - IndexTrackingQueryObserver.afterIndexLookup() throws Nu… [geode]
Posted by "JinwooHwang (via GitHub)" <gi...@apache.org>.
JinwooHwang commented on PR #7960:
URL: https://github.com/apache/geode/pull/7960#issuecomment-3569986381
Thank you for promptly identifying the defect and delivering an effective remediation, @leonfin. Your timely contribution is greatly appreciated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GEODE-10526 - IndexTrackingQueryObserver.afterIndexLookup() throws Nu… [geode]
Posted by "leonfin (via GitHub)" <gi...@apache.org>.
leonfin commented on PR #7960:
URL: https://github.com/apache/geode/pull/7960#issuecomment-3567471720
@JinwooHwang could you please review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GEODE-10526 - IndexTrackingQueryObserver.afterIndexLookup() throws Nu… [geode]
Posted by "JinwooHwang (via GitHub)" <gi...@apache.org>.
JinwooHwang commented on PR #7960:
URL: https://github.com/apache/geode/pull/7960#issuecomment-3568003712
All verification checks have been initiated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GEODE-10526 - IndexTrackingQueryObserver.afterIndexLookup() throws Nu… [geode]
Posted by "JinwooHwang (via GitHub)" <gi...@apache.org>.
JinwooHwang commented on PR #7960:
URL: https://github.com/apache/geode/pull/7960#issuecomment-3567842610
@leonfin . Excellent fix for a critical edge case!
This properly addresses the NullPointerException in partitioned region queries where afterIndexLookup() can be called without a corresponding beforeIndexLookup() due to distributed execution across threads/nodes.
The fix follows the right principle: diagnostic/observability code (index tracking) should never cause functional failures. By gracefully handling the uninitialized ThreadLocal, queries now succeed even when index tracking data is unavailable.
The added test cases clearly demonstrate both the failure scenario and the fix. Well-documented inline comments explain exactly when this can occur in production.
I appreciate your great work ensuring query reliability!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GEODE-10526 - IndexTrackingQueryObserver.afterIndexLookup() throws Nu… [geode]
Posted by "leonfin (via GitHub)" <gi...@apache.org>.
leonfin commented on PR #7960:
URL: https://github.com/apache/geode/pull/7960#issuecomment-3568747699
@JinwooHwang thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org