You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Jim Apple (Code Review)" <ge...@cloudera.org> on 2017/04/06 00:28:11 UTC

[Impala-ASF-CR](asf-site) Impala and Hive have slightly different SQL they accept. 

Jim Apple has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/6567

Change subject: Impala and Hive have slightly different SQL they accept.
......................................................................

Impala and Hive have slightly different SQL they accept.

https://lists.apache.org/thread.html/ad17fb6e145ecb082c529f2f21b4661ad1047021dd579117635ce501@%3Cdev.impala.apache.org%3E

Change-Id: I4e38dc15c31dbb3e297e1d3f9e8251a1fa22d1a7
---
M index.html
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/6567/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6567
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4e38dc15c31dbb3e297e1d3f9e8251a1fa22d1a7
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@apache.org>

[Impala-ASF-CR](asf-site) Impala and Hive have slightly different SQL they accept.

Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.

Change subject: Impala and Hive have slightly different SQL they accept.
......................................................................


Patch Set 1: Code-Review+2

Yes, that works for me.

Thanks!

-- 
To view, visit http://gerrit.cloudera.org:8080/6567
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e38dc15c31dbb3e297e1d3f9e8251a1fa22d1a7
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Anonymous Coward #290
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR](asf-site) Impala and Hive have slightly different SQL they accept.

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Anonymous Coward #290 has posted comments on this change.

Change subject: Impala and Hive have slightly different SQL they accept.
......................................................................


Patch Set 1:

The issue we (HivePMC) are trying dealing with is there are several entities with 
copies of Hive code, linking to Hive, or both and at the same time claiming 'Apache Hive Compatibility'. 
As I explained 'Apache Hive Compatibility' is not a thing they can assert, 

1. Assuming you are using an unaltered Apache Hive metastore you could say. "Impala stores it's data in Hive Metastore."
2. Assuming you are using an unaltered apache hive server 2 you could say. " Impala's public facing interfaces mirror that of Hive X.Y"
3. You could say, "Impala's SQL dialect is very similar to that of Hive SQL." or "Many Apache Hive queries will run on Impala unaltered", 

First, use Defining Hadoop document as a guideline. Second, as a guideline, imagine Hive was some large commercial database 'DB2orgres 10Gee', you would be hard pressed to find any other entity software claiming compatibility with that thing.

To summarize: I appreciate your rapid response. I do realize it is a tag line so you want to make it 
short and to the point (while of course making Impala sound as awesome as possible). In any case, I do not want to tell you
what to say, use your best judgement. I hope that helps. The changes are appreciated.

-- 
To view, visit http://gerrit.cloudera.org:8080/6567
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e38dc15c31dbb3e297e1d3f9e8251a1fa22d1a7
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Anonymous Coward #290
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR](asf-site) Impala and Hive have slightly different SQL they accept.

Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has submitted this change and it was merged.

Change subject: Impala and Hive have slightly different SQL they accept.
......................................................................


Impala and Hive have slightly different SQL they accept.

https://lists.apache.org/thread.html/ad17fb6e145ecb082c529f2f21b4661ad1047021dd579117635ce501@%3Cdev.impala.apache.org%3E

Change-Id: I4e38dc15c31dbb3e297e1d3f9e8251a1fa22d1a7
Reviewed-on: http://gerrit.cloudera.org:8080/6567
Reviewed-by: Matthew Jacobs <mj...@cloudera.com>
Tested-by: Jim Apple <jb...@apache.org>
---
M index.html
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jim Apple: Verified
  Matthew Jacobs: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/6567
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4e38dc15c31dbb3e297e1d3f9e8251a1fa22d1a7
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Anonymous Coward #290
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>

[Impala-ASF-CR](asf-site) Impala and Hive have slightly different SQL they accept.

Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.

Change subject: Impala and Hive have slightly different SQL they accept.
......................................................................


Patch Set 1:

> Do not use the term 'compatible' or imply it.
 > 
 > https://wiki.apache.org/hadoop/Defining%20Hadoop#Compatibility
 > 
 > Some products have been released that have been described as
 > "compatible" with Hadoop, even though parts of the Hadoop codebase
 > have either been changed or replaced. The Apache\u2122 Hadoop� developer
 > team are not a standards body: they do not qualify such
 > (derivative) works as compatible. Nor do they feel constrained by
 > the requirements of external entities when changing the behavior of
 > Apache Hadoop software or related Apache software.
 > 
 > Nothing is compatible with Apache Hive other than Apache Hive.

Edward, do you have any suggestions on how to say the following succinctly:

"Impala is similar to Hive in a number of ways which enable the two to be used in concert:

1. Impala stores metadata in the HMS in a way that all Hive versions between 2013(?) and March 2017 understand, and the Impala community intends for this to be the case going forward.

2. Impala presents an interface to the world that uses the same API as HS2 version P.Q.R-X.Y.Z, and the Impala community intends for this to be the case going forward.

3. Impala, like Hive versions A.B.C-D.E.F, uses SQL, and there is a large shared subset of SQL they both understand with the same semantics."

-- 
To view, visit http://gerrit.cloudera.org:8080/6567
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e38dc15c31dbb3e297e1d3f9e8251a1fa22d1a7
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Anonymous Coward #290
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR](asf-site) Impala and Hive have slightly different SQL they accept.

Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.

Change subject: Impala and Hive have slightly different SQL they accept.
......................................................................


Patch Set 1:

OK, I think the wording in PS1 is as close as we are going to get. MJ, are you OK with this?

-- 
To view, visit http://gerrit.cloudera.org:8080/6567
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e38dc15c31dbb3e297e1d3f9e8251a1fa22d1a7
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Anonymous Coward #290
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR](asf-site) Impala and Hive have slightly different SQL they accept.

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Anonymous Coward #290 has posted comments on this change.

Change subject: Impala and Hive have slightly different SQL they accept.
......................................................................


Patch Set 1:

Do not use the term 'compatible' or imply it.

https://wiki.apache.org/hadoop/Defining%20Hadoop#Compatibility

Some products have been released that have been described as "compatible" with Hadoop, even though parts of the Hadoop codebase have either been changed or replaced. The Apache\u2122 Hadoop� developer team are not a standards body: they do not qualify such (derivative) works as compatible. Nor do they feel constrained by the requirements of external entities when changing the behavior of Apache Hadoop software or related Apache software.

Nothing is compatible with Apache Hive other than Apache Hive.

-- 
To view, visit http://gerrit.cloudera.org:8080/6567
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e38dc15c31dbb3e297e1d3f9e8251a1fa22d1a7
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Anonymous Coward #290
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR](asf-site) Impala and Hive have slightly different SQL they accept.

Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.

Change subject: Impala and Hive have slightly different SQL they accept.
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6567/1/index.html
File index.html:

PS1, Line 154:  the same
maybe this should be 'compatible'. Technically we have some different metadata, and the ODBC driver is similar but not exactly the same (we just support the HS2 interface, but that's kind of an implementation detail)


-- 
To view, visit http://gerrit.cloudera.org:8080/6567
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e38dc15c31dbb3e297e1d3f9e8251a1fa22d1a7
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR](asf-site) Impala and Hive have slightly different SQL they accept.

Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.

Change subject: Impala and Hive have slightly different SQL they accept.
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6567/1/index.html
File index.html:

PS1, Line 154:  the same
> maybe this should be 'compatible'. Technically we have some different metad
I don't really understand the state of ODBC in Impala.

Do you have a wording in mind that would reflect reality? Would something like "Impala utilizes Hive-compatible metadata and a Hive-compatible ODBC driver" work?


-- 
To view, visit http://gerrit.cloudera.org:8080/6567
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e38dc15c31dbb3e297e1d3f9e8251a1fa22d1a7
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR](asf-site) Impala and Hive have slightly different SQL they accept.

Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.

Change subject: Impala and Hive have slightly different SQL they accept.
......................................................................


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/6567
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e38dc15c31dbb3e297e1d3f9e8251a1fa22d1a7
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Anonymous Coward #290
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No