You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2015/12/15 03:26:45 UTC
Review Request 41386: Logger Module: Add regression test for docker
containerizer logging to sandbox.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41386/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
Bugs: MESOS-4137
https://issues.apache.org/jira/browse/MESOS-4137
Repository: mesos
Description
-------
`ContainerLoggerTest.ROOT_DOCKER_DefaultToSandbox` is a regression test which checks the existing logging behavior, in which the docker executor and command task are both logged to the same file in the sandbox.
Diffs
-----
src/tests/container_logger_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/41386/diff/
Testing
-------
make check (Centos7)
Thanks,
Joseph Wu
Re: Review Request 41386: Logger Module: Add regression test for
docker containerizer logging to sandbox.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41386/#review110488
-----------------------------------------------------------
Patch looks great!
Reviews applied: [41002, 41003, 41004, 41061, 41111, 41166, 41167, 41168, 41169, 41294, 41369, 41370, 41378, 41386]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 15, 2015, 2:26 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41386/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2015, 2:26 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
>
>
> Bugs: MESOS-4137
> https://issues.apache.org/jira/browse/MESOS-4137
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `ContainerLoggerTest.ROOT_DOCKER_DefaultToSandbox` is a regression test which checks the existing logging behavior, in which the docker executor and command task are both logged to the same file in the sandbox.
>
>
> Diffs
> -----
>
> src/tests/container_logger_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41386/diff/
>
>
> Testing
> -------
>
> make check (Centos7)
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 41386: Logger Module: Add regression test for
docker containerizer logging to sandbox.
Posted by Joseph Wu <jo...@mesosphere.io>.
> On Dec. 14, 2015, 8:08 p.m., Timothy Chen wrote:
> > src/tests/container_logger_tests.cpp, line 158
> > <https://reviews.apache.org/r/41386/diff/1/?file=1164291#file1164291line158>
> >
> > Not against adding more tests, but we already have an identical test in the docker containerizer tests
Ah, I did not notice. (`DockerContainerizerTest.ROOT_DOCKER_Logs`, right?)
- Joseph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41386/#review110399
-----------------------------------------------------------
On Dec. 14, 2015, 6:26 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41386/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2015, 6:26 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
>
>
> Bugs: MESOS-4137
> https://issues.apache.org/jira/browse/MESOS-4137
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `ContainerLoggerTest.ROOT_DOCKER_DefaultToSandbox` is a regression test which checks the existing logging behavior, in which the docker executor and command task are both logged to the same file in the sandbox.
>
>
> Diffs
> -----
>
> src/tests/container_logger_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41386/diff/
>
>
> Testing
> -------
>
> make check (Centos7)
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 41386: Logger Module: Add regression test for
docker containerizer logging to sandbox.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41386/#review110399
-----------------------------------------------------------
src/tests/container_logger_tests.cpp (line 158)
<https://reviews.apache.org/r/41386/#comment170228>
Not against adding more tests, but we already have an identical test in the docker containerizer tests
- Timothy Chen
On Dec. 15, 2015, 2:26 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41386/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2015, 2:26 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
>
>
> Bugs: MESOS-4137
> https://issues.apache.org/jira/browse/MESOS-4137
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `ContainerLoggerTest.ROOT_DOCKER_DefaultToSandbox` is a regression test which checks the existing logging behavior, in which the docker executor and command task are both logged to the same file in the sandbox.
>
>
> Diffs
> -----
>
> src/tests/container_logger_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41386/diff/
>
>
> Testing
> -------
>
> make check (Centos7)
>
>
> Thanks,
>
> Joseph Wu
>
>