You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/08/13 11:43:24 UTC

[GitHub] taliesinb commented on a change in pull request #12064: Allow stop of arange to be inferred from dims.

taliesinb commented on a change in pull request #12064: Allow stop of arange to be inferred from dims.
URL: https://github.com/apache/incubator-mxnet/pull/12064#discussion_r209578617
 
 

 ##########
 File path: src/operator/tensor/init_op.h
 ##########
 @@ -471,6 +473,11 @@ inline bool RangeShape(const nnvm::NodeAttrs& attrs,
     << "Range does not support step=0, received " << param.step;
   CHECK(param.repeat > 0)
     << "Range only supports repeat > 0, received " << param.repeat;
+  if (param.start == param.stop.value()) {
 
 Review comment:
   @szha what's the best way to proceed? it seems that everyone is very busy, so doing a discussion over PR comments might take a very long time. ideal would be some kind of realtime chat where we can discuss design alternatives and quickly come to a consensus. is there such a forum?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services