[jira] [Commented] (FLINK-8864) Add CLI query history in SQL Client

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-8864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16532093#comment-16532093 ] 

ASF GitHub Bot commented on FLINK-8864:
---------------------------------------

GitHub user snuyanzin opened a pull request:

    https://github.com/apache/flink/pull/6250

    [FLINK-8864] added command history

    ## What is the purpose of the change
    
    *This PR adds history for sql queries/sqlclient commands*
    
    
    ## Brief change log
    
      - *Added history file for commands*
    
    ## Verifying this change
      - *Manually verification*
    
    1. run sql-sclient, perform whatever queries, close close client
    2. run sql-client again, check history (up, down, forward and backward searches via ctrl+s, ctrl+r)
    
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/snuyanzin/flink FLINK_8864

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6250.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6250
    
----
commit 08ee97e1c4b0274b8508e6cfb6f47db1e33212eb
Author: snuyanzin <sn...@...>
Date:   2018-07-04T00:30:14Z

    [FLINK-8864] added command history

----


> Add CLI query history in SQL Client
> -----------------------------------
>
>                 Key: FLINK-8864
>                 URL: https://issues.apache.org/jira/browse/FLINK-8864
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API &amp; SQL
>            Reporter: Timo Walther
>            Assignee: Sergey Nuyanzin
>            Priority: Major
>              Labels: pull-request-available
>
> This issue is a subtask of part two "Full Embedded SQL Client" of the implementation plan mentioned in [FLIP-24|https://cwiki.apache.org/confluence/display/FLINK/FLIP-24+-+SQL+Client].
> It would be great to have the possibility of persisting the CLI's query history. Such that queries can be reused when the CLI Client is started again. Also a search feature as it is offered by terminals would be good.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)