You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fluss.apache.org by "swuferhong (via GitHub)" <gi...@apache.org> on 2026/04/23 11:14:27 UTC

[PR] [server] Remove CDC log metrics from PK table write path to avoid dou… [fluss]

swuferhong opened a new pull request, #3177:
URL: https://github.com/apache/fluss/pull/3177

   …ble counting
   
   <!--
   *Thank you very much for contributing to Fluss - we are happy that you want to help us improve Fluss. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [GitHub issue](https://github.com/apache/fluss/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no issue.
   
     - Name the pull request in the format "[component] Title of the pull request", where *[component]* should be replaced by the name of the component being changed. Typically, this corresponds to the component label assigned to the issue (e.g., [kv], [log], [client], [flink]). Skip *[component]* if you are unsure about which is the best component.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
   
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes.
   
     - Each pull request should address only one issue, not mix up code from multiple issues.
   
     - **Generative AI disclosure:** Indicate whether generative AI tools were used in authoring this PR. If yes, specify the tool below.
       - [ ] No generative AI tools used
       - [ ] Yes (please specify the tool below)
   
   **(The sections below can be removed for hotfixes or typos)**
   -->
   
   <!--
   Generated-by: [Tool Name and Version] following [the guidelines](https://github.com/apache/fluss/blob/main/AGENTS.md)
   -->
   
   ### Purpose
   
   <!-- Linking this pull request to the issue -->
   Linked issue: close #3176 
   
   <!-- What is the purpose of the change -->
   
   For primary key tables, `putToLocalKv()` was incrementing both KV and CDC
   log metrics (messagesIn, bytesIn), causing the table-level throughput to
   report roughly 2x the actual write volume.
   
   The CDC log is an internal mechanism for changelog replication, and its
   metrics should not be counted in the user-facing table-level aggregation,
   as this is confusing for users monitoring PK table performance.
   
   ### Brief change log
   
   <!-- Please describe the changes made in this pull request and explain how they address the issue -->
   
   ### Tests
   
   <!-- List UT and IT cases to verify this change -->
   
   ### API and Format
   
   <!-- Does this change affect API or storage format -->
   
   ### Documentation
   
   <!-- Does this change introduce a new feature -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [server] Remove CDC log metrics from PK table write path to avoid dou… [fluss]

Posted by "swuferhong (via GitHub) via issues" <is...@fluss.apache.org>.
swuferhong closed pull request #3177: [server] Remove CDC log metrics from PK table write path to avoid dou…
URL: https://github.com/apache/fluss/pull/3177


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [server] Remove CDC log metrics from PK table write path to avoid dou… [fluss]

Posted by "binary-signal (via GitHub)" <gi...@apache.org>.
binary-signal commented on PR #3177:
URL: https://github.com/apache/fluss/pull/3177#issuecomment-4309792006

                                                                                                    The metrics are tracking different things intentionally:                                                                                                                                                                                                                              
                                                                                                                                                                                                                                                                                           
   lines 1301-1306:                                                                                                                                                                                                                                                              
   ```java
     // metric for kv                                                                                                                                                                                                                                                                      
     tableMetrics.incKvMessageIn(entry.getValue().getRecordCount());  // KV write volume                                                                                                                                                                                                   
     tableMetrics.incKvBytesIn(entry.getValue().sizeInBytes());        // KV write bytes
     // metric for cdc log of kv                                                                                                                                                                                                                                                           
     tableMetrics.incLogBytesIn(appendInfo.validBytes());              // CDC log volume                                                                                                                                                                                                   
     tableMetrics.incLogMessageIn(appendInfo.numMessages());           // CDC log messages                                                                                                                                                                                                 
   ```                                                                                                                                                                                                                                                                                        
   These are separate metric counters: KvBytesIn vs LogBytesIn, KvMessageIn vs LogMessageIn. They're not double-counting into the same metric. The CDC log is real I/O that actually happens which it gets written, replicated to followers, and consumed by downstream (Flink connectors, lake tiering etc). 
   
   Hiding that from metrics means:                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                
     1. Replication monitoring breaks - followers fetch from the CDC log. If you don't track its volume, you can't reason about replication lag or bandwidth.                                                                                                                              
     2. Storage accounting becomes wrong, the CDC log consumes real disk space and network. Omitting it from metrics hides actual resource usage.
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                 
                                                                                                                                                                                                                                                                                           
   Compare with appendToLocalLog() at line 1254 — for log-only tables, LogBytesIn tracks the user-facing write. For PK tables, KvBytesIn tracks the user-facing write, and LogBytesIn tracks the internal CDC consequence. Both are useful; they just need to be interpreted differently.  
      


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org