You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by GitBox <gi...@apache.org> on 2023/01/09 20:50:51 UTC
[GitHub] [datasketches-cpp] jbapple opened a new issue, #328: std::iterator is deprecated; replace it
jbapple opened a new issue, #328:
URL: https://github.com/apache/datasketches-cpp/issues/328
`std::iterator` is deprecated; see https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2016/p0174r2.html#2.1. It is used ten times in datasketches-cpp:
```
$ git grep -c std::iterator
fi/include/reverse_purge_hash_map.hpp:1
hll/include/HllArray.hpp:1
hll/include/coupon_iterator.hpp:1
kll/include/kll_sketch.hpp:1
quantiles/include/quantiles_sketch.hpp:1
req/include/req_sketch.hpp:1
sampling/include/var_opt_sketch.hpp:2
theta/include/theta_update_sketch_base.hpp:2
```
Replace these inheritances with explicit using/typedef declarations in each class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] jmalkin commented on issue #328: std::iterator is deprecated; replace it
Posted by "jmalkin (via GitHub)" <gi...@apache.org>.
jmalkin commented on issue #328:
URL: https://github.com/apache/datasketches-cpp/issues/328#issuecomment-1407780312
@AlexanderSaydakov There's something going with theta sketches that makes things fail if I just remove std::iterator and define the 5 necessary types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] jbapple commented on issue #328: std::iterator is deprecated; replace it
Posted by "jbapple (via GitHub)" <gi...@apache.org>.
jbapple commented on issue #328:
URL: https://github.com/apache/datasketches-cpp/issues/328#issuecomment-1407271907
You might try with Clang 16 using C++20 and libc++.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] jmalkin commented on issue #328: std::iterator is deprecated; replace it
Posted by "jmalkin (via GitHub)" <gi...@apache.org>.
jmalkin commented on issue #328:
URL: https://github.com/apache/datasketches-cpp/issues/328#issuecomment-1407248424
I think some of our existing tasks are wrapping up, so with luck we'll be able to take this up shortly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] jmalkin closed issue #328: std::iterator is deprecated; replace it
Posted by "jmalkin (via GitHub)" <gi...@apache.org>.
jmalkin closed issue #328: std::iterator is deprecated; replace it
URL: https://github.com/apache/datasketches-cpp/issues/328
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] jmalkin commented on issue #328: std::iterator is deprecated; replace it
Posted by GitBox <gi...@apache.org>.
jmalkin commented on issue #328:
URL: https://github.com/apache/datasketches-cpp/issues/328#issuecomment-1377937269
Not sure exactly when we'll get to this, but this is a good point. We only target C++11, which is prior to deprecation, but these changes won't break compatibility with that version. Definitely worth doing as there's an upside for future compatibility with no obvious drawbacks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] jmalkin commented on issue #328: std::iterator is deprecated; replace it
Posted by "jmalkin (via GitHub)" <gi...@apache.org>.
jmalkin commented on issue #328:
URL: https://github.com/apache/datasketches-cpp/issues/328#issuecomment-1414154449
And it has been merged. Might not be perfect -- we welcome any feedback -- but it's certainly better than before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] jmalkin commented on issue #328: std::iterator is deprecated; replace it
Posted by "jmalkin (via GitHub)" <gi...@apache.org>.
jmalkin commented on issue #328:
URL: https://github.com/apache/datasketches-cpp/issues/328#issuecomment-1412428374
#342 will address this. It might need some tweaks first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] jmalkin commented on issue #328: std::iterator is deprecated; replace it
Posted by "jmalkin (via GitHub)" <gi...@apache.org>.
jmalkin commented on issue #328:
URL: https://github.com/apache/datasketches-cpp/issues/328#issuecomment-1407271463
I don't seem to get g++ or clang++ to complain about this even if I use c++17. Not trying to suggest that it's not an issue, just that I'd expected to be complained at. Weird.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] jmalkin commented on issue #328: std::iterator is deprecated; replace it
Posted by "jmalkin (via GitHub)" <gi...@apache.org>.
jmalkin commented on issue #328:
URL: https://github.com/apache/datasketches-cpp/issues/328#issuecomment-1533726955
As a final follow-up, this has now been Officially Released.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org