[GitHub] williaster opened a new pull request #5355: get rid of global `notify`

[GitBox <gi...@apache.org>]

williaster opened a new pull request #5355: get rid of global `notify`
URL: https://github.com/apache/incubator-superset/pull/5355
 
 
   This PR is necessary to move forward with lazy loading / webpack 4 / bundle optimization upgrade because globals break split bundles.
   
   I removed all instances of the `notify.xxx()` calls and instead used the message toast components + redux tree. this was way more painful that it needed, we should never use globals for anything even if they are "easier."
   
   @mistercrunch @michellethomas @graceguo-supercat 
   
   I tested sqllab, explore, dashboard v1, and dashboard v2 apps.
   
   **TODO**
   - [ ] convert python flash messages to toasts

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org