You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2021/02/02 07:30:22 UTC
[GitHub] [cassandra-dtest] bereng opened a new pull request #121: Cassandra 16296 ccm bug
bereng opened a new pull request #121:
URL: https://github.com/apache/cassandra-dtest/pull/121
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] ekaterinadimitrova2 commented on a change in pull request #121: Cassandra 16296 ccm bug
Posted by GitBox <gi...@apache.org>.
ekaterinadimitrova2 commented on a change in pull request #121:
URL: https://github.com/apache/cassandra-dtest/pull/121#discussion_r570631920
##########
File path: replace_address_test.py
##########
@@ -78,6 +78,8 @@ def _do_replace(self, same_address=False, jvm_option='replace_address',
extra_jvm_args=None):
if replace_address is None:
replace_address = self.replaced_node.address()
+ if data_center is None:
+ data_center = "dc1"
Review comment:
Why "dc1" was not added deterministically everywhere? What do I miss?
##########
File path: replace_address_test.py
##########
@@ -78,6 +78,8 @@ def _do_replace(self, same_address=False, jvm_option='replace_address',
extra_jvm_args=None):
if replace_address is None:
replace_address = self.replaced_node.address()
+ if data_center is None:
+ data_center = "dc1"
Review comment:
Sorry, I just saw this change after I pressed approve
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] bereng commented on pull request #121: Cassandra 16296 ccm bug
Posted by GitBox <gi...@apache.org>.
bereng commented on pull request #121:
URL: https://github.com/apache/cassandra-dtest/pull/121#issuecomment-773858179
@ekaterinadimitrova2 or @adelapena we'll need dtest runs for all versions. Would you be so kind to do that for me on jenkins please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] bereng commented on a change in pull request #121: Cassandra 16296 ccm bug
Posted by GitBox <gi...@apache.org>.
bereng commented on a change in pull request #121:
URL: https://github.com/apache/cassandra-dtest/pull/121#discussion_r570735534
##########
File path: replace_address_test.py
##########
@@ -78,6 +78,8 @@ def _do_replace(self, same_address=False, jvm_option='replace_address',
extra_jvm_args=None):
if replace_address is None:
replace_address = self.replaced_node.address()
+ if data_center is None:
+ data_center = "dc1"
Review comment:
Bc there is only one multi-dc test. The others work ok as they fallback to the default 'dc1' hard coded in the default topology file. But on multi-dc we need to be explicit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] bereng commented on pull request #121: Cassandra 16296 ccm bug
Posted by GitBox <gi...@apache.org>.
bereng commented on pull request #121:
URL: https://github.com/apache/cassandra-dtest/pull/121#issuecomment-773858179
@ekaterinadimitrova2 or @adelapena we'll need dtest runs for all versions. Would you be so kind to do that for me on jenkins please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] bereng commented on pull request #121: Cassandra 16296 ccm bug
Posted by GitBox <gi...@apache.org>.
bereng commented on pull request #121:
URL: https://github.com/apache/cassandra-dtest/pull/121#issuecomment-771459685
CI [j8](https://app.circleci.com/pipelines/github/bereng/cassandra/207/workflows/e6f08457-290d-4539-83c1-bba82618a0cb): LGTM with some flakys
CI [j11](https://app.circleci.com/pipelines/github/bereng/cassandra/207/workflows/fc1f2a9c-29a4-42a9-b581-64252430eef0): Weird unit failure that passes locally but should be unrelated, consistency test passes locally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] ekaterinadimitrova2 commented on pull request #121: Cassandra 16296 ccm bug
Posted by GitBox <gi...@apache.org>.
ekaterinadimitrova2 commented on pull request #121:
URL: https://github.com/apache/cassandra-dtest/pull/121#issuecomment-773686020
I think the failing tests are already known flaky and not related to the patch which seems straightforward to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] bereng commented on pull request #121: Cassandra 16296 ccm bug
Posted by GitBox <gi...@apache.org>.
bereng commented on pull request #121:
URL: https://github.com/apache/cassandra-dtest/pull/121#issuecomment-772315013
After the latest change in CCM:
- [j11](https://app.circleci.com/pipelines/github/bereng/cassandra/208/workflows/1c918162-242d-4a26-b4b1-882c4893e6d2): The unit tests are flaky, pass locally and can't be related. The dtest passes locally.
- [j8](https://app.circleci.com/pipelines/github/bereng/cassandra/208/workflows/ac30f2dd-369e-4ccc-82ba-1801b5149bed): Same as above.
This latest run had more failures but given the unit tests were flaky as well I think it lgtm and I am going to attribute it to the env.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] adelapena commented on pull request #121: Cassandra 16296 ccm bug
Posted by GitBox <gi...@apache.org>.
adelapena commented on pull request #121:
URL: https://github.com/apache/cassandra-dtest/pull/121#issuecomment-774029177
Running dtests:
* [2.1](https://ci-cassandra.apache.org/view/all/job/Cassandra-devbranch-dtest/370/)
* [2.2](https://ci-cassandra.apache.org/view/all/job/Cassandra-devbranch-dtest/371/)
* [3.0](https://ci-cassandra.apache.org/view/all/job/Cassandra-devbranch-dtest/372/)
* [3.11](https://ci-cassandra.apache.org/view/all/job/Cassandra-devbranch-dtest/373/)
* [trunk](https://ci-cassandra.apache.org/view/all/job/Cassandra-devbranch-dtest/374/)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] bereng closed pull request #121: Cassandra 16296 ccm bug
Posted by GitBox <gi...@apache.org>.
bereng closed pull request #121:
URL: https://github.com/apache/cassandra-dtest/pull/121
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] ekaterinadimitrova2 commented on pull request #121: Cassandra 16296 ccm bug
Posted by GitBox <gi...@apache.org>.
ekaterinadimitrova2 commented on pull request #121:
URL: https://github.com/apache/cassandra-dtest/pull/121#issuecomment-773686020
I think the failing tests are already known flaky and not related to the patch which seems straightforward to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] bereng commented on pull request #121: Cassandra 16296 ccm bug
Posted by GitBox <gi...@apache.org>.
bereng commented on pull request #121:
URL: https://github.com/apache/cassandra-dtest/pull/121#issuecomment-771459685
CI [j8](https://app.circleci.com/pipelines/github/bereng/cassandra/207/workflows/e6f08457-290d-4539-83c1-bba82618a0cb): LGTM with some flakys
CI [j11](https://app.circleci.com/pipelines/github/bereng/cassandra/207/workflows/fc1f2a9c-29a4-42a9-b581-64252430eef0): Weird unit failure that passes locally but should be unrelated, consistency test passes locally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] ekaterinadimitrova2 commented on a change in pull request #121: Cassandra 16296 ccm bug
Posted by GitBox <gi...@apache.org>.
ekaterinadimitrova2 commented on a change in pull request #121:
URL: https://github.com/apache/cassandra-dtest/pull/121#discussion_r570632112
##########
File path: replace_address_test.py
##########
@@ -78,6 +78,8 @@ def _do_replace(self, same_address=False, jvm_option='replace_address',
extra_jvm_args=None):
if replace_address is None:
replace_address = self.replaced_node.address()
+ if data_center is None:
+ data_center = "dc1"
Review comment:
Sorry, I just saw this change after I pressed approve
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] bereng commented on a change in pull request #121: Cassandra 16296 ccm bug
Posted by GitBox <gi...@apache.org>.
bereng commented on a change in pull request #121:
URL: https://github.com/apache/cassandra-dtest/pull/121#discussion_r570735534
##########
File path: replace_address_test.py
##########
@@ -78,6 +78,8 @@ def _do_replace(self, same_address=False, jvm_option='replace_address',
extra_jvm_args=None):
if replace_address is None:
replace_address = self.replaced_node.address()
+ if data_center is None:
+ data_center = "dc1"
Review comment:
Bc there is only one multi-dc test. The others work ok as they fallback to the default 'dc1' hard coded in the default topology file. But on multi-dc we need to be explicit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] ekaterinadimitrova2 commented on a change in pull request #121: Cassandra 16296 ccm bug
Posted by GitBox <gi...@apache.org>.
ekaterinadimitrova2 commented on a change in pull request #121:
URL: https://github.com/apache/cassandra-dtest/pull/121#discussion_r570631920
##########
File path: replace_address_test.py
##########
@@ -78,6 +78,8 @@ def _do_replace(self, same_address=False, jvm_option='replace_address',
extra_jvm_args=None):
if replace_address is None:
replace_address = self.replaced_node.address()
+ if data_center is None:
+ data_center = "dc1"
Review comment:
Why "dc1" was not added deterministically everywhere? What do I miss?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] bereng commented on pull request #121: Cassandra 16296 ccm bug
Posted by GitBox <gi...@apache.org>.
bereng commented on pull request #121:
URL: https://github.com/apache/cassandra-dtest/pull/121#issuecomment-774910171
LGTM to my untrained eye on knows offenders for previous versions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org