You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/07/04 04:47:10 UTC

[GitHub] [kafka] yws-tracy opened a new pull request #10972: remove useless code that assign null value to instance field during …

yws-tracy opened a new pull request #10972:
URL: https://github.com/apache/kafka/pull/10972


   remove useless code that assign null value to instance field in construting NetworkReceive instance, becase the default value of instance field is null, there is no need to assign null value again


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] yws-tracy edited a comment on pull request #10972: remove useless code that assign null value to instance field during …

Posted by GitBox <gi...@apache.org>.
yws-tracy edited a comment on pull request #10972:
URL: https://github.com/apache/kafka/pull/10972#issuecomment-874559779


   it's final so it needs to assign null otherwise compiler can not run correctly,  whereas, why this need final? what's the advantages?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] yws-tracy commented on pull request #10972: remove useless code that assign null value to instance field during …

Posted by GitBox <gi...@apache.org>.
yws-tracy commented on pull request #10972:
URL: https://github.com/apache/kafka/pull/10972#issuecomment-874559779


   it's final so it needs to assign null otherwise compiler can not run correctly


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] yws-tracy edited a comment on pull request #10972: remove useless code that assign null value to instance field during …

Posted by GitBox <gi...@apache.org>.
yws-tracy edited a comment on pull request #10972:
URL: https://github.com/apache/kafka/pull/10972#issuecomment-874559779


   it's final so it needs to assign null otherwise compiler can not run correctly,  whereas, why this need final? what's the advantages?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] yws-tracy commented on pull request #10972: remove useless code that assign null value to instance field during …

Posted by GitBox <gi...@apache.org>.
yws-tracy commented on pull request #10972:
URL: https://github.com/apache/kafka/pull/10972#issuecomment-874559779


   it's final so it needs to assign null otherwise compiler can not run correctly


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org