You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "mistercrunch (via GitHub)" <gi...@apache.org> on 2023/06/14 18:19:53 UTC
[GitHub] [superset] mistercrunch opened a new pull request, #24403: chore: cleanup sqlalchemy warnings
mistercrunch opened a new pull request, #24403:
URL: https://github.com/apache/superset/pull/24403
Fixing these noisy warnings when using the superset cli
```
/Users/max/.pyenv/versions/3.9.16/envs/superset/lib/python3.9/site-packages/flask_appbuilder/models/sqla/interface.py:67: SAWarning: relationship 'Tag.objects' will copy column tag.id to column tagged_object.tag_id, which conflicts with relationship(s): 'SavedQuery.tags' (copies tag.id to tagged_object.tag_id). If this is not the intention, consider if these relationships should be linked with back_populates, or if viewonly=True should be applied to one or more if they are read-only. For the less common case that foreign key constraints are partially overlapping, the orm.foreign() annotation can be used to isolate the columns that should be written towards. To silence this warning, add the parameter 'overlaps="tags"' to the 'Tag.objects' relationship. (Background on this error at: https://sqlalche.me/e/14/qzyx)
for prop in class_mapper(obj).iterate_properties:
/Users/max/.pyenv/versions/3.9.16/envs/superset/lib/python3.9/site-packages/flask_appbuilder/models/sqla/interface.py:67: SAWarning: relationship 'TaggedObject.tag' will copy column tag.id to column tagged_object.tag_id, which conflicts with relationship(s): 'SavedQuery.tags' (copies tag.id to tagged_object.tag_id). If this is not the intention, consider if these relationships should be linked with back_populates, or if viewonly=True should be applied to one or more if they are read-only. For the less common case that foreign key constraints are partially overlapping, the orm.foreign() annotation can be used to isolate the columns that should be written towards. To silence this warning, add the parameter 'overlaps="tags"' to the 'TaggedObject.tag' relationship. (Background on this error at: https://sqlalche.me/e/14/qzyx)
for prop in class_mapper(obj).iterate_properties:
/Users/max/.pyenv/versions/3.9.16/envs/superset/lib/python3.9/site-packages/flask_appbuilder/models/sqla/interface.py:67: SAWarning: relationship 'Slice.tags' will copy column slices.id to column tagged_object.object_id, which conflicts with relationship(s): 'SavedQuery.tags' (copies saved_query.id to tagged_object.object_id). If this is not the intention, consider if these relationships should be linked with back_populates, or if viewonly=True should be applied to one or more if they are read-only. For the less common case that foreign key constraints are partially overlapping, the orm.foreign() annotation can be used to isolate the columns that should be written towards. To silence this warning, add the parameter 'overlaps="tags"' to the 'Slice.tags' relationship. (Background on this error at: https://sqlalche.me/e/14/qzyx)
for prop in class_mapper(obj).iterate_properties:
/Users/max/.pyenv/versions/3.9.16/envs/superset/lib/python3.9/site-packages/flask_appbuilder/models/sqla/interface.py:67: SAWarning: relationship 'Slice.tags' will copy column tag.id to column tagged_object.tag_id, which conflicts with relationship(s): 'SavedQuery.tags' (copies tag.id to tagged_object.tag_id), 'Tag.objects' (copies tag.id to tagged_object.tag_id), 'TaggedObject.tag' (copies tag.id to tagged_object.tag_id). If this is not the intention, consider if these relationships should be linked with back_populates, or if viewonly=True should be applied to one or more if they are read-only. For the less common case that foreign key constraints are partially overlapping, the orm.foreign() annotation can be used to isolate the columns that should be written towards. To silence this warning, add the parameter 'overlaps="objects,tag,tags"' to the 'Slice.tags' relationship. (Background on this error at: https://sqlalche.me/e/14/qzyx)
for prop in class_mapper(obj).iterate_properties:
/Users/max/.pyenv/versions/3.9.16/envs/superset/lib/python3.9/site-packages/flask_appbuilder/models/sqla/interface.py:67: SAWarning: relationship 'SqlaTable.slices' will copy column tables.id to column slices.datasource_id, which conflicts with relationship(s): 'Slice.table' (copies tables.id to slices.datasource_id). If this is not the intention, consider if these relationships should be linked with back_populates, or if viewonly=True should be applied to one or more if they are read-only. For the less common case that foreign key constraints are partially overlapping, the orm.foreign() annotation can be used to isolate the columns that should be written towards. To silence this warning, add the parameter 'overlaps="table"' to the 'SqlaTable.slices' relationship. (Background on this error at: https://sqlalche.me/e/14/qzyx)
for prop in class_mapper(obj).iterate_properties:
/Users/max/.pyenv/versions/3.9.16/envs/superset/lib/python3.9/site-packages/flask_appbuilder/models/sqla/interface.py:67: SAWarning: relationship 'Dashboard.tags' will copy column dashboards.id to column tagged_object.object_id, which conflicts with relationship(s): 'SavedQuery.tags' (copies saved_query.id to tagged_object.object_id), 'Slice.tags' (copies slices.id to tagged_object.object_id). If this is not the intention, consider if these relationships should be linked with back_populates, or if viewonly=True should be applied to one or more if they are read-only. For the less common case that foreign key constraints are partially overlapping, the orm.foreign() annotation can be used to isolate the columns that should be written towards. To silence this warning, add the parameter 'overlaps="tags,tags"' to the 'Dashboard.tags' relationship. (Background on this error at: https://sqlalche.me/e/14/qzyx)
for prop in class_mapper(obj).iterate_properties:
/Users/max/.pyenv/versions/3.9.16/envs/superset/lib/python3.9/site-packages/flask_appbuilder/models/sqla/interface.py:67: SAWarning: relationship 'Dashboard.tags' will copy column tag.id to column tagged_object.tag_id, which conflicts with relationship(s): 'SavedQuery.tags' (copies tag.id to tagged_object.tag_id), 'Slice.tags' (copies tag.id to tagged_object.tag_id), 'Tag.objects' (copies tag.id to tagged_object.tag_id), 'TaggedObject.tag' (copies tag.id to tagged_object.tag_id). If this is not the intention, consider if these relationships should be linked with back_populates, or if viewonly=True should be applied to one or more if they are read-only. For the less common case that foreign key constraints are partially overlapping, the orm.foreign() annotation can be used to isolate the columns that should be written towards. To silence this warning, add the parameter 'overlaps="objects,tag,tags,tags"' to the 'Dashboard.tags' relationship. (Background on this error at: https://s
qlalche.me/e/14/qzyx)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24403: chore: cleanup sqlalchemy warnings
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24403:
URL: https://github.com/apache/superset/pull/24403#issuecomment-1591786339
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24403?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24403](https://app.codecov.io/gh/apache/superset/pull/24403?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (657562a) into [master](https://app.codecov.io/gh/apache/superset/commit/c69634df279054de0eb145bdcc796cb8fdd26dd8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (c69634d) will **decrease** coverage by `10.94%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 657562a differs from pull request most recent head 4010a41. Consider uploading reports for the commit 4010a41 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24403 +/- ##
===========================================
- Coverage 68.90% 57.97% -10.94%
===========================================
Files 1903 1903
Lines 74070 74071 +1
Branches 8110 8110
===========================================
- Hits 51041 42943 -8098
- Misses 20917 29016 +8099
Partials 2112 2112
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| postgres | `?` | |
| presto | `53.79% <100.00%> (+<0.01%)` | :arrow_up: |
| python | `60.50% <100.00%> (-22.72%)` | :arrow_down: |
| unit | `54.56% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24403?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [superset/connectors/base/models.py](https://app.codecov.io/gh/apache/superset/pull/24403?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `65.31% <ø> (-22.26%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://app.codecov.io/gh/apache/superset/pull/24403?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `74.60% <ø> (-15.84%)` | :arrow_down: |
| [superset/models/dashboard.py](https://app.codecov.io/gh/apache/superset/pull/24403?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `47.89% <ø> (-31.04%)` | :arrow_down: |
| [superset/models/slice.py](https://app.codecov.io/gh/apache/superset/pull/24403?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvbW9kZWxzL3NsaWNlLnB5) | `58.01% <ø> (-29.72%)` | :arrow_down: |
| [superset/models/sql\_lab.py](https://app.codecov.io/gh/apache/superset/pull/24403?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF9sYWIucHk=) | `75.10% <ø> (-4.42%)` | :arrow_down: |
| [superset/tags/models.py](https://app.codecov.io/gh/apache/superset/pull/24403?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvdGFncy9tb2RlbHMucHk=) | `56.09% <100.00%> (-37.35%)` | :arrow_down: |
... and [295 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24403/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mistercrunch merged pull request #24403: chore: cleanup sqlalchemy warnings
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch merged PR #24403:
URL: https://github.com/apache/superset/pull/24403
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #24403: chore: cleanup sqlalchemy warnings
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #24403:
URL: https://github.com/apache/superset/pull/24403#issuecomment-1591852113
Looks like some tests are failing. I restarted them just in case we get lucky, but I think they're real and not just flaking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mistercrunch commented on pull request #24403: chore: cleanup sqlalchemy warnings
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on PR #24403:
URL: https://github.com/apache/superset/pull/24403#issuecomment-1595337183
re-running CI after a re-base, pretty sure I was getting false negatives before...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org