You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Nitay Joffe (JIRA)" <ji...@apache.org> on 2009/01/26 20:18:00 UTC

[jira] Created: (ZOOKEEPER-279) Variable expansion in zoo.cfg

Variable expansion in zoo.cfg
-----------------------------

                 Key: ZOOKEEPER-279
                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-279
             Project: Zookeeper
          Issue Type: Improvement
            Reporter: Nitay Joffe
            Priority: Minor


We would like to define certain parts of ZooKeeper's configuration using variables that get substituted. For example, we want the ZooKeeper quorum to be able to use a dataDir configured per user. In other words, something like:

tickTime=2000
dataDir=/tmp/zookeeper-${user.name}
clientPort=2181
initLimit=5
syncLimit=2
server.1=zoo1:2888:3888
server.2=zoo2:2888:3888
server.3=zoo3:2888:3888

I think Java already has a system for configuration that allows something like this using Properties?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-279) Variable expansion in zoo.cfg

Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667361#action_12667361 ] 

Nitay Joffe commented on ZOOKEEPER-279:
---------------------------------------

More specifically, we are trying to make zoo.cfg play nicely with hadoop/hbase conf so that we can interpolate things like hadoop.tmp.dir as the default for the ZK dataDir.

> Variable expansion in zoo.cfg
> -----------------------------
>
>                 Key: ZOOKEEPER-279
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-279
>             Project: Zookeeper
>          Issue Type: Improvement
>            Reporter: Nitay Joffe
>            Priority: Minor
>
> We would like to define certain parts of ZooKeeper's configuration using variables that get substituted. For example, we want the ZooKeeper quorum to be able to use a dataDir configured per user. In other words, something like:
> tickTime=2000
> dataDir=/tmp/zookeeper-${user.name}
> clientPort=2181
> initLimit=5
> syncLimit=2
> server.1=zoo1:2888:3888
> server.2=zoo2:2888:3888
> server.3=zoo3:2888:3888
> I think Java already has a system for configuration that allows something like this using Properties?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-279) Allow specialization of quorum config parsing (e.g. variable expansion in zoo.cfg)

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-279:
-----------------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

Committed revision 750597. (3.1 branch)
Committed revision 750599. (mainline - 3.2)

Thanks Jean-Daniel!


> Allow specialization of quorum config parsing (e.g. variable expansion in zoo.cfg)
> ----------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-279
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-279
>             Project: Zookeeper
>          Issue Type: Improvement
>    Affects Versions: 3.1.0
>            Reporter: Nitay Joffe
>            Assignee: Jean-Daniel Cryans
>            Priority: Minor
>             Fix For: 3.1.1, 3.2.0
>
>         Attachments: HBaseQPC.java, zookeeper-279.patch, zookeeper-279.patch
>
>
> We would like to define certain parts of ZooKeeper's configuration using variables that get substituted. For example, we want the ZooKeeper quorum to be able to use a dataDir configured per user. In other words, something like:
> tickTime=2000
> dataDir=/tmp/zookeeper-${user.name}
> clientPort=2181
> initLimit=5
> syncLimit=2
> server.1=zoo1:2888:3888
> server.2=zoo2:2888:3888
> server.3=zoo3:2888:3888
> I think Java already has a system for configuration that allows something like this using Properties?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-279) Variable expansion in zoo.cfg

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-279:
-----------------------------------

    Fix Version/s: 3.2.0
                   3.1.1

> Variable expansion in zoo.cfg
> -----------------------------
>
>                 Key: ZOOKEEPER-279
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-279
>             Project: Zookeeper
>          Issue Type: Improvement
>    Affects Versions: 3.1.0
>            Reporter: Nitay Joffe
>            Priority: Minor
>             Fix For: 3.1.1, 3.2.0
>
>         Attachments: HBaseQPC.java, zookeeper-279.patch
>
>
> We would like to define certain parts of ZooKeeper's configuration using variables that get substituted. For example, we want the ZooKeeper quorum to be able to use a dataDir configured per user. In other words, something like:
> tickTime=2000
> dataDir=/tmp/zookeeper-${user.name}
> clientPort=2181
> initLimit=5
> syncLimit=2
> server.1=zoo1:2888:3888
> server.2=zoo2:2888:3888
> server.3=zoo3:2888:3888
> I think Java already has a system for configuration that allows something like this using Properties?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-279) Variable expansion in zoo.cfg

Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Daniel Cryans updated ZOOKEEPER-279:
-----------------------------------------

    Attachment: zookeeper-279.patch

A patch against trunk that enables foreign configurations into QuorumPeerConfig.

> Variable expansion in zoo.cfg
> -----------------------------
>
>                 Key: ZOOKEEPER-279
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-279
>             Project: Zookeeper
>          Issue Type: Improvement
>            Reporter: Nitay Joffe
>            Priority: Minor
>         Attachments: zookeeper-279.patch
>
>
> We would like to define certain parts of ZooKeeper's configuration using variables that get substituted. For example, we want the ZooKeeper quorum to be able to use a dataDir configured per user. In other words, something like:
> tickTime=2000
> dataDir=/tmp/zookeeper-${user.name}
> clientPort=2181
> initLimit=5
> syncLimit=2
> server.1=zoo1:2888:3888
> server.2=zoo2:2888:3888
> server.3=zoo3:2888:3888
> I think Java already has a system for configuration that allows something like this using Properties?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-279) Variable expansion in zoo.cfg

Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nitay Joffe updated ZOOKEEPER-279:
----------------------------------

    Affects Version/s: 3.1.0
               Status: Patch Available  (was: Open)

Can we get a review for this?

> Variable expansion in zoo.cfg
> -----------------------------
>
>                 Key: ZOOKEEPER-279
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-279
>             Project: Zookeeper
>          Issue Type: Improvement
>    Affects Versions: 3.1.0
>            Reporter: Nitay Joffe
>            Priority: Minor
>         Attachments: HBaseQPC.java, zookeeper-279.patch
>
>
> We would like to define certain parts of ZooKeeper's configuration using variables that get substituted. For example, we want the ZooKeeper quorum to be able to use a dataDir configured per user. In other words, something like:
> tickTime=2000
> dataDir=/tmp/zookeeper-${user.name}
> clientPort=2181
> initLimit=5
> syncLimit=2
> server.1=zoo1:2888:3888
> server.2=zoo2:2888:3888
> server.3=zoo3:2888:3888
> I think Java already has a system for configuration that allows something like this using Properties?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-279) Allow specialization of quorum config parsing (e.g. variable expansion in zoo.cfg)

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680850#action_12680850 ] 

Hudson commented on ZOOKEEPER-279:
----------------------------------

Integrated in ZooKeeper-trunk #251 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/251/])
    

> Allow specialization of quorum config parsing (e.g. variable expansion in zoo.cfg)
> ----------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-279
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-279
>             Project: Zookeeper
>          Issue Type: Improvement
>    Affects Versions: 3.1.0
>            Reporter: Nitay Joffe
>            Assignee: Jean-Daniel Cryans
>            Priority: Minor
>             Fix For: 3.1.1, 3.2.0
>
>         Attachments: HBaseQPC.java, zookeeper-279.patch, zookeeper-279.patch
>
>
> We would like to define certain parts of ZooKeeper's configuration using variables that get substituted. For example, we want the ZooKeeper quorum to be able to use a dataDir configured per user. In other words, something like:
> tickTime=2000
> dataDir=/tmp/zookeeper-${user.name}
> clientPort=2181
> initLimit=5
> syncLimit=2
> server.1=zoo1:2888:3888
> server.2=zoo2:2888:3888
> server.3=zoo3:2888:3888
> I think Java already has a system for configuration that allows something like this using Properties?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-279) Variable expansion in zoo.cfg

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679350#action_12679350 ] 

Mahadev konar commented on ZOOKEEPER-279:
-----------------------------------------

+1 for hte changes... the patch would need to be regenerated against the trunk.

> Variable expansion in zoo.cfg
> -----------------------------
>
>                 Key: ZOOKEEPER-279
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-279
>             Project: Zookeeper
>          Issue Type: Improvement
>    Affects Versions: 3.1.0
>            Reporter: Nitay Joffe
>            Priority: Minor
>         Attachments: HBaseQPC.java, zookeeper-279.patch
>
>
> We would like to define certain parts of ZooKeeper's configuration using variables that get substituted. For example, we want the ZooKeeper quorum to be able to use a dataDir configured per user. In other words, something like:
> tickTime=2000
> dataDir=/tmp/zookeeper-${user.name}
> clientPort=2181
> initLimit=5
> syncLimit=2
> server.1=zoo1:2888:3888
> server.2=zoo2:2888:3888
> server.3=zoo3:2888:3888
> I think Java already has a system for configuration that allows something like this using Properties?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-279) Variable expansion in zoo.cfg

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679359#action_12679359 ] 

Patrick Hunt commented on ZOOKEEPER-279:
----------------------------------------

Yea, we are excited to see hbase using zk, please let us know if you have questions or would like to discuss recipes/approach/etc...


> Variable expansion in zoo.cfg
> -----------------------------
>
>                 Key: ZOOKEEPER-279
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-279
>             Project: Zookeeper
>          Issue Type: Improvement
>    Affects Versions: 3.1.0
>            Reporter: Nitay Joffe
>            Assignee: Jean-Daniel Cryans
>            Priority: Minor
>             Fix For: 3.1.1, 3.2.0
>
>         Attachments: HBaseQPC.java, zookeeper-279.patch
>
>
> We would like to define certain parts of ZooKeeper's configuration using variables that get substituted. For example, we want the ZooKeeper quorum to be able to use a dataDir configured per user. In other words, something like:
> tickTime=2000
> dataDir=/tmp/zookeeper-${user.name}
> clientPort=2181
> initLimit=5
> syncLimit=2
> server.1=zoo1:2888:3888
> server.2=zoo2:2888:3888
> server.3=zoo3:2888:3888
> I think Java already has a system for configuration that allows something like this using Properties?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-279) Variable expansion in zoo.cfg

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-279:
-----------------------------------

    Attachment: zookeeper-279.patch

Updated the patch to successfully apply against the latest codebase.

+1 - will be committed for 3.1.1/3.2 releases.

> Variable expansion in zoo.cfg
> -----------------------------
>
>                 Key: ZOOKEEPER-279
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-279
>             Project: Zookeeper
>          Issue Type: Improvement
>    Affects Versions: 3.1.0
>            Reporter: Nitay Joffe
>            Assignee: Jean-Daniel Cryans
>            Priority: Minor
>             Fix For: 3.1.1, 3.2.0
>
>         Attachments: HBaseQPC.java, zookeeper-279.patch, zookeeper-279.patch
>
>
> We would like to define certain parts of ZooKeeper's configuration using variables that get substituted. For example, we want the ZooKeeper quorum to be able to use a dataDir configured per user. In other words, something like:
> tickTime=2000
> dataDir=/tmp/zookeeper-${user.name}
> clientPort=2181
> initLimit=5
> syncLimit=2
> server.1=zoo1:2888:3888
> server.2=zoo2:2888:3888
> server.3=zoo3:2888:3888
> I think Java already has a system for configuration that allows something like this using Properties?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-279) Variable expansion in zoo.cfg

Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Daniel Cryans updated ZOOKEEPER-279:
-----------------------------------------

    Attachment: HBaseQPC.java

Example of what we can do with previously posted patch.

> Variable expansion in zoo.cfg
> -----------------------------
>
>                 Key: ZOOKEEPER-279
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-279
>             Project: Zookeeper
>          Issue Type: Improvement
>            Reporter: Nitay Joffe
>            Priority: Minor
>         Attachments: HBaseQPC.java, zookeeper-279.patch
>
>
> We would like to define certain parts of ZooKeeper's configuration using variables that get substituted. For example, we want the ZooKeeper quorum to be able to use a dataDir configured per user. In other words, something like:
> tickTime=2000
> dataDir=/tmp/zookeeper-${user.name}
> clientPort=2181
> initLimit=5
> syncLimit=2
> server.1=zoo1:2888:3888
> server.2=zoo2:2888:3888
> server.3=zoo3:2888:3888
> I think Java already has a system for configuration that allows something like this using Properties?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-279) Variable expansion in zoo.cfg

Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679356#action_12679356 ] 

Jean-Daniel Cryans commented on ZOOKEEPER-279:
----------------------------------------------

Thanks a lot Patrick. We'll have other patches coming in in the following weeks so stay tunned ;)

> Variable expansion in zoo.cfg
> -----------------------------
>
>                 Key: ZOOKEEPER-279
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-279
>             Project: Zookeeper
>          Issue Type: Improvement
>    Affects Versions: 3.1.0
>            Reporter: Nitay Joffe
>            Priority: Minor
>             Fix For: 3.1.1, 3.2.0
>
>         Attachments: HBaseQPC.java, zookeeper-279.patch
>
>
> We would like to define certain parts of ZooKeeper's configuration using variables that get substituted. For example, we want the ZooKeeper quorum to be able to use a dataDir configured per user. In other words, something like:
> tickTime=2000
> dataDir=/tmp/zookeeper-${user.name}
> clientPort=2181
> initLimit=5
> syncLimit=2
> server.1=zoo1:2888:3888
> server.2=zoo2:2888:3888
> server.3=zoo3:2888:3888
> I think Java already has a system for configuration that allows something like this using Properties?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (ZOOKEEPER-279) Variable expansion in zoo.cfg

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt reassigned ZOOKEEPER-279:
--------------------------------------

    Assignee: Jean-Daniel Cryans

> Variable expansion in zoo.cfg
> -----------------------------
>
>                 Key: ZOOKEEPER-279
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-279
>             Project: Zookeeper
>          Issue Type: Improvement
>    Affects Versions: 3.1.0
>            Reporter: Nitay Joffe
>            Assignee: Jean-Daniel Cryans
>            Priority: Minor
>             Fix For: 3.1.1, 3.2.0
>
>         Attachments: HBaseQPC.java, zookeeper-279.patch
>
>
> We would like to define certain parts of ZooKeeper's configuration using variables that get substituted. For example, we want the ZooKeeper quorum to be able to use a dataDir configured per user. In other words, something like:
> tickTime=2000
> dataDir=/tmp/zookeeper-${user.name}
> clientPort=2181
> initLimit=5
> syncLimit=2
> server.1=zoo1:2888:3888
> server.2=zoo2:2888:3888
> server.3=zoo3:2888:3888
> I think Java already has a system for configuration that allows something like this using Properties?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-279) Allow specialization of quorum config parsing (e.g. variable expansion in zoo.cfg)

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-279:
-----------------------------------

    Summary: Allow specialization of quorum config parsing (e.g. variable expansion in zoo.cfg)  (was: Variable expansion in zoo.cfg)

> Allow specialization of quorum config parsing (e.g. variable expansion in zoo.cfg)
> ----------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-279
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-279
>             Project: Zookeeper
>          Issue Type: Improvement
>    Affects Versions: 3.1.0
>            Reporter: Nitay Joffe
>            Assignee: Jean-Daniel Cryans
>            Priority: Minor
>             Fix For: 3.1.1, 3.2.0
>
>         Attachments: HBaseQPC.java, zookeeper-279.patch, zookeeper-279.patch
>
>
> We would like to define certain parts of ZooKeeper's configuration using variables that get substituted. For example, we want the ZooKeeper quorum to be able to use a dataDir configured per user. In other words, something like:
> tickTime=2000
> dataDir=/tmp/zookeeper-${user.name}
> clientPort=2181
> initLimit=5
> syncLimit=2
> server.1=zoo1:2888:3888
> server.2=zoo2:2888:3888
> server.3=zoo3:2888:3888
> I think Java already has a system for configuration that allows something like this using Properties?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-279) Variable expansion in zoo.cfg

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679354#action_12679354 ] 

Patrick Hunt commented on ZOOKEEPER-279:
----------------------------------------

I'll take care of regenning the patch. Sorry for the delay, somehow we missed this one.

> Variable expansion in zoo.cfg
> -----------------------------
>
>                 Key: ZOOKEEPER-279
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-279
>             Project: Zookeeper
>          Issue Type: Improvement
>    Affects Versions: 3.1.0
>            Reporter: Nitay Joffe
>            Priority: Minor
>         Attachments: HBaseQPC.java, zookeeper-279.patch
>
>
> We would like to define certain parts of ZooKeeper's configuration using variables that get substituted. For example, we want the ZooKeeper quorum to be able to use a dataDir configured per user. In other words, something like:
> tickTime=2000
> dataDir=/tmp/zookeeper-${user.name}
> clientPort=2181
> initLimit=5
> syncLimit=2
> server.1=zoo1:2888:3888
> server.2=zoo2:2888:3888
> server.3=zoo3:2888:3888
> I think Java already has a system for configuration that allows something like this using Properties?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.