You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/03 21:40:56 UTC
[GitHub] [spark] MaxGekk opened a new pull request #28721: [SPARK-28624][SQL][TESTS] Run date.sql via Thrift Server
MaxGekk opened a new pull request #28721:
URL: https://github.com/apache/spark/pull/28721
### What changes were proposed in this pull request?
Enable `date.sql` and run it via Thrift Server in `ThriftServerQueryTestSuite`.
### Why are the changes needed?
To improve test coverage.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
By running the enabled tests via:
```
$ build/sbt -Phive-thriftserver "hive-thriftserver/test-only *ThriftServerQueryTestSuite -- -z date.sql"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28721: [SPARK-28624][SQL][TESTS] Run date.sql via Thrift Server
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28721:
URL: https://github.com/apache/spark/pull/28721#issuecomment-638500134
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123508/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28721: [SPARK-28624][SQL][TESTS] Run date.sql via Thrift Server
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28721:
URL: https://github.com/apache/spark/pull/28721#issuecomment-638500128
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28721: [SPARK-28624][SQL][TESTS] Run date.sql via Thrift Server
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28721:
URL: https://github.com/apache/spark/pull/28721#issuecomment-638516851
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28721: [SPARK-28624][SQL][TESTS] Run date.sql via Thrift Server
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28721:
URL: https://github.com/apache/spark/pull/28721#issuecomment-638500128
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28721: [SPARK-28624][SQL][TESTS] Run date.sql via Thrift Server
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28721:
URL: https://github.com/apache/spark/pull/28721#issuecomment-638478344
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28721: [SPARK-28624][SQL][TESTS] Run date.sql via Thrift Server
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28721:
URL: https://github.com/apache/spark/pull/28721#issuecomment-638516851
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #28721: [SPARK-28624][SQL][TESTS] Run date.sql via Thrift Server
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #28721:
URL: https://github.com/apache/spark/pull/28721#issuecomment-638515820
Looks nice if the tests passed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28721: [SPARK-28624][SQL][TESTS] Run date.sql via Thrift Server
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28721:
URL: https://github.com/apache/spark/pull/28721#issuecomment-638478056
**[Test build #123508 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123508/testReport)** for PR 28721 at commit [`abd7bed`](https://github.com/apache/spark/commit/abd7bed02f7f135a68ecea90d1546b4740cc1963).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28721: [SPARK-28624][SQL][TESTS] Run date.sql via Thrift Server
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28721:
URL: https://github.com/apache/spark/pull/28721#issuecomment-638478056
**[Test build #123508 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123508/testReport)** for PR 28721 at commit [`abd7bed`](https://github.com/apache/spark/commit/abd7bed02f7f135a68ecea90d1546b4740cc1963).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28721: [SPARK-28624][SQL][TESTS] Run date.sql via Thrift Server
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28721:
URL: https://github.com/apache/spark/pull/28721#issuecomment-638499883
**[Test build #123508 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123508/testReport)** for PR 28721 at commit [`abd7bed`](https://github.com/apache/spark/commit/abd7bed02f7f135a68ecea90d1546b4740cc1963).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28721: [SPARK-28624][SQL][TESTS] Run date.sql via Thrift Server
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28721:
URL: https://github.com/apache/spark/pull/28721#issuecomment-638478344
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #28721: [SPARK-28624][SQL][TESTS] Run date.sql via Thrift Server
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #28721:
URL: https://github.com/apache/spark/pull/28721#issuecomment-638543724
This fix can be merged into branch-3.0? I'm not really sure that `branch-3.0` has no issue described in SPARK-28624 though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28721: [SPARK-28624][SQL][TESTS] Run date.sql via Thrift Server
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28721:
URL: https://github.com/apache/spark/pull/28721#issuecomment-638531417
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #28721: [SPARK-28624][SQL][TESTS] Run date.sql via Thrift Server
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28721:
URL: https://github.com/apache/spark/pull/28721#issuecomment-638551511
Let me merge it to master first. From reading the JIRA, seems it's fixed only in the master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #28721: [SPARK-28624][SQL][TESTS] Run date.sql via Thrift Server
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28721:
URL: https://github.com/apache/spark/pull/28721#issuecomment-638551553
Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28721: [SPARK-28624][SQL][TESTS] Run date.sql via Thrift Server
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28721:
URL: https://github.com/apache/spark/pull/28721#issuecomment-638516538
**[Test build #123512 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123512/testReport)** for PR 28721 at commit [`abd7bed`](https://github.com/apache/spark/commit/abd7bed02f7f135a68ecea90d1546b4740cc1963).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28721: [SPARK-28624][SQL][TESTS] Run date.sql via Thrift Server
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28721:
URL: https://github.com/apache/spark/pull/28721#issuecomment-638516538
**[Test build #123512 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123512/testReport)** for PR 28721 at commit [`abd7bed`](https://github.com/apache/spark/commit/abd7bed02f7f135a68ecea90d1546b4740cc1963).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28721: [SPARK-28624][SQL][TESTS] Run date.sql via Thrift Server
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28721:
URL: https://github.com/apache/spark/pull/28721#issuecomment-638531417
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #28721: [SPARK-28624][SQL][TESTS] Run date.sql via Thrift Server
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #28721:
URL: https://github.com/apache/spark/pull/28721
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #28721: [SPARK-28624][SQL][TESTS] Run date.sql via Thrift Server
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #28721:
URL: https://github.com/apache/spark/pull/28721#issuecomment-638515765
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28721: [SPARK-28624][SQL][TESTS] Run date.sql via Thrift Server
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28721:
URL: https://github.com/apache/spark/pull/28721#issuecomment-638531245
**[Test build #123512 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123512/testReport)** for PR 28721 at commit [`abd7bed`](https://github.com/apache/spark/commit/abd7bed02f7f135a68ecea90d1546b4740cc1963).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #28721: [SPARK-28624][SQL][TESTS] Run date.sql via Thrift Server
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28721:
URL: https://github.com/apache/spark/pull/28721#issuecomment-639290601
I had an offline discussion with @MaxGekk and @cloud-fan. Per https://github.com/apache/spark/pull/28723#issuecomment-639285714, I will revert this too.
Again, technically it was fine to merge in a way because the skipped tests passed. I am here reverting this rather for the management purpose - the JIRA isn't resolved yet because we need to discuss if the result is correct or not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org